Attention is currently required from: Ashish Kumar Mishra, Deepti Deshatty, Shelley Chen, Vijay P Hiremath.
Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81207?usp=email )
Change subject: mb/google/brox: Enable PMC pins to work with PD
......................................................................
Patch Set 2:
(3 comments)
File src/mainboard/google/brox/variants/baseboard/brox/gpio.c:
https://review.coreboot.org/c/coreboot/+/81207/comment/011e3c47_ed84cfda :
PS2, Line 105: NC
should remove NC?
https://review.coreboot.org/c/coreboot/+/81207/comment/e9686872_df850953 :
PS2, Line 137: NC
same
https://review.coreboot.org/c/coreboot/+/81207/comment/20613abe_db95787d :
PS2, Line 139: NC
same
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81207?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ia678d291e7a14aefe09026e70478fea3f68c8e10
Gerrit-Change-Number: 81207
Gerrit-PatchSet: 2
Gerrit-Owner: Ashish Kumar Mishra
ashish.k.mishra@intel.com
Gerrit-Reviewer: Deepti Deshatty
deepti.deshatty@intel.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Vijay P Hiremath
vijay.p.hiremath@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Eric Lai
ericllai@google.com
Gerrit-CC: Varshit Pandya
pandyavarshit@gmail.com
Gerrit-Attention: Shelley Chen
shchen@google.com
Gerrit-Attention: Ashish Kumar Mishra
ashish.k.mishra@intel.com
Gerrit-Attention: Vijay P Hiremath
vijay.p.hiremath@intel.com
Gerrit-Attention: Deepti Deshatty
deepti.deshatty@intel.com
Gerrit-Comment-Date: Thu, 28 Mar 2024 08:29:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment