Attention is currently required from: Arthur Heymans, ron minnich.
Philipp Hug has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81088?usp=email )
Change subject: Add a new config variable, RISCV_PRIV_VERSION
......................................................................
Patch Set 2:
(2 comments)
File src/arch/riscv/Kconfig:
https://review.coreboot.org/c/coreboot/+/81088/comment/69f5e37f_7ecdb98f :
PS2, Line 113: # Privilege version. There is no default that will work across all
privileged specification version
https://review.coreboot.org/c/coreboot/+/81088/comment/b6b99d44_f3be5dcb :
PS2, Line 116: int
can we have a choice instead of an int? I think this would be cleaner
e.g. RISCV_PRIV_SPEC_VERSION_V1_10
RISCV_PRIV_SPEC_VERSION_V1_12
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81088?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ife8d2b70f115c4193b9a8434ebe05893c20224b6
Gerrit-Change-Number: 81088
Gerrit-PatchSet: 2
Gerrit-Owner: ron minnich
rminnich@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur.heymans@9elements.com
Gerrit-Reviewer: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Reviewer: Philipp Hug
philipp@hug.cx
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Arthur Heymans
arthur.heymans@9elements.com
Gerrit-Attention: ron minnich
rminnich@gmail.com
Gerrit-Comment-Date: Fri, 08 Mar 2024 18:08:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment