Attention is currently required from: Angel Pons, Keith Hui.
Riku Viitanen has posted comments on this change by Riku Viitanen. ( https://review.coreboot.org/c/coreboot/+/85772?usp=email )
Change subject: mb/asrock: Add Z77 Extreme4 ......................................................................
Patch Set 12:
(2 comments)
Patchset:
PS12:
Do you have to do anything special to make a PS/2 mouse work?
Nope, it just works automatically in Devuan Daedalus (Linux 6.1 and Xfce 4.18).
Kinda makes sense, since in vendor firmware there's also no setting to choose between a mouse and a keyboard.
But on the other hand I recall seeing some other board in coreboot that had some issues with PS/2 mice connected like this.
File src/mainboard/asrock/z77_extreme4/early_init.c:
https://review.coreboot.org/c/coreboot/+/85772/comment/44bcd991_f8be791c?usp... : PS12, Line 10: if (CONFIG(CONSOLE_SERIAL))
The function will no-op itself if this config is not selected, so it's not necessary.
Ack. Having the "if" here makes more sense imo. But yeah it's a bit redundant at the moment. Many other boards do this too, perhaps we should consistently have one style or the other.
-
Riku Viitanen (Code Review)