Change in coreboot[master]: SMBIOS: Remove duplicated smbios_memory_type enum - coreboot-gerrit

15 Nov 2018


      Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/29638 )
Change subject: SMBIOS: Remove duplicated smbios_memory_type enum
......................................................................
Patch Set 3: Code-Review-1
As you already pointed out, not only the name, but the information provided changed. You must make sure all calling functions return the correct information (MT/s vs MHz). Also I doubt that this change has any effect without advertising smbios 3.2 and it will only confuse developers even more.
-- 
To view, visit https://review.coreboot.org/29638
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I49554d13f1b6371b85a58cc1263608ad9e99130e
Gerrit-Change-Number: 29638
Gerrit-PatchSet: 3
Gerrit-Owner: Elyes HAOUAS ehaouas@noos.fr
Gerrit-Reviewer: Elyes HAOUAS ehaouas@noos.fr
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Richard Spiegel richard.spiegel@silverbackltd.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 15 Nov 2018 07:01:34 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: Yes