HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37411 )
Change subject: src: Add missing include <types.h> ......................................................................
src: Add missing include <types.h>
Change-Id: Iabe55bfbc8e047c0791c21d162767081a181b6c5 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/drivers/i2c/ptn3460/ptn3460.h M src/drivers/ipmi/ipmi_ops.c M src/ec/lenovo/h8/bluetooth.c 3 files changed, 3 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/11/37411/1
diff --git a/src/drivers/i2c/ptn3460/ptn3460.h b/src/drivers/i2c/ptn3460/ptn3460.h index 4b9834e..f8242f8 100644 --- a/src/drivers/i2c/ptn3460/ptn3460.h +++ b/src/drivers/i2c/ptn3460/ptn3460.h @@ -16,7 +16,7 @@ #ifndef _I2C_PTN3460_H_ #define _I2C_PTN3460_H_
-#include <stdint.h> +#include <types.h>
#define PTN_EDID_OFF 0x00 #define PTN_EDID_LEN 0x80 diff --git a/src/drivers/ipmi/ipmi_ops.c b/src/drivers/ipmi/ipmi_ops.c index 8a189bd..a53929a 100644 --- a/src/drivers/ipmi/ipmi_ops.c +++ b/src/drivers/ipmi/ipmi_ops.c @@ -17,6 +17,7 @@ #include <console/console.h> #include "ipmi_ops.h" #include <string.h> +#include <types.h>
enum cb_err ipmi_init_and_start_bmc_wdt(const int port, uint16_t countdown, uint8_t action) diff --git a/src/ec/lenovo/h8/bluetooth.c b/src/ec/lenovo/h8/bluetooth.c index c3a2555..436b319 100644 --- a/src/ec/lenovo/h8/bluetooth.c +++ b/src/ec/lenovo/h8/bluetooth.c @@ -18,6 +18,7 @@ #include <device/device.h> #include <ec/acpi/ec.h> #include <option.h> +#include <types.h>
#include "h8.h" #include "chip.h"
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37411 )
Change subject: src: Add missing include <types.h> ......................................................................
Patch Set 1:
(3 comments)
https://review.coreboot.org/c/coreboot/+/37411/1/src/drivers/i2c/ptn3460/ptn... File src/drivers/i2c/ptn3460/ptn3460.h:
https://review.coreboot.org/c/coreboot/+/37411/1/src/drivers/i2c/ptn3460/ptn... PS1, Line 69: cb_err #include <types.h>
https://review.coreboot.org/c/coreboot/+/37411/1/src/drivers/ipmi/ipmi_ops.c File src/drivers/ipmi/ipmi_ops.c:
https://review.coreboot.org/c/coreboot/+/37411/1/src/drivers/ipmi/ipmi_ops.c... PS1, Line 22: cb_err #include <types.h>
https://review.coreboot.org/c/coreboot/+/37411/1/src/ec/lenovo/h8/bluetooth.... File src/ec/lenovo/h8/bluetooth.c:
https://review.coreboot.org/c/coreboot/+/37411/1/src/ec/lenovo/h8/bluetooth.... PS1, Line 66: CB_SUCCESS #include <types.h>
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37411 )
Change subject: src: Add missing include <types.h> ......................................................................
Patch Set 3: Code-Review+2
Kyösti Mälkki has submitted this change. ( https://review.coreboot.org/c/coreboot/+/37411 )
Change subject: src: Add missing include <types.h> ......................................................................
src: Add missing include <types.h>
Change-Id: Iabe55bfbc8e047c0791c21d162767081a181b6c5 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/37411 Reviewed-by: Kyösti Mälkki kyosti.malkki@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/drivers/i2c/ptn3460/ptn3460.h M src/drivers/ipmi/ipmi_ops.c M src/ec/lenovo/h8/bluetooth.c 3 files changed, 3 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Kyösti Mälkki: Looks good to me, approved
diff --git a/src/drivers/i2c/ptn3460/ptn3460.h b/src/drivers/i2c/ptn3460/ptn3460.h index 4b9834e..f8242f8 100644 --- a/src/drivers/i2c/ptn3460/ptn3460.h +++ b/src/drivers/i2c/ptn3460/ptn3460.h @@ -16,7 +16,7 @@ #ifndef _I2C_PTN3460_H_ #define _I2C_PTN3460_H_
-#include <stdint.h> +#include <types.h>
#define PTN_EDID_OFF 0x00 #define PTN_EDID_LEN 0x80 diff --git a/src/drivers/ipmi/ipmi_ops.c b/src/drivers/ipmi/ipmi_ops.c index 8a189bd..a53929a 100644 --- a/src/drivers/ipmi/ipmi_ops.c +++ b/src/drivers/ipmi/ipmi_ops.c @@ -17,6 +17,7 @@ #include <console/console.h> #include "ipmi_ops.h" #include <string.h> +#include <types.h>
enum cb_err ipmi_init_and_start_bmc_wdt(const int port, uint16_t countdown, uint8_t action) diff --git a/src/ec/lenovo/h8/bluetooth.c b/src/ec/lenovo/h8/bluetooth.c index c3a2555..436b319 100644 --- a/src/ec/lenovo/h8/bluetooth.c +++ b/src/ec/lenovo/h8/bluetooth.c @@ -18,6 +18,7 @@ #include <device/device.h> #include <ec/acpi/ec.h> #include <option.h> +#include <types.h>
#include "h8.h" #include "chip.h"
-
HAOUAS Elyes (Code Review) -
Kyösti Mälkki (Code Review)