build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37427 )
Change subject: soc/intel/tigerlake: Update GPIO configuration ......................................................................
Patch Set 2:
(31 comments)
https://review.coreboot.org/c/coreboot/+/37427/2/src/soc/intel/tigerlake/gpi... File src/soc/intel/tigerlake/gpio.c:
https://review.coreboot.org/c/coreboot/+/37427/2/src/soc/intel/tigerlake/gpi... PS2, Line 56: INTEL_GPP_BASE(GPP_B0, GPP_T0, GPP_T15,26), /* GPP_T */ space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/37427/2/src/soc/intel/tigerlake/gpi... PS2, Line 61: INTEL_GPP_BASE(GPP_S0, GPP_S0, GPP_S7, 67), /* GPP_S */ code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/37427/2/src/soc/intel/tigerlake/gpi... PS2, Line 61: INTEL_GPP_BASE(GPP_S0, GPP_S0, GPP_S7, 67), /* GPP_S */ please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/37427/2/src/soc/intel/tigerlake/gpi... PS2, Line 62: INTEL_GPP_BASE(GPP_S0, GPP_H0, GPP_H23, 75), /* GPP_H */ code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/37427/2/src/soc/intel/tigerlake/gpi... PS2, Line 62: INTEL_GPP_BASE(GPP_S0, GPP_H0, GPP_H23, 75), /* GPP_H */ please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/37427/2/src/soc/intel/tigerlake/gpi... PS2, Line 63: INTEL_GPP_BASE(GPP_S0, GPP_D0, GPP_GSPI2_CLK_LOOPBK, 99), /* GPP_D */ code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/37427/2/src/soc/intel/tigerlake/gpi... PS2, Line 63: INTEL_GPP_BASE(GPP_S0, GPP_D0, GPP_GSPI2_CLK_LOOPBK, 99), /* GPP_D */ please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/37427/2/src/soc/intel/tigerlake/gpi... PS2, Line 64: INTEL_GPP_BASE(GPP_S0, GPP_U0, GPP_GSPI6_CLK_LOOPBK, 120), /* GPP_U */ code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/37427/2/src/soc/intel/tigerlake/gpi... PS2, Line 64: INTEL_GPP_BASE(GPP_S0, GPP_U0, GPP_GSPI6_CLK_LOOPBK, 120), /* GPP_U */ please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/37427/2/src/soc/intel/tigerlake/gpi... PS2, Line 65: INTEL_GPP_BASE(GPP_S0, GPP_VGPIO0, GPP_VGPIO37, 144), /* GPP_VGPIO */ code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/37427/2/src/soc/intel/tigerlake/gpi... PS2, Line 65: INTEL_GPP_BASE(GPP_S0, GPP_VGPIO0, GPP_VGPIO37, 144), /* GPP_VGPIO */ please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/37427/2/src/soc/intel/tigerlake/gpi... PS2, Line 70: INTEL_GPP_BASE(GPD0, GPD0, GPD_DRAM_RESETB, 171), /* GPD */ code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/37427/2/src/soc/intel/tigerlake/gpi... PS2, Line 70: INTEL_GPP_BASE(GPD0, GPD0, GPD_DRAM_RESETB, 171), /* GPD */ please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/37427/2/src/soc/intel/tigerlake/gpi... PS2, Line 75: INTEL_GPP_BASE(GPP_C0, GPP_C0, GPP_C23, 188), /* GPP_F */ code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/37427/2/src/soc/intel/tigerlake/gpi... PS2, Line 75: INTEL_GPP_BASE(GPP_C0, GPP_C0, GPP_C23, 188), /* GPP_F */ please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/37427/2/src/soc/intel/tigerlake/gpi... PS2, Line 76: INTEL_GPP_BASE(GPP_C0, GPP_F0, GPP_F_CLK_LOOPBK, 212), /* GPP_C */ code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/37427/2/src/soc/intel/tigerlake/gpi... PS2, Line 76: INTEL_GPP_BASE(GPP_C0, GPP_F0, GPP_F_CLK_LOOPBK, 212), /* GPP_C */ please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/37427/2/src/soc/intel/tigerlake/gpi... PS2, Line 77: INTEL_GPP_BASE(GPP_C0, GPP_L_BKLTEN, GPP_MLK_RSTB, 237), /* GPP_HVCMOS */ code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/37427/2/src/soc/intel/tigerlake/gpi... PS2, Line 77: INTEL_GPP_BASE(GPP_C0, GPP_L_BKLTEN, GPP_MLK_RSTB, 237), /* GPP_HVCMOS */ please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/37427/2/src/soc/intel/tigerlake/gpi... PS2, Line 78: INTEL_GPP_BASE(GPP_C0, GPP_E0, GPP_E_CLK_LOOPBK, 243), /* GPP_E */ code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/37427/2/src/soc/intel/tigerlake/gpi... PS2, Line 78: INTEL_GPP_BASE(GPP_C0, GPP_E0, GPP_E_CLK_LOOPBK, 243), /* GPP_E */ please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/37427/2/src/soc/intel/tigerlake/gpi... PS2, Line 79: INTEL_GPP_BASE(GPP_C0, GPP_JTAG_TDO, GPP_MLK, 268), /* GPP_JTAG */ code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/37427/2/src/soc/intel/tigerlake/gpi... PS2, Line 79: INTEL_GPP_BASE(GPP_C0, GPP_JTAG_TDO, GPP_MLK, 268), /* GPP_JTAG */ please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/37427/2/src/soc/intel/tigerlake/gpi... PS2, Line 182: { PMC_GPP_A, GPP_A }, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/37427/2/src/soc/intel/tigerlake/gpi... PS2, Line 182: { PMC_GPP_A, GPP_A }, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/37427/2/src/soc/intel/tigerlake/gpi... PS2, Line 189: { PMC_GPP_C, GPP_C }, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/37427/2/src/soc/intel/tigerlake/gpi... PS2, Line 189: { PMC_GPP_C, GPP_C }, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/37427/2/src/soc/intel/tigerlake/gpi... PS2, Line 191: { PMC_GPP_HVCMOS, GPP_HVCMOS }, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/37427/2/src/soc/intel/tigerlake/gpi... PS2, Line 191: { PMC_GPP_HVCMOS, GPP_HVCMOS }, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/37427/2/src/soc/intel/tigerlake/gpi... PS2, Line 195: { PMC_GPP_SPI, GPP_SPI } code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/37427/2/src/soc/intel/tigerlake/gpi... PS2, Line 195: { PMC_GPP_SPI, GPP_SPI } please, no spaces at the start of a line
-
build bot (Jenkins) (Code Review)