Change in coreboot[master]: arch/x86: Change power_res_dev_states[] to be non-static

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Furquan Shaikh (Code Review)

1 May 2020 1 May '20

8:35 a.m.

Furquan Shaikh has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/40935 )

Change subject: arch/x86: Change power_res_dev_states[] to be non-static ......................................................................

arch/x86: Change power_res_dev_states[] to be non-static

Jenkins complains that power_res_dev_states[] should be a const pointer since it is marked static. However, this doesn't really need to be static. Hence, the change drops static keyword.

BUG=b:155428745

Change-Id: Ice2fff6ab3bcd72a059bc905b7462a681f2e6aaf Signed-off-by: Furquan Shaikh furquan@google.com --- M src/arch/x86/acpi_device.c 1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/35/40935/1

diff --git a/src/arch/x86/acpi_device.c b/src/arch/x86/acpi_device.c index b4016ef..653e124 100644 --- a/src/arch/x86/acpi_device.c +++ b/src/arch/x86/acpi_device.c @@ -527,7 +527,7 @@ /* PowerResource() with Enable and/or Reset control */ void acpi_device_add_power_res(const struct acpi_power_res_params *params) { - static const char *power_res_dev_states[] = { "_PR0", "_PR3" }; + const char *power_res_dev_states[] = { "_PR0", "_PR3" }; unsigned int reset_gpio = params->reset_gpio ? params->reset_gpio->pins[0] : 0; unsigned int enable_gpio = params->enable_gpio ? params->enable_gpio->pins[0] : 0; unsigned int stop_gpio = params->stop_gpio ? params->stop_gpio->pins[0] : 0;

Attachments:

attachment.htm (text/html — 2.9 KB)

Show replies by date

build bot (Jenkins) (Code Review)

1 May 1 May

8:36 a.m.

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40935 )

Change subject: arch/x86: Change power_res_dev_states[] to be non-static ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/40935/1/src/arch/x86/acpi_device.c File src/arch/x86/acpi_device.c:

https://review.coreboot.org/c/coreboot/+/40935/1/src/arch/x86/acpi_device.c@... PS1, Line 530: const char *power_res_dev_states[] = { "_PR0", "_PR3" }; char * array declaration might be better as static const

-- To view, visit https://review.coreboot.org/c/coreboot/+/40935 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ice2fff6ab3bcd72a059bc905b7462a681f2e6aaf Gerrit-Change-Number: 40935 Gerrit-PatchSet: 1 Gerrit-Owner: Furquan Shaikh furquan@google.com Gerrit-CC: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Fri, 01 May 2020 06:36:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Furquan Shaikh (Code Review)

8:38 a.m.

Furquan Shaikh has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/40935 )

Change subject: arch/x86: Change power_res_dev_states[] to be non-static ......................................................................

arch/x86: Change power_res_dev_states[] to be non-static

Jenkins complains that power_res_dev_states[] should be a const pointer since it is marked static. However, this doesn't really need to be static. Hence, the change drops static keyword.

BUG=b:155428745

Change-Id: Ice2fff6ab3bcd72a059bc905b7462a681f2e6aaf Signed-off-by: Furquan Shaikh furquan@google.com --- M src/arch/x86/acpi_device.c 1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/35/40935/2

build bot (Jenkins) (Code Review)

8:39 a.m.

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40935 )

Change subject: arch/x86: Change power_res_dev_states[] to be non-static ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/40935/2/src/arch/x86/acpi_device.c File src/arch/x86/acpi_device.c:

https://review.coreboot.org/c/coreboot/+/40935/2/src/arch/x86/acpi_device.c@... PS2, Line 530: const char *power_res_dev_states[] = { "_PR0", "_PR3" }; char * array declaration might be better as static const

-- To view, visit https://review.coreboot.org/c/coreboot/+/40935 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ice2fff6ab3bcd72a059bc905b7462a681f2e6aaf Gerrit-Change-Number: 40935 Gerrit-PatchSet: 2 Gerrit-Owner: Furquan Shaikh furquan@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Fri, 01 May 2020 06:39:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Furquan Shaikh (Code Review)

8:48 a.m.

New subject: Change in coreboot[master]: arch/x86: Change power_res_dev_states[] to be static const * const

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/40935

to look at the new patch set (#3).

Change subject: arch/x86: Change power_res_dev_states[] to be static const * const ......................................................................

arch/x86: Change power_res_dev_states[] to be static const * const

This change makes power_res_dev_states[] to be static const * const as complained by Jenkins.

BUG=b:155428745

Change-Id: Ice2fff6ab3bcd72a059bc905b7462a681f2e6aaf Signed-off-by: Furquan Shaikh furquan@google.com --- M src/arch/x86/acpi_device.c M src/arch/x86/acpigen.c M src/arch/x86/include/arch/acpigen.h 3 files changed, 3 insertions(+), 3 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/35/40935/3

Aaron Durbin (Code Review)

3:43 p.m.

New subject: Change in coreboot[master]: arch/x86: Change power_res_dev_states[] to be static const * const

Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40935 )

Change subject: arch/x86: Change power_res_dev_states[] to be static const * const ......................................................................

Patch Set 4: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/40935 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ice2fff6ab3bcd72a059bc905b7462a681f2e6aaf Gerrit-Change-Number: 40935 Gerrit-PatchSet: 4 Gerrit-Owner: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Fri, 01 May 2020 13:43:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Felix Held (Code Review)

2 May 2 May

2:12 p.m.

New subject: Change in coreboot[master]: arch/x86: Change power_res_dev_states[] to be static const * const

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/40935 )

Change subject: arch/x86: Change power_res_dev_states[] to be static const * const ......................................................................

arch/x86: Change power_res_dev_states[] to be static const * const

This change makes power_res_dev_states[] to be static const * const as complained by Jenkins.

BUG=b:155428745

Change-Id: Ice2fff6ab3bcd72a059bc905b7462a681f2e6aaf Signed-off-by: Furquan Shaikh furquan@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/40935 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Aaron Durbin adurbin@chromium.org --- M src/arch/x86/acpi_device.c M src/arch/x86/acpigen.c M src/arch/x86/include/arch/acpigen.h 3 files changed, 3 insertions(+), 3 deletions(-)

Approvals: build bot (Jenkins): Verified Aaron Durbin: Looks good to me, approved

diff --git a/src/arch/x86/acpi_device.c b/src/arch/x86/acpi_device.c index bef1a5d..9f63200 100644 --- a/src/arch/x86/acpi_device.c +++ b/src/arch/x86/acpi_device.c @@ -527,7 +527,7 @@ /* PowerResource() with Enable and/or Reset control */ void acpi_device_add_power_res(const struct acpi_power_res_params *params) { - static const char *power_res_dev_states[] = { "_PR0", "_PR3" }; + static const char * const power_res_dev_states[] = { "_PR0", "_PR3" }; unsigned int reset_gpio = params->reset_gpio ? params->reset_gpio->pins[0] : 0; unsigned int enable_gpio = params->enable_gpio ? params->enable_gpio->pins[0] : 0; unsigned int stop_gpio = params->stop_gpio ? params->stop_gpio->pins[0] : 0; diff --git a/src/arch/x86/acpigen.c b/src/arch/x86/acpigen.c index 34de2ba..dfc2a5a 100644 --- a/src/arch/x86/acpigen.c +++ b/src/arch/x86/acpigen.c @@ -1147,7 +1147,7 @@ * PowerResource (name, level, order) */ void acpigen_write_power_res(const char *name, uint8_t level, uint16_t order, - const char *dev_states[], size_t dev_states_count) + const char * const dev_states[], size_t dev_states_count) { size_t i; for (i = 0; i < dev_states_count; i++) { diff --git a/src/arch/x86/include/arch/acpigen.h b/src/arch/x86/include/arch/acpigen.h index 3339ce4..a3c4777 100644 --- a/src/arch/x86/include/arch/acpigen.h +++ b/src/arch/x86/include/arch/acpigen.h @@ -347,7 +347,7 @@ void acpigen_write_irq(u16 mask); void acpigen_write_uuid(const char *uuid); void acpigen_write_power_res(const char *name, uint8_t level, uint16_t order, - const char *dev_states[], size_t dev_states_count); + const char * const dev_states[], size_t dev_states_count); void acpigen_write_sleep(uint64_t sleep_ms); void acpigen_write_store(void); void acpigen_write_store_ops(uint8_t src, uint8_t dst);

-- To view, visit https://review.coreboot.org/c/coreboot/+/40935 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ice2fff6ab3bcd72a059bc905b7462a681f2e6aaf Gerrit-Change-Number: 40935 Gerrit-PatchSet: 5 Gerrit-Owner: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: merged

9elements QA (Code Review)

2:46 p.m.

New subject: Change in coreboot[master]: arch/x86: Change power_res_dev_states[] to be static const * const

9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40935 )

Change subject: arch/x86: Change power_res_dev_states[] to be static const * const ......................................................................

Patch Set 5:

Automatic boot test returned (PASS/FAIL/TOTAL): 4/0/4 Emulation targets: "QEMU x86 q35/ich9" using payload TianoCore : SUCCESS : https://lava.9esec.io/r/3112 "QEMU x86 q35/ich9" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/3111 "QEMU x86 i440fx/piix4" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/3110 "QEMU AArch64" using payload LinuxBoot_u-root_kexec : SUCCESS : https://lava.9esec.io/r/3109

Please note: This test is under development and might not be accurate at all!

-- To view, visit https://review.coreboot.org/c/coreboot/+/40935 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ice2fff6ab3bcd72a059bc905b7462a681f2e6aaf Gerrit-Change-Number: 40935 Gerrit-PatchSet: 5 Gerrit-Owner: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: 9elements QA hardwaretestrobot@gmail.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Sat, 02 May 2020 12:46:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1666

days inactive

1667

days old

coreboot-gerrit@coreboot.org

7 comments

5 participants

tags (0)

participants (5)

9elements QA (Code Review)
Aaron Durbin (Code Review)
build bot (Jenkins) (Code Review)
Felix Held (Code Review)
Furquan Shaikh (Code Review)