Attention is currently required from: YH Lin, Tarun Tuli, Subrata Banik, Paul Menzel, Kapil Porwal.
Kun Liu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74475 )
Change subject: mb/google/rex: Add initial setup for gpio config ......................................................................
Patch Set 5:
(7 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/74475/comment/00a6c71f_9668380c PS3, Line 2: liukun11
Please configure your user name. […]
Done
https://review.coreboot.org/c/coreboot/+/74475/comment/53ddd6cd_d8f23cef PS3, Line 7: mb/google/rex: Initial setup for gpio config
Please make it a statement, by adding a verb (in imperative mood); cf `git log --oneline`.
Done
https://review.coreboot.org/c/coreboot/+/74475/comment/b777afd6_fdf6d508 PS3, Line 9: add the initial gpio configuration for the screebo
What is the source for this?
Configure gpio based on the schematic diagram of screenbo project
https://review.coreboot.org/c/coreboot/+/74475/comment/3b50e951_c7d6627d PS3, Line 14: liukun11
Ditto.
Done
File src/mainboard/google/rex/variants/screebo/gpio.c:
https://review.coreboot.org/c/coreboot/+/74475/comment/c9365714_b4a56308 PS3, Line 153:
nit: tab
Done
https://review.coreboot.org/c/coreboot/+/74475/comment/6c3de14f_b080e846 PS3, Line 205:
ditto
Done
https://review.coreboot.org/c/coreboot/+/74475/comment/4943f05b_a5a6cf6f PS3, Line 247:
ditto
Done
-
Kun Liu (Code Review)