Change in ...coreboot[master]: src/mb/Kconfig: Fix PCI subsystem IDs

[Kyösti Mälkki (Code Review)]

Hello HAOUAS Elyes,

I'd like you to do a code review. Please visit

https://review.coreboot.org/c/coreboot/+/32107

to review the following change.

Change subject: src/mb/Kconfig: Fix PCI subsystem IDs
......................................................................

src/mb/Kconfig: Fix PCI subsystem IDs

Change-Id: I72bba8406eea4a264e36cc9bcf467cf5cfbed379
Signed-off-by: Elyes HAOUAS 
Signed-off-by: Kyösti Mälkki 
---
M src/mainboard/gigabyte/ga-h61m-s2pv/Kconfig
M src/mainboard/lenovo/t520/Kconfig
M src/mainboard/lenovo/t530/Kconfig
M util/autoport/bd82x6x.go
4 files changed, 0 insertions(+), 30 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/32107/1

diff --git a/src/mainboard/gigabyte/ga-h61m-s2pv/Kconfig b/src/mainboard/gigabyte/ga-h61m-s2pv/Kconfig
index 5fba47a..5e46365 100644
--- a/src/mainboard/gigabyte/ga-h61m-s2pv/Kconfig
+++ b/src/mainboard/gigabyte/ga-h61m-s2pv/Kconfig
@@ -40,14 +40,6 @@
    string
    default "GA-H61M-S2PV"

-config MAINBOARD_PCI_SUBSYSTEM_DEVICE_ID
-	hex
-	default 0x5001
-
-config MAINBOARD_PCI_SUBSYSTEM_VENDOR_ID
-	hex
-	default 0x1458
-
 config MAX_CPUS
    int
    default 8
diff --git a/src/mainboard/lenovo/t520/Kconfig b/src/mainboard/lenovo/t520/Kconfig
index c414083..06f296b 100644
--- a/src/mainboard/lenovo/t520/Kconfig
+++ b/src/mainboard/lenovo/t520/Kconfig
@@ -65,14 +65,6 @@
    string
    default "pci8086,0126.rom"

-config MAINBOARD_PCI_SUBSYSTEM_VENDOR_ID
-	hex
-	default 0x17aa
-
-config MAINBOARD_PCI_SUBSYSTEM_DEVICE_ID
-	hex
-	default 0x21cf
-
 config ONBOARD_VGA_IS_PRIMARY
    bool
    default y
diff --git a/src/mainboard/lenovo/t530/Kconfig b/src/mainboard/lenovo/t530/Kconfig
index 14f9fb2..b36460d 100644
--- a/src/mainboard/lenovo/t530/Kconfig
+++ b/src/mainboard/lenovo/t530/Kconfig
@@ -62,14 +62,6 @@
    default "pci8086,0106.rom" if BOARD_LENOVO_T530
    default "pci8086,0166.rom" if BOARD_LENOVO_W530

-config MAINBOARD_PCI_SUBSYSTEM_VENDOR_ID
-	hex
-	default 0x17aa
-
-config MAINBOARD_PCI_SUBSYSTEM_DEVICE_ID
-	hex
-	default 0x21fa
-
 config ONBOARD_VGA_IS_PRIMARY
    bool
    default y
diff --git a/util/autoport/bd82x6x.go b/util/autoport/bd82x6x.go
index 265cb6f..a97ff1d 100644
--- a/util/autoport/bd82x6x.go
+++ b/util/autoport/bd82x6x.go
@@ -181,12 +181,6 @@
    }
    KconfigComment["DRAM_RESET_GATE_GPIO"] = "FIXME: check this"

-	/* Not strictly speaking correct. These subsys/subvendor referer to PCI devices.
-	   But most systems don't have any of those. But the config needs to be set
-	   nevertheless. So set it to southbridge subsys/subvendor.  */
-	KconfigHex["MAINBOARD_PCI_SUBSYSTEM_VENDOR_ID"] = uint32(GetLE16(addr.ConfigDump[0x2c:0x2e]))
-	KconfigHex["MAINBOARD_PCI_SUBSYSTEM_DEVICE_ID"] = uint32(GetLE16(addr.ConfigDump[0x2e:0x30]))
-
    ich9GetFlashSize(ctx)

DSDTDefines = append(DSDTDefines,

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32107 )

Change subject: src/mb/Kconfig: Fix PCI subsystem IDs
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/32107/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/#/c/32107/1//COMMIT_MSG@8 
PS1, Line 8: 
Please elaborate.

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has uploaded a new patch set (#2) to the change originally created by Kyösti Mälkki. ( https://review.coreboot.org/c/coreboot/+/32107 )

Change subject: src/mb/Kconfig: Fix PCI subsystem IDs
......................................................................

src/mb/Kconfig: Fix PCI subsystem IDs

References to these were removed in commits

dbd3132 sb/intel/{i82801g/i/j,bd82x6x}: Make use of generic set_subsystem()
 00bb441 sb/intel/lynxpoint: Remove PCI bridge function

The entries removed here under mb/ were already unused because of
one of the three reasons below:

With sb/intel/lynxpoint there was no PCI bridge present in silicon
 Devicetree has 'pci 1e.0 off' disabling the PCI bridge function
 Values were set to 0x0

Change-Id: I72bba8406eea4a264e36cc9bcf467cf5cfbed379
Signed-off-by: Elyes HAOUAS 
Signed-off-by: Kyösti Mälkki 
---
M src/mainboard/aopen/dxplplusu/Kconfig
M src/mainboard/aopen/dxplplusu/devicetree.cb
M src/mainboard/apple/macbookair4_2/Kconfig
M src/mainboard/asrock/b75pro3-m/Kconfig
M src/mainboard/asrock/h81m-hds/Kconfig
M src/mainboard/asus/h61m-cs/Kconfig
M src/mainboard/asus/maximus_iv_gene-z/Kconfig
M src/mainboard/asus/p8h61-m_lx/Kconfig
M src/mainboard/asus/p8h61-m_pro/Kconfig
M src/mainboard/compulab/intense_pc/Kconfig
M src/mainboard/gigabyte/ga-h61m-s2pv/Kconfig
M src/mainboard/google/butterfly/Kconfig
M src/mainboard/google/parrot/Kconfig
M src/mainboard/google/stout/Kconfig
M src/mainboard/hp/2570p/Kconfig
M src/mainboard/hp/2760p/Kconfig
M src/mainboard/hp/8460p/Kconfig
M src/mainboard/hp/8470p/Kconfig
M src/mainboard/hp/8770w/Kconfig
M src/mainboard/hp/compaq_8200_elite_sff/Kconfig
M src/mainboard/hp/folio_9470m/Kconfig
M src/mainboard/hp/revolve_810_g1/Kconfig
M src/mainboard/intel/dcp847ske/Kconfig
M src/mainboard/kontron/ktqm77/Kconfig
M src/mainboard/lenovo/l520/Kconfig
M src/mainboard/lenovo/s230u/Kconfig
M src/mainboard/lenovo/t420/Kconfig
M src/mainboard/lenovo/t420s/Kconfig
M src/mainboard/lenovo/t430/Kconfig
M src/mainboard/lenovo/t430s/Kconfig
M src/mainboard/lenovo/t520/Kconfig
M src/mainboard/lenovo/t530/Kconfig
M src/mainboard/lenovo/x131e/Kconfig
M src/mainboard/lenovo/x1_carbon_gen1/Kconfig
M src/mainboard/lenovo/x220/Kconfig
M src/mainboard/lenovo/x230/Kconfig
M src/mainboard/sapphire/pureplatinumh61/Kconfig
M src/mainboard/supermicro/x10slm-f/Kconfig
M util/autoport/bd82x6x.go
39 files changed, 1 insertion(+), 304 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/32107/2

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has uploaded a new patch set (#3) to the change originally created by Kyösti Mälkki. ( https://review.coreboot.org/c/coreboot/+/32107 )

Change subject: src/mb/Kconfig: Fix PCI subsystem IDs
......................................................................

src/mb/Kconfig: Fix PCI subsystem IDs

References to MAINBOARD_PCI_SUBSYSTEM_{DEVICE_ID,VENDOR_ID} were removed
in commits

dbd3132 sb/intel/{i82801g/i/j,bd82x6x}: Make use of generic set_subsystem()
 00bb441 sb/intel/lynxpoint: Remove PCI bridge function

The entries removed here under mb/ were already unused because of
one of the three reasons below:

With sb/intel/lynxpoint there was no PCI bridge present in silicon
 Devicetree has 'pci 1e.0 off' disabling the PCI bridge function
 Values were set to 0x0

Change-Id: I72bba8406eea4a264e36cc9bcf467cf5cfbed379
Signed-off-by: Elyes HAOUAS 
Signed-off-by: Kyösti Mälkki 
---
M src/mainboard/aopen/dxplplusu/Kconfig
M src/mainboard/aopen/dxplplusu/devicetree.cb
M src/mainboard/apple/macbookair4_2/Kconfig
M src/mainboard/asrock/b75pro3-m/Kconfig
M src/mainboard/asrock/h81m-hds/Kconfig
M src/mainboard/asus/h61m-cs/Kconfig
M src/mainboard/asus/maximus_iv_gene-z/Kconfig
M src/mainboard/asus/p8h61-m_lx/Kconfig
M src/mainboard/asus/p8h61-m_pro/Kconfig
M src/mainboard/compulab/intense_pc/Kconfig
M src/mainboard/gigabyte/ga-h61m-s2pv/Kconfig
M src/mainboard/google/butterfly/Kconfig
M src/mainboard/google/parrot/Kconfig
M src/mainboard/google/stout/Kconfig
M src/mainboard/hp/2570p/Kconfig
M src/mainboard/hp/2760p/Kconfig
M src/mainboard/hp/8460p/Kconfig
M src/mainboard/hp/8470p/Kconfig
M src/mainboard/hp/8770w/Kconfig
M src/mainboard/hp/compaq_8200_elite_sff/Kconfig
M src/mainboard/hp/folio_9470m/Kconfig
M src/mainboard/hp/revolve_810_g1/Kconfig
M src/mainboard/intel/dcp847ske/Kconfig
M src/mainboard/kontron/ktqm77/Kconfig
M src/mainboard/lenovo/l520/Kconfig
M src/mainboard/lenovo/s230u/Kconfig
M src/mainboard/lenovo/t420/Kconfig
M src/mainboard/lenovo/t420s/Kconfig
M src/mainboard/lenovo/t430/Kconfig
M src/mainboard/lenovo/t430s/Kconfig
M src/mainboard/lenovo/t520/Kconfig
M src/mainboard/lenovo/t530/Kconfig
M src/mainboard/lenovo/x131e/Kconfig
M src/mainboard/lenovo/x1_carbon_gen1/Kconfig
M src/mainboard/lenovo/x220/Kconfig
M src/mainboard/lenovo/x230/Kconfig
M src/mainboard/sapphire/pureplatinumh61/Kconfig
M src/mainboard/supermicro/x10slm-f/Kconfig
M util/autoport/bd82x6x.go
39 files changed, 1 insertion(+), 304 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/32107/3

[Patrick Rudolph (Code Review)]

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32107 )

Change subject: src/mb/Kconfig: Fix PCI subsystem IDs
......................................................................

Patch Set 3: Code-Review+2

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32107 )

Change subject: src/mb/Kconfig: Fix PCI subsystem IDs
......................................................................

Patch Set 3: Code-Review-1

(4 comments)

AFAICS, there are only four boards to review and they
weren't. The convoluted commit message hides that very
well.

The already removed code around these Kconfig symbols
was triggered when the symbols were set and `1e.0 on`
in the dt. So we can ignore everything but these:

$ git grep -l '1e.0\s*on' -- $(dirname $(git grep -l MAINBOARD_PCI_SUBSYS))
  src/mainboard/aopen/dxplplusu/devicetree.cb
  src/mainboard/asrock/b75pro3-m/devicetree.cb
  src/mainboard/gigabyte/ga-h61m-s2pv/devicetree.cb
  src/mainboard/hp/compaq_8200_elite_sff/devicetree.cb

https://review.coreboot.org/#/c/32107/3//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/#/c/32107/3//COMMIT_MSG@16 
PS3, Line 16: one of the three reasons below:
doesn't seem true

https://review.coreboot.org/#/c/32107/3/src/mainboard/aopen/dxplplusu/device... 
File src/mainboard/aopen/dxplplusu/devicetree.cb:

https://review.coreboot.org/#/c/32107/3/src/mainboard/aopen/dxplplusu/device... 
PS3, Line 27: 		#TODO: subsystemid ???? ???? inherit
Why add this here? since when are subsystem ids a requirement?

https://review.coreboot.org/#/c/32107/3/src/mainboard/asrock/b75pro3-m/Kconf... 
File src/mainboard/asrock/b75pro3-m/Kconfig:

https://review.coreboot.org/#/c/32107/3/src/mainboard/asrock/b75pro3-m/Kconf... 
PS3, Line 42: 
Devicetree says 0x244e and uses 0x1e49 for the LPC bridge.
However, I would guess that the dt is correct (it's easier to
review and to understand during porting).

https://review.coreboot.org/#/c/32107/3/src/mainboard/gigabyte/ga-h61m-s2pv/... 
File src/mainboard/gigabyte/ga-h61m-s2pv/Kconfig:

https://review.coreboot.org/#/c/32107/3/src/mainboard/gigabyte/ga-h61m-s2pv/... 
PS3, Line 50: 
Devicetree doesn't set it, probably worth to fix?

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32107 )

Change subject: src/mb/Kconfig: Fix PCI subsystem IDs
......................................................................

Patch Set 3:

(2 comments)

https://review.coreboot.org/#/c/32107/3/src/mainboard/asrock/b75pro3-m/Kconf... 
File src/mainboard/asrock/b75pro3-m/Kconfig:

https://review.coreboot.org/#/c/32107/3/src/mainboard/asrock/b75pro3-m/Kconf... 
PS3, Line 42:
> Devicetree says 0x244e and uses 0x1e49 for the LPC bridge. […]

just tagging as resolved

https://review.coreboot.org/#/c/32107/3/src/mainboard/gigabyte/ga-h61m-s2pv/... 
File src/mainboard/gigabyte/ga-h61m-s2pv/Kconfig:

https://review.coreboot.org/#/c/32107/3/src/mainboard/gigabyte/ga-h61m-s2pv/... 
PS3, Line 50:
> Devicetree doesn't set it, probably worth to fix?

Scratch that. I just read the comment in autoport, it
was just broken anyway. And these values are likely
autoport generated.

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has uploaded a new patch set (#4) to the change originally created by Kyösti Mälkki. ( https://review.coreboot.org/c/coreboot/+/32107 )

Change subject: src/mb/Kconfig: Fix PCI subsystem IDs
......................................................................

src/mb/Kconfig: Fix PCI subsystem IDs

References to MAINBOARD_PCI_SUBSYSTEM_{DEVICE_ID,VENDOR_ID} were removed
in commits

dbd3132 sb/intel/{i82801g/i/j,bd82x6x}: Make use of generic set_subsystem()
 00bb441 sb/intel/lynxpoint: Remove PCI bridge function

The entries removed here under mb/ were already unused because of
one of the three reasons below:

With sb/intel/lynxpoint there was no PCI bridge present in silicon
 Devicetree has 'pci 1e.0 off' disabling the PCI bridge function
 Values were set to 0x0

Change-Id: I72bba8406eea4a264e36cc9bcf467cf5cfbed379
Signed-off-by: Elyes HAOUAS 
Signed-off-by: Kyösti Mälkki 
---
M src/mainboard/aopen/dxplplusu/Kconfig
M src/mainboard/apple/macbookair4_2/Kconfig
M src/mainboard/asrock/b75pro3-m/Kconfig
M src/mainboard/asrock/h81m-hds/Kconfig
M src/mainboard/asus/h61m-cs/Kconfig
M src/mainboard/asus/maximus_iv_gene-z/Kconfig
M src/mainboard/asus/p8h61-m_lx/Kconfig
M src/mainboard/asus/p8h61-m_pro/Kconfig
M src/mainboard/compulab/intense_pc/Kconfig
M src/mainboard/gigabyte/ga-h61m-s2pv/Kconfig
M src/mainboard/google/butterfly/Kconfig
M src/mainboard/google/parrot/Kconfig
M src/mainboard/google/stout/Kconfig
M src/mainboard/hp/2570p/Kconfig
M src/mainboard/hp/2760p/Kconfig
M src/mainboard/hp/8460p/Kconfig
M src/mainboard/hp/8470p/Kconfig
M src/mainboard/hp/8770w/Kconfig
M src/mainboard/hp/compaq_8200_elite_sff/Kconfig
M src/mainboard/hp/folio_9470m/Kconfig
M src/mainboard/hp/revolve_810_g1/Kconfig
M src/mainboard/intel/dcp847ske/Kconfig
M src/mainboard/kontron/ktqm77/Kconfig
M src/mainboard/lenovo/l520/Kconfig
M src/mainboard/lenovo/s230u/Kconfig
M src/mainboard/lenovo/t420/Kconfig
M src/mainboard/lenovo/t420s/Kconfig
M src/mainboard/lenovo/t430/Kconfig
M src/mainboard/lenovo/t430s/Kconfig
M src/mainboard/lenovo/t520/Kconfig
M src/mainboard/lenovo/t530/Kconfig
M src/mainboard/lenovo/x131e/Kconfig
M src/mainboard/lenovo/x1_carbon_gen1/Kconfig
M src/mainboard/lenovo/x220/Kconfig
M src/mainboard/lenovo/x230/Kconfig
M src/mainboard/sapphire/pureplatinumh61/Kconfig
M src/mainboard/supermicro/x10slm-f/Kconfig
M util/autoport/bd82x6x.go
38 files changed, 0 insertions(+), 304 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/32107/4

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32107 )

Change subject: src/mb/Kconfig: Fix PCI subsystem IDs
......................................................................

Patch Set 4:

(2 comments)

https://review.coreboot.org/#/c/32107/3//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/#/c/32107/3//COMMIT_MSG@16 
PS3, Line 16: one of the three reasons below:
> doesn't seem true

ping?

I would just remove the whole paragraph. Such justifications
tend to preempt reviews (that could be a positive thing to
avoid unnecessary work, but it would have to be 100% correct).

https://review.coreboot.org/#/c/32107/3/src/mainboard/aopen/dxplplusu/device... 
File src/mainboard/aopen/dxplplusu/devicetree.cb:

https://review.coreboot.org/#/c/32107/3/src/mainboard/aopen/dxplplusu/device... 
PS3, Line 27: 		#TODO: subsystemid ???? ???? inherit
> Why add this here? since when are subsystem ids a requirement?

Done

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32107 )

Change subject: src/mb/Kconfig: Fix PCI subsystem IDs
......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/#/c/32107/3//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/#/c/32107/3//COMMIT_MSG@16 
PS3, Line 16: one of the three reasons below:
> ping? […]

Done

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has uploaded a new patch set (#5) to the change originally created by Kyösti Mälkki. ( https://review.coreboot.org/c/coreboot/+/32107 )

Change subject: src/mb/Kconfig: Fix PCI subsystem IDs
......................................................................

src/mb/Kconfig: Fix PCI subsystem IDs

References to MAINBOARD_PCI_SUBSYSTEM_{DEVICE_ID,VENDOR_ID} were removed
in commits

dbd3132 sb/intel/{i82801g/i/j,bd82x6x}: Make use of generic set_subsystem()
 00bb441 sb/intel/lynxpoint: Remove PCI bridge function

Change-Id: I72bba8406eea4a264e36cc9bcf467cf5cfbed379
Signed-off-by: Elyes HAOUAS 
Signed-off-by: Kyösti Mälkki 
---
M src/mainboard/aopen/dxplplusu/Kconfig
M src/mainboard/apple/macbookair4_2/Kconfig
M src/mainboard/asrock/b75pro3-m/Kconfig
M src/mainboard/asrock/h81m-hds/Kconfig
M src/mainboard/asus/h61m-cs/Kconfig
M src/mainboard/asus/maximus_iv_gene-z/Kconfig
M src/mainboard/asus/p8h61-m_lx/Kconfig
M src/mainboard/asus/p8h61-m_pro/Kconfig
M src/mainboard/compulab/intense_pc/Kconfig
M src/mainboard/gigabyte/ga-h61m-s2pv/Kconfig
M src/mainboard/google/butterfly/Kconfig
M src/mainboard/google/parrot/Kconfig
M src/mainboard/google/stout/Kconfig
M src/mainboard/hp/2570p/Kconfig
M src/mainboard/hp/2760p/Kconfig
M src/mainboard/hp/8460p/Kconfig
M src/mainboard/hp/8470p/Kconfig
M src/mainboard/hp/8770w/Kconfig
M src/mainboard/hp/compaq_8200_elite_sff/Kconfig
M src/mainboard/hp/folio_9470m/Kconfig
M src/mainboard/hp/revolve_810_g1/Kconfig
M src/mainboard/intel/dcp847ske/Kconfig
M src/mainboard/kontron/ktqm77/Kconfig
M src/mainboard/lenovo/l520/Kconfig
M src/mainboard/lenovo/s230u/Kconfig
M src/mainboard/lenovo/t420/Kconfig
M src/mainboard/lenovo/t420s/Kconfig
M src/mainboard/lenovo/t430/Kconfig
M src/mainboard/lenovo/t430s/Kconfig
M src/mainboard/lenovo/t520/Kconfig
M src/mainboard/lenovo/t530/Kconfig
M src/mainboard/lenovo/x131e/Kconfig
M src/mainboard/lenovo/x1_carbon_gen1/Kconfig
M src/mainboard/lenovo/x220/Kconfig
M src/mainboard/lenovo/x230/Kconfig
M src/mainboard/sapphire/pureplatinumh61/Kconfig
M src/mainboard/supermicro/x10slm-f/Kconfig
M util/autoport/bd82x6x.go
38 files changed, 0 insertions(+), 304 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/32107/5

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32107 )

Change subject: src/mb/Kconfig: Fix PCI subsystem IDs
......................................................................

Patch Set 5: Code-Review+2

[Nico Huber (Code Review)]

Nico Huber has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/32107 )

Change subject: src/mb/Kconfig: Fix PCI subsystem IDs
......................................................................

src/mb/Kconfig: Fix PCI subsystem IDs

References to MAINBOARD_PCI_SUBSYSTEM_{DEVICE_ID,VENDOR_ID} were removed
in commits

dbd3132 sb/intel/{i82801g/i/j,bd82x6x}: Make use of generic set_subsystem()
 00bb441 sb/intel/lynxpoint: Remove PCI bridge function

Change-Id: I72bba8406eea4a264e36cc9bcf467cf5cfbed379
Signed-off-by: Elyes HAOUAS 
Signed-off-by: Kyösti Mälkki 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/32107
Reviewed-by: Nico Huber 
Tested-by: build bot (Jenkins) 
---
M src/mainboard/aopen/dxplplusu/Kconfig
M src/mainboard/apple/macbookair4_2/Kconfig
M src/mainboard/asrock/b75pro3-m/Kconfig
M src/mainboard/asrock/h81m-hds/Kconfig
M src/mainboard/asus/h61m-cs/Kconfig
M src/mainboard/asus/maximus_iv_gene-z/Kconfig
M src/mainboard/asus/p8h61-m_lx/Kconfig
M src/mainboard/asus/p8h61-m_pro/Kconfig
M src/mainboard/compulab/intense_pc/Kconfig
M src/mainboard/gigabyte/ga-h61m-s2pv/Kconfig
M src/mainboard/google/butterfly/Kconfig
M src/mainboard/google/parrot/Kconfig
M src/mainboard/google/stout/Kconfig
M src/mainboard/hp/2570p/Kconfig
M src/mainboard/hp/2760p/Kconfig
M src/mainboard/hp/8460p/Kconfig
M src/mainboard/hp/8470p/Kconfig
M src/mainboard/hp/8770w/Kconfig
M src/mainboard/hp/compaq_8200_elite_sff/Kconfig
M src/mainboard/hp/folio_9470m/Kconfig
M src/mainboard/hp/revolve_810_g1/Kconfig
M src/mainboard/intel/dcp847ske/Kconfig
M src/mainboard/kontron/ktqm77/Kconfig
M src/mainboard/lenovo/l520/Kconfig
M src/mainboard/lenovo/s230u/Kconfig
M src/mainboard/lenovo/t420/Kconfig
M src/mainboard/lenovo/t420s/Kconfig
M src/mainboard/lenovo/t430/Kconfig
M src/mainboard/lenovo/t430s/Kconfig
M src/mainboard/lenovo/t520/Kconfig
M src/mainboard/lenovo/t530/Kconfig
M src/mainboard/lenovo/x131e/Kconfig
M src/mainboard/lenovo/x1_carbon_gen1/Kconfig
M src/mainboard/lenovo/x220/Kconfig
M src/mainboard/lenovo/x230/Kconfig
M src/mainboard/sapphire/pureplatinumh61/Kconfig
M src/mainboard/supermicro/x10slm-f/Kconfig
M util/autoport/bd82x6x.go
38 files changed, 0 insertions(+), 304 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Nico Huber: Looks good to me, approved

diff --git a/src/mainboard/aopen/dxplplusu/Kconfig b/src/mainboard/aopen/dxplplusu/Kconfig
index 3a729ce..905ddd5 100644
--- a/src/mainboard/aopen/dxplplusu/Kconfig
+++ b/src/mainboard/aopen/dxplplusu/Kconfig
@@ -33,12 +33,4 @@
    hex
    default 0x4000

-config MAINBOARD_PCI_SUBSYSTEM_VENDOR_ID
-	hex
-	default 0x0
-
-config MAINBOARD_PCI_SUBSYSTEM_DEVICE_ID
-	hex
-	default 0x0
-
 endif # BOARD_AOPEN_DXPLPLUSU
diff --git a/src/mainboard/apple/macbookair4_2/Kconfig b/src/mainboard/apple/macbookair4_2/Kconfig
index 9d4047d..82f120a 100644
--- a/src/mainboard/apple/macbookair4_2/Kconfig
+++ b/src/mainboard/apple/macbookair4_2/Kconfig
@@ -31,14 +31,6 @@
    string
    default "8086,0116"

-config MAINBOARD_PCI_SUBSYSTEM_DEVICE_ID
-	hex
-	default 0x7270
-
-config MAINBOARD_PCI_SUBSYSTEM_VENDOR_ID
-	hex
-	default 0x8086
-
 config DRAM_RESET_GATE_GPIO
    int
    default 60
diff --git a/src/mainboard/asrock/b75pro3-m/Kconfig b/src/mainboard/asrock/b75pro3-m/Kconfig
index 5fc3c5e..8db0eba 100644
--- a/src/mainboard/asrock/b75pro3-m/Kconfig
+++ b/src/mainboard/asrock/b75pro3-m/Kconfig
@@ -37,14 +37,6 @@
    string
    default "B75 Pro3-M"

-config MAINBOARD_PCI_SUBSYSTEM_DEVICE_ID
-	hex
-	default 0x1e49
-
-config MAINBOARD_PCI_SUBSYSTEM_VENDOR_ID
-	hex
-	default 0x1849
-
 config MAX_CPUS
    int
    default 8
diff --git a/src/mainboard/asrock/h81m-hds/Kconfig b/src/mainboard/asrock/h81m-hds/Kconfig
index 55f1637..db2768d 100644
--- a/src/mainboard/asrock/h81m-hds/Kconfig
+++ b/src/mainboard/asrock/h81m-hds/Kconfig
@@ -56,14 +56,6 @@
    string
    default "H81M-HDS"

-config MAINBOARD_PCI_SUBSYSTEM_DEVICE_ID
-	hex
-	default 0x8c5c
-
-config MAINBOARD_PCI_SUBSYSTEM_VENDOR_ID
-	hex
-	default 0x1849
-
 config MAX_CPUS
    int
    default 8
diff --git a/src/mainboard/asus/h61m-cs/Kconfig b/src/mainboard/asus/h61m-cs/Kconfig
index d21c761..60dafda 100644
--- a/src/mainboard/asus/h61m-cs/Kconfig
+++ b/src/mainboard/asus/h61m-cs/Kconfig
@@ -25,14 +25,6 @@
    string
    default "H61M-CS"

-config MAINBOARD_PCI_SUBSYSTEM_DEVICE_ID
-	hex
-	default 0x844d
-
-config MAINBOARD_PCI_SUBSYSTEM_VENDOR_ID
-	hex
-	default 0x1043
-
 config MAX_CPUS
    int
    default 8
diff --git a/src/mainboard/asus/maximus_iv_gene-z/Kconfig b/src/mainboard/asus/maximus_iv_gene-z/Kconfig
index 92d7840..a0bc318 100644
--- a/src/mainboard/asus/maximus_iv_gene-z/Kconfig
+++ b/src/mainboard/asus/maximus_iv_gene-z/Kconfig
@@ -46,14 +46,6 @@
    string
    default "8086,0112"

-config MAINBOARD_PCI_SUBSYSTEM_DEVICE_ID
-	hex
-	default 0x844d
-
-config MAINBOARD_PCI_SUBSYSTEM_VENDOR_ID
-	hex
-	default 0x1043
-
 config MAX_CPUS
    int
    default 8
diff --git a/src/mainboard/asus/p8h61-m_lx/Kconfig b/src/mainboard/asus/p8h61-m_lx/Kconfig
index cc2f8a9..010641a 100644
--- a/src/mainboard/asus/p8h61-m_lx/Kconfig
+++ b/src/mainboard/asus/p8h61-m_lx/Kconfig
@@ -43,14 +43,6 @@
    string
    default "P8H61-M LX"

-config MAINBOARD_PCI_SUBSYSTEM_DEVICE_ID
-	hex
-	default 0x844d
-
-config MAINBOARD_PCI_SUBSYSTEM_VENDOR_ID
-	hex
-	default 0x1043
-
 config MAX_CPUS
    int
    default 8
diff --git a/src/mainboard/asus/p8h61-m_pro/Kconfig b/src/mainboard/asus/p8h61-m_pro/Kconfig
index 082d3e4..93da2cd 100644
--- a/src/mainboard/asus/p8h61-m_pro/Kconfig
+++ b/src/mainboard/asus/p8h61-m_pro/Kconfig
@@ -48,14 +48,6 @@
    string
    default "8086,0152"

-config MAINBOARD_PCI_SUBSYSTEM_DEVICE_ID
-	hex
-	default 0x844d
-
-config MAINBOARD_PCI_SUBSYSTEM_VENDOR_ID
-	hex
-	default 0x1043
-
 config MAX_CPUS
    int
    default 8
diff --git a/src/mainboard/compulab/intense_pc/Kconfig b/src/mainboard/compulab/intense_pc/Kconfig
index 0bfde49..ff697b9 100644
--- a/src/mainboard/compulab/intense_pc/Kconfig
+++ b/src/mainboard/compulab/intense_pc/Kconfig
@@ -28,14 +28,6 @@
    string
    default "8086,0166"

-config MAINBOARD_PCI_SUBSYSTEM_DEVICE_ID
-	hex
-	default 0x7270
-
-config MAINBOARD_PCI_SUBSYSTEM_VENDOR_ID
-	hex
-	default 0x8086
-
 config DRAM_RESET_GATE_GPIO # FIXME: check this
    int
    default 60
diff --git a/src/mainboard/gigabyte/ga-h61m-s2pv/Kconfig b/src/mainboard/gigabyte/ga-h61m-s2pv/Kconfig
index 5fba47a..5e46365 100644
--- a/src/mainboard/gigabyte/ga-h61m-s2pv/Kconfig
+++ b/src/mainboard/gigabyte/ga-h61m-s2pv/Kconfig
@@ -40,14 +40,6 @@
    string
    default "GA-H61M-S2PV"

-config MAINBOARD_PCI_SUBSYSTEM_DEVICE_ID
-	hex
-	default 0x5001
-
-config MAINBOARD_PCI_SUBSYSTEM_VENDOR_ID
-	hex
-	default 0x1458
-
 config MAX_CPUS
    int
    default 8
diff --git a/src/mainboard/google/butterfly/Kconfig b/src/mainboard/google/butterfly/Kconfig
index 570a1b3..24797be 100644
--- a/src/mainboard/google/butterfly/Kconfig
+++ b/src/mainboard/google/butterfly/Kconfig
@@ -40,14 +40,6 @@
    string
    default "pci8086,0106.rom"

-config MAINBOARD_PCI_SUBSYSTEM_VENDOR_ID
-	hex
-	default 0x1ae0
-
-config MAINBOARD_PCI_SUBSYSTEM_DEVICE_ID
-	hex
-	default 0xc000
-
 config MAINBOARD_VENDOR
    string
    default "Hewlett-Packard"
diff --git a/src/mainboard/google/parrot/Kconfig b/src/mainboard/google/parrot/Kconfig
index f2c9b20..1a31da7 100644
--- a/src/mainboard/google/parrot/Kconfig
+++ b/src/mainboard/google/parrot/Kconfig
@@ -41,12 +41,4 @@
    string
    default "pci8086,0106.rom"

-config MAINBOARD_PCI_SUBSYSTEM_VENDOR_ID
-	hex
-	default 0x1ae0
-
-config MAINBOARD_PCI_SUBSYSTEM_DEVICE_ID
-	hex
-	default 0xc000
-
 endif # BOARD_GOOGLE_PARROT
diff --git a/src/mainboard/google/stout/Kconfig b/src/mainboard/google/stout/Kconfig
index c9b67cc..8b3eb0f 100644
--- a/src/mainboard/google/stout/Kconfig
+++ b/src/mainboard/google/stout/Kconfig
@@ -43,12 +43,4 @@
    string
    default "8086,0156"

-config MAINBOARD_PCI_SUBSYSTEM_VENDOR_ID
-	hex
-	default 0x1ae0
-
-config MAINBOARD_PCI_SUBSYSTEM_DEVICE_ID
-	hex
-	default 0xc000
-
 endif # BOARD_GOOGLE_STOUT
diff --git a/src/mainboard/hp/2570p/Kconfig b/src/mainboard/hp/2570p/Kconfig
index f9da619..ff91e4d 100644
--- a/src/mainboard/hp/2570p/Kconfig
+++ b/src/mainboard/hp/2570p/Kconfig
@@ -49,14 +49,6 @@
    string
    default "8086,0166"

-config MAINBOARD_PCI_SUBSYSTEM_DEVICE_ID
-	hex
-	default 0x17df
-
-config MAINBOARD_PCI_SUBSYSTEM_VENDOR_ID
-	hex
-	default 0x103c
-
 config MAX_CPUS
    int
    default 8
diff --git a/src/mainboard/hp/2760p/Kconfig b/src/mainboard/hp/2760p/Kconfig
index af3e31b..ab29836 100644
--- a/src/mainboard/hp/2760p/Kconfig
+++ b/src/mainboard/hp/2760p/Kconfig
@@ -49,14 +49,6 @@
    string
    default "8086,0116"

-config MAINBOARD_PCI_SUBSYSTEM_DEVICE_ID
-	hex
-	default 0x162a
-
-config MAINBOARD_PCI_SUBSYSTEM_VENDOR_ID
-	hex
-	default 0x103c
-
 config MAX_CPUS
    int
    default 8
diff --git a/src/mainboard/hp/8460p/Kconfig b/src/mainboard/hp/8460p/Kconfig
index ca737ea..ca97cd6 100644
--- a/src/mainboard/hp/8460p/Kconfig
+++ b/src/mainboard/hp/8460p/Kconfig
@@ -52,14 +52,6 @@
    string
    default "8086,0116"

-config MAINBOARD_PCI_SUBSYSTEM_DEVICE_ID
-	hex
-	default 0x161c
-
-config MAINBOARD_PCI_SUBSYSTEM_VENDOR_ID
-	hex
-	default 0x103c
-
 config MAX_CPUS
    int
    default 8
diff --git a/src/mainboard/hp/8470p/Kconfig b/src/mainboard/hp/8470p/Kconfig
index d8bf5ec..f23c02f 100644
--- a/src/mainboard/hp/8470p/Kconfig
+++ b/src/mainboard/hp/8470p/Kconfig
@@ -50,14 +50,6 @@
    string
    default "8086,0166"

-config MAINBOARD_PCI_SUBSYSTEM_DEVICE_ID
-	hex
-	default 0x179b
-
-config MAINBOARD_PCI_SUBSYSTEM_VENDOR_ID
-	hex
-	default 0x103c
-
 config MAX_CPUS
    int
    default 8
diff --git a/src/mainboard/hp/8770w/Kconfig b/src/mainboard/hp/8770w/Kconfig
index c60283d..6752085 100644
--- a/src/mainboard/hp/8770w/Kconfig
+++ b/src/mainboard/hp/8770w/Kconfig
@@ -41,14 +41,6 @@
    string
    default "EliteBook 8770w"

-config MAINBOARD_PCI_SUBSYSTEM_DEVICE_ID
-	hex
-	default 0x176c
-
-config MAINBOARD_PCI_SUBSYSTEM_VENDOR_ID
-	hex
-	default 0x103c
-
 config MAX_CPUS
    int
    default 8
diff --git a/src/mainboard/hp/compaq_8200_elite_sff/Kconfig b/src/mainboard/hp/compaq_8200_elite_sff/Kconfig
index c4b9d6d..cbfb0ed 100644
--- a/src/mainboard/hp/compaq_8200_elite_sff/Kconfig
+++ b/src/mainboard/hp/compaq_8200_elite_sff/Kconfig
@@ -35,14 +35,6 @@
    string
    default "8086,0102"

-config MAINBOARD_PCI_SUBSYSTEM_DEVICE_ID
-	hex
-	default 0x1495
-
-config MAINBOARD_PCI_SUBSYSTEM_VENDOR_ID
-	hex
-	default 0x103c
-
 config DRAM_RESET_GATE_GPIO
    int
    default 60
diff --git a/src/mainboard/hp/folio_9470m/Kconfig b/src/mainboard/hp/folio_9470m/Kconfig
index f65aeed..06ca793 100644
--- a/src/mainboard/hp/folio_9470m/Kconfig
+++ b/src/mainboard/hp/folio_9470m/Kconfig
@@ -35,14 +35,6 @@
    string
    default "8086,0166"

-config MAINBOARD_PCI_SUBSYSTEM_DEVICE_ID
-	hex
-	default 0x18df
-
-config MAINBOARD_PCI_SUBSYSTEM_VENDOR_ID
-	hex
-	default 0x103c
-
 config MAX_CPUS
    int
    default 8
diff --git a/src/mainboard/hp/revolve_810_g1/Kconfig b/src/mainboard/hp/revolve_810_g1/Kconfig
index a08a9e5..475e978 100644
--- a/src/mainboard/hp/revolve_810_g1/Kconfig
+++ b/src/mainboard/hp/revolve_810_g1/Kconfig
@@ -37,14 +37,6 @@
    string
    default "8086,0166"

-config MAINBOARD_PCI_SUBSYSTEM_DEVICE_ID
-	hex
-	default 0x18f8
-
-config MAINBOARD_PCI_SUBSYSTEM_VENDOR_ID
-	hex
-	default 0x103c
-
 config DRAM_RESET_GATE_GPIO # FIXME: check this
    int
    default 60
diff --git a/src/mainboard/intel/dcp847ske/Kconfig b/src/mainboard/intel/dcp847ske/Kconfig
index dd7f1ca..b1c7bab 100644
--- a/src/mainboard/intel/dcp847ske/Kconfig
+++ b/src/mainboard/intel/dcp847ske/Kconfig
@@ -41,14 +41,6 @@
    string
    default "8086,0106"

-config MAINBOARD_PCI_SUBSYSTEM_DEVICE_ID
-	hex
-	default 0x2044
-
-config MAINBOARD_PCI_SUBSYSTEM_VENDOR_ID
-	hex
-	default 0x8086
-
 config MAX_CPUS
    int
    default 2
diff --git a/src/mainboard/kontron/ktqm77/Kconfig b/src/mainboard/kontron/ktqm77/Kconfig
index b85d938..043eb01 100644
--- a/src/mainboard/kontron/ktqm77/Kconfig
+++ b/src/mainboard/kontron/ktqm77/Kconfig
@@ -31,14 +31,6 @@
    string
    default "pci8086,0166.rom"

-config MAINBOARD_PCI_SUBSYSTEM_VENDOR_ID
-	hex
-	default 0x0000 # TODO
-
-config MAINBOARD_PCI_SUBSYSTEM_DEVICE_ID
-	hex
-	default 0x0000 # TODO
-
 config MAINBOARD_VENDOR
    string
    default "Kontron"
diff --git a/src/mainboard/lenovo/l520/Kconfig b/src/mainboard/lenovo/l520/Kconfig
index a807316..4495d79 100644
--- a/src/mainboard/lenovo/l520/Kconfig
+++ b/src/mainboard/lenovo/l520/Kconfig
@@ -34,14 +34,6 @@
    string
    default "8086,0126"

-config MAINBOARD_PCI_SUBSYSTEM_DEVICE_ID
-	hex
-	default 0x21dd
-
-config MAINBOARD_PCI_SUBSYSTEM_VENDOR_ID
-	hex
-	default 0x17aa
-
 config DRAM_RESET_GATE_GPIO
    int
    default 10
diff --git a/src/mainboard/lenovo/s230u/Kconfig b/src/mainboard/lenovo/s230u/Kconfig
index 714f13f..9200ad5 100644
--- a/src/mainboard/lenovo/s230u/Kconfig
+++ b/src/mainboard/lenovo/s230u/Kconfig
@@ -52,12 +52,4 @@
    string
    default "8086,0166"

-config MAINBOARD_PCI_SUBSYSTEM_VENDOR_ID
-	hex
-	default 0x17aa
-
-config MAINBOARD_PCI_SUBSYSTEM_DEVICE_ID
-	hex
-	default 0x2205
-
 endif # BOARD_LENOVO_S230U
diff --git a/src/mainboard/lenovo/t420/Kconfig b/src/mainboard/lenovo/t420/Kconfig
index f40e9c0..ce81907 100644
--- a/src/mainboard/lenovo/t420/Kconfig
+++ b/src/mainboard/lenovo/t420/Kconfig
@@ -56,14 +56,6 @@
    string
    default "8086,0126"

-config MAINBOARD_PCI_SUBSYSTEM_VENDOR_ID
-	hex
-	default 0x17aa
-
-config MAINBOARD_PCI_SUBSYSTEM_DEVICE_ID
-	hex
-	default 0x21ce
-
 config ONBOARD_VGA_IS_PRIMARY
    bool
    default y
diff --git a/src/mainboard/lenovo/t420s/Kconfig b/src/mainboard/lenovo/t420s/Kconfig
index 71b94af..c5efb55 100644
--- a/src/mainboard/lenovo/t420s/Kconfig
+++ b/src/mainboard/lenovo/t420s/Kconfig
@@ -55,14 +55,6 @@
    string
    default "8086,0126"

-config MAINBOARD_PCI_SUBSYSTEM_VENDOR_ID
-	hex
-	default 0x17aa
-
-config MAINBOARD_PCI_SUBSYSTEM_DEVICE_ID
-	hex
-	default 0x21d2
-
 config ONBOARD_VGA_IS_PRIMARY
    bool
    default y
diff --git a/src/mainboard/lenovo/t430/Kconfig b/src/mainboard/lenovo/t430/Kconfig
index 687edea..dbeaadb 100644
--- a/src/mainboard/lenovo/t430/Kconfig
+++ b/src/mainboard/lenovo/t430/Kconfig
@@ -38,14 +38,6 @@
    string
    default "8086,0166"

-config MAINBOARD_PCI_SUBSYSTEM_DEVICE_ID
-	hex
-	default 0x21f3
-
-config MAINBOARD_PCI_SUBSYSTEM_VENDOR_ID
-	hex
-	default 0x17aa
-
 config DRAM_RESET_GATE_GPIO
    int
    default 10
diff --git a/src/mainboard/lenovo/t430s/Kconfig b/src/mainboard/lenovo/t430s/Kconfig
index 47ff441..bad1837 100644
--- a/src/mainboard/lenovo/t430s/Kconfig
+++ b/src/mainboard/lenovo/t430s/Kconfig
@@ -60,15 +60,6 @@
    string
    default "pci8086,0166.rom"

-config MAINBOARD_PCI_SUBSYSTEM_VENDOR_ID
-	hex
-	default 0x17aa
-
-config MAINBOARD_PCI_SUBSYSTEM_DEVICE_ID
-	hex
-	default 0x21fb if BOARD_LENOVO_T430S
-	default 0x2208 if BOARD_LENOVO_T431S
-
 config ONBOARD_VGA_IS_PRIMARY
    bool
    default y
diff --git a/src/mainboard/lenovo/t520/Kconfig b/src/mainboard/lenovo/t520/Kconfig
index c414083..06f296b 100644
--- a/src/mainboard/lenovo/t520/Kconfig
+++ b/src/mainboard/lenovo/t520/Kconfig
@@ -65,14 +65,6 @@
    string
    default "pci8086,0126.rom"

-config MAINBOARD_PCI_SUBSYSTEM_VENDOR_ID
-	hex
-	default 0x17aa
-
-config MAINBOARD_PCI_SUBSYSTEM_DEVICE_ID
-	hex
-	default 0x21cf
-
 config ONBOARD_VGA_IS_PRIMARY
    bool
    default y
diff --git a/src/mainboard/lenovo/t530/Kconfig b/src/mainboard/lenovo/t530/Kconfig
index 14f9fb2..b36460d 100644
--- a/src/mainboard/lenovo/t530/Kconfig
+++ b/src/mainboard/lenovo/t530/Kconfig
@@ -62,14 +62,6 @@
    default "pci8086,0106.rom" if BOARD_LENOVO_T530
    default "pci8086,0166.rom" if BOARD_LENOVO_W530

-config MAINBOARD_PCI_SUBSYSTEM_VENDOR_ID
-	hex
-	default 0x17aa
-
-config MAINBOARD_PCI_SUBSYSTEM_DEVICE_ID
-	hex
-	default 0x21fa
-
 config ONBOARD_VGA_IS_PRIMARY
    bool
    default y
diff --git a/src/mainboard/lenovo/x131e/Kconfig b/src/mainboard/lenovo/x131e/Kconfig
index 2f936a9..e7da8d0 100644
--- a/src/mainboard/lenovo/x131e/Kconfig
+++ b/src/mainboard/lenovo/x131e/Kconfig
@@ -37,12 +37,4 @@
    int
    default 2

-config MAINBOARD_PCI_SUBSYSTEM_VENDOR_ID
-	hex
-	default 0x17aa
-
-config MAINBOARD_PCI_SUBSYSTEM_DEVICE_ID
-	hex
-	default 0x21fe
-
 endif # BOARD_LENOVO_X131E
diff --git a/src/mainboard/lenovo/x1_carbon_gen1/Kconfig b/src/mainboard/lenovo/x1_carbon_gen1/Kconfig
index 202fabd..520853c 100644
--- a/src/mainboard/lenovo/x1_carbon_gen1/Kconfig
+++ b/src/mainboard/lenovo/x1_carbon_gen1/Kconfig
@@ -54,12 +54,4 @@
    string
    default "8086,0166"

-config MAINBOARD_PCI_SUBSYSTEM_VENDOR_ID
-	hex
-	default 0x17aa
-
-config MAINBOARD_PCI_SUBSYSTEM_DEVICE_ID
-	hex
-	default 0x21fa
-
 endif # BOARD_LENOVO_X1_CARBON_GEN1
diff --git a/src/mainboard/lenovo/x220/Kconfig b/src/mainboard/lenovo/x220/Kconfig
index 70245d2..16f42e8 100644
--- a/src/mainboard/lenovo/x220/Kconfig
+++ b/src/mainboard/lenovo/x220/Kconfig
@@ -69,13 +69,4 @@
    default "8086,0116" if BOARD_LENOVO_X220I
    default "8086,0126"

-config MAINBOARD_PCI_SUBSYSTEM_VENDOR_ID
-	hex
-	default 0x17aa
-
-config MAINBOARD_PCI_SUBSYSTEM_DEVICE_ID
-	hex
-	default 0x21db if BOARD_LENOVO_X220 || BOARD_LENOVO_X220I
-	default 0x21e8 if BOARD_LENOVO_X1
-
 endif # BOARD_LENOVO_X220 || BOARD_LENOVO_X220I || BOARD_LENOVO_X1
diff --git a/src/mainboard/lenovo/x230/Kconfig b/src/mainboard/lenovo/x230/Kconfig
index 3ec537a..5b34b83 100644
--- a/src/mainboard/lenovo/x230/Kconfig
+++ b/src/mainboard/lenovo/x230/Kconfig
@@ -55,12 +55,4 @@
    string
    default "8086,0166"

-config MAINBOARD_PCI_SUBSYSTEM_VENDOR_ID
-	hex
-	default 0x17aa
-
-config MAINBOARD_PCI_SUBSYSTEM_DEVICE_ID
-	hex
-	default 0x21fa
-
 endif # BOARD_LENOVO_X230
diff --git a/src/mainboard/sapphire/pureplatinumh61/Kconfig b/src/mainboard/sapphire/pureplatinumh61/Kconfig
index 85b2f36..13a93c5 100644
--- a/src/mainboard/sapphire/pureplatinumh61/Kconfig
+++ b/src/mainboard/sapphire/pureplatinumh61/Kconfig
@@ -32,14 +32,6 @@
    string
    default "8086,0162"

-config MAINBOARD_PCI_SUBSYSTEM_DEVICE_ID
-	hex
-	default 0x1007
-
-config MAINBOARD_PCI_SUBSYSTEM_VENDOR_ID
-	hex
-	default 0x174b
-
 config DRAM_RESET_GATE_GPIO
    int
    default 60
diff --git a/src/mainboard/supermicro/x10slm-f/Kconfig b/src/mainboard/supermicro/x10slm-f/Kconfig
index 6bf0b2a..430bed3 100644
--- a/src/mainboard/supermicro/x10slm-f/Kconfig
+++ b/src/mainboard/supermicro/x10slm-f/Kconfig
@@ -44,14 +44,6 @@
    string
    default "X10SLM+-F"

-config MAINBOARD_PCI_SUBSYSTEM_DEVICE_ID
-	hex
-	default 0x0803
-
-config MAINBOARD_PCI_SUBSYSTEM_VENDOR_ID
-	hex
-	default 0x15d9
-
 config MAX_CPUS
    int
    default 8
diff --git a/util/autoport/bd82x6x.go b/util/autoport/bd82x6x.go
index 265cb6f..a97ff1d 100644
--- a/util/autoport/bd82x6x.go
+++ b/util/autoport/bd82x6x.go
@@ -181,12 +181,6 @@
    }
    KconfigComment["DRAM_RESET_GATE_GPIO"] = "FIXME: check this"

-	/* Not strictly speaking correct. These subsys/subvendor referer to PCI devices.
-	   But most systems don't have any of those. But the config needs to be set
-	   nevertheless. So set it to southbridge subsys/subvendor.  */
-	KconfigHex["MAINBOARD_PCI_SUBSYSTEM_VENDOR_ID"] = uint32(GetLE16(addr.ConfigDump[0x2c:0x2e]))
-	KconfigHex["MAINBOARD_PCI_SUBSYSTEM_DEVICE_ID"] = uint32(GetLE16(addr.ConfigDump[0x2e:0x30]))
-
    ich9GetFlashSize(ctx)

DSDTDefines = append(DSDTDefines,

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32107 )

Change subject: src/mb/Kconfig: Fix PCI subsystem IDs
......................................................................

Patch Set 6:

(1 comment)

https://review.coreboot.org/#/c/32107/3//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/#/c/32107/3//COMMIT_MSG@16 
PS3, Line 16: one of the three reasons below:
> Done

Hmm.. which part wasn't true?  I added the paragraph, too late now i guess.

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32107 )

Change subject: src/mb/Kconfig: Fix PCI subsystem IDs
......................................................................

Patch Set 6:

(1 comment)

https://review.coreboot.org/#/c/32107/3//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/#/c/32107/3//COMMIT_MSG@16 
PS3, Line 16: one of the three reasons below:
> Hmm.. which part wasn't true?  I added the paragraph, too late now i guess.

Three boards were non-lynxpoint, had `1e.0 on` and non-zero setting.
I commented on two of them, the third had dt and Kconfig in sync.

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32107 )

Change subject: src/mb/Kconfig: Fix PCI subsystem IDs
......................................................................

Patch Set 6:

(1 comment)

https://review.coreboot.org/#/c/32107/3//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/#/c/32107/3//COMMIT_MSG@16 
PS3, Line 16: one of the three reasons below:
> Three boards were non-lynxpoint, had `1e.0 on` and non-zero setting. […]

The GA-H61M-S2PV does not use said device, it has an UTE IT8892 PCIe-to-PCI bridge. I have a patch fixing some devicetree values but forgot to push it. So, at least for this specific board, this change is not a problem.

Not sure about the Asrock B75 Pro3-M, but it might be in a similar situation.