Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37651 )
Change subject: mainboard/variant/puff: set initial PL values for puff ......................................................................
Patch Set 1:
(2 comments)
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37651/1/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/puff/variant.c:
https://review.coreboot.org/c/coreboot/+/37651/1/src/mainboard/google/hatch/... PS1, Line 66: pl4 = 0;
Seems like you could invert the if stmt and avoid a else branch then have the sane safe defaults set […]
lets not block on this.
https://review.coreboot.org/c/coreboot/+/37651/1/src/mainboard/google/hatch/... PS1, Line 89: config_t *conf = config_of_soc();
Is it identical? I thought about it but I couldn't be sure, so used config_of_soc().
It should be the root 0,0. I don't mind this change being a follow up.
-
Edward O'Callaghan (Code Review)