build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22693 )
Change subject: [WIP] new board: Dell Latitude E6230 ......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/#/c/22693/4/src/mainboard/dell/latitude_e6230/ec... File src/mainboard/dell/latitude_e6230/ec.c:
https://review.coreboot.org/#/c/22693/4/src/mainboard/dell/latitude_e6230/ec... PS4, Line 89: static int write_send(u8 *sdata, u8 c, unsigned count) Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/#/c/22693/4/src/mainboard/dell/latitude_e6230/ro... File src/mainboard/dell/latitude_e6230/romstage.c:
https://review.coreboot.org/#/c/22693/4/src/mainboard/dell/latitude_e6230/ro... PS4, Line 25: pci_write_config16(PCH_LPC_DEV, LPC_EN, CNF1_LPC_EN | MC_LPC_EN | KBC_LPC_EN); line over 80 characters