Change in coreboot[master]: soc/amd/picasso: Disable inclusion of S0i3 firmware by default
Furquan Shaikh has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/40681 )
Change subject: soc/amd/picasso: Disable inclusion of S0i3 firmware by default ......................................................................
soc/amd/picasso: Disable inclusion of S0i3 firmware by default
Enabling of S0i3 is a mainboard decision. This change sets the option to include S0i3 firmware by default to 'n'.
BUG=b:154880818
Signed-off-by: Furquan Shaikh furquan@google.com Change-Id: I5d533e317535b01efe9dd32272483296bf4fafab --- M src/soc/amd/picasso/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/81/40681/1
diff --git a/src/soc/amd/picasso/Kconfig b/src/soc/amd/picasso/Kconfig index b58ba88..e26d189 100644 --- a/src/soc/amd/picasso/Kconfig +++ b/src/soc/amd/picasso/Kconfig @@ -332,6 +332,7 @@
config PSP_LOAD_S0I3_FW bool "Include S0I3 blob in PSP build" + default n help Select this item to include the S0i3 file into the PSP build.
Furquan Shaikh has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/40681 )
Change subject: soc/amd/picasso: Disable inclusion of S0i3 firmware by default ......................................................................
soc/amd/picasso: Disable inclusion of S0i3 firmware by default
Enabling of S0i3 is a mainboard decision. This change sets the option to include S0i3 firmware by default to 'n'.
BUG=b:154880818
Signed-off-by: Furquan Shaikh furquan@google.com Change-Id: I5d533e317535b01efe9dd32272483296bf4fafab --- M src/soc/amd/picasso/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/81/40681/2
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40681 )
Change subject: soc/amd/picasso: Disable inclusion of S0i3 firmware by default ......................................................................
Patch Set 2: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/40681/2/src/soc/amd/picasso/Kconfig File src/soc/amd/picasso/Kconfig:
https://review.coreboot.org/c/coreboot/+/40681/2/src/soc/amd/picasso/Kconfig... PS2, Line 334: S0I3 nit: S0i3
Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40681 )
Change subject: soc/amd/picasso: Disable inclusion of S0i3 firmware by default ......................................................................
Patch Set 2: Code-Review+2
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40681 )
Change subject: soc/amd/picasso: Disable inclusion of S0i3 firmware by default ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40681/2/src/soc/amd/picasso/Kconfig File src/soc/amd/picasso/Kconfig:
https://review.coreboot.org/c/coreboot/+/40681/2/src/soc/amd/picasso/Kconfig... PS2, Line 334: S0I3
nit: S0i3
I will be dropping this in a follow-up CL, so keeping untouched for now.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40681 )
Change subject: soc/amd/picasso: Disable inclusion of S0i3 firmware by default ......................................................................
Patch Set 3: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/40681/2/src/soc/amd/picasso/Kconfig File src/soc/amd/picasso/Kconfig:
https://review.coreboot.org/c/coreboot/+/40681/2/src/soc/amd/picasso/Kconfig... PS2, Line 334: S0I3
I will be dropping this in a follow-up CL, so keeping untouched for now.
Ack
Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40681 )
Change subject: soc/amd/picasso: Disable inclusion of S0i3 firmware by default ......................................................................
Patch Set 3: Code-Review+2
Furquan Shaikh has submitted this change. ( https://review.coreboot.org/c/coreboot/+/40681 )
Change subject: soc/amd/picasso: Disable inclusion of S0i3 firmware by default ......................................................................
soc/amd/picasso: Disable inclusion of S0i3 firmware by default
Enabling of S0i3 is a mainboard decision. This change sets the option to include S0i3 firmware by default to 'n'.
BUG=b:154880818
Signed-off-by: Furquan Shaikh furquan@google.com Change-Id: I5d533e317535b01efe9dd32272483296bf4fafab Reviewed-on: https://review.coreboot.org/c/coreboot/+/40681 Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Marshall Dawson marshalldawson3rd@gmail.com Reviewed-by: Aaron Durbin adurbin@chromium.org Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/soc/amd/picasso/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Aaron Durbin: Looks good to me, approved Marshall Dawson: Looks good to me, approved Angel Pons: Looks good to me, approved
diff --git a/src/soc/amd/picasso/Kconfig b/src/soc/amd/picasso/Kconfig index c9f45f1..384e8a8 100644 --- a/src/soc/amd/picasso/Kconfig +++ b/src/soc/amd/picasso/Kconfig @@ -338,6 +338,7 @@
config PSP_LOAD_S0I3_FW bool "Include S0I3 blob in PSP build" + default n help Select this item to include the S0i3 file into the PSP build.
-
Aaron Durbin (Code Review) -
Angel Pons (Code Review)
-
Furquan Shaikh (Code Review)
-
Marshall Dawson (Code Review)