Attention is currently required from: Furquan Shaikh, Maulik V Vaghela, Tim Wawrzynczak, Patrick Rudolph.
Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55015 )
Change subject: soc/intel/alderlake: Set Base Addresses for TBT DMA remapping engines
......................................................................
Patch Set 4:
(2 comments)
File src/soc/intel/alderlake/romstage/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/55015/comment/03ea2c61_fd6d08b0
PS3, Line 35: };
Instead of using raw indexes into `VtdBaseAddress` below, can we add more values here?
Done
https://review.coreboot.org/c/coreboot/+/55015/comment/414aab3d_c397bb70
PS3, Line 235: 3
with above comment, something like VTD_TBT0, etc.
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/55015
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I669255065d60d73c4bea0eeb732c4114bcc447c0
Gerrit-Change-Number: 55015
Gerrit-PatchSet: 4
Gerrit-Owner: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Fri, 04 Jun 2021 16:57:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment