[M] Change in coreboot[master]: drivers/smbus: SC16IS750 I2C to UART converter chip initialization

[Raul Rangel (Code Review)]

Attention is currently required from: Felix Singer, Ahamed Husni, Tim Wawrzynczak.

Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67342 )

Change subject: drivers/smbus: SC16IS750 I2C to UART converter chip initialization
......................................................................

Patch Set 5:

(9 comments)

File src/console/Kconfig:

https://review.coreboot.org/c/coreboot/+/67342/comment/0481184a_f48cf7de 
PS5, Line 314: default 0x48
Maybe change this to `default 0x48 if SC16IS750_INIT`. Same for the data register

https://review.coreboot.org/c/coreboot/+/67342/comment/f9cca4a1_13a75430 
PS5, Line 328: 	default n
`bool` defaults to `n`, so you can remove this.

https://review.coreboot.org/c/coreboot/+/67342/comment/a65ac291_7bdb50c1 
PS5, Line 329: 	depends on CONSOLE_I2C_SMBUS
No need for depends if inside the `if` block.

File src/drivers/smbus/Makefile.inc:

https://review.coreboot.org/c/coreboot/+/67342/comment/6ced8d21_6a040c7e 
PS5, Line 3: romstage
Do we need to re-init the device?

File src/drivers/smbus/sc16is750_init.h:

https://review.coreboot.org/c/coreboot/+/67342/comment/bb7f0ae5_23f9fe0f 
PS5, Line 3: I2C_TO_UART_H
__DRIVERS_SMBUS_SC16IS750_INIT___

File src/drivers/smbus/sc16is750_init.c:

https://review.coreboot.org/c/coreboot/+/67342/comment/d5d95630_70095652 
PS5, Line 12: 	
nit, use spaces

https://review.coreboot.org/c/coreboot/+/67342/comment/94491ded_944aae5b 
PS5, Line 20: 3
Can we #define this value?

https://review.coreboot.org/c/coreboot/+/67342/comment/9e358718_4dee37ff 
PS5, Line 20: 0x83
Can we #define all the bits?

https://review.coreboot.org/c/coreboot/+/67342/comment/b12b927e_c63e11c4 
PS5, Line 22: 0x08
Same here.