Attention is currently required from: Dinesh Gehlot, Intel coreboot Reviewers, Jayvik Desai, Jérémy Compostella, Kapil Porwal, Karthik Ramasubramanian, Nick Vaccaro.
Hello Dinesh Gehlot, Intel coreboot Reviewers, Jayvik Desai, Kapil Porwal, Nick Vaccaro, Subrata Banik, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/86111?usp=email
to look at the new patch set (#3).
Change subject: Revert "soc/intel/alderlake: Disable UFS controllers only on S5 resume" ......................................................................
Revert "soc/intel/alderlake: Disable UFS controllers only on S5 resume"
This reverts commit 5e580c79dfd43387e6d375c94c6d95c520189111. On boards with non-UFS storage, currently UFS controller is disabled only when the system is coming out of S5 sleep state. On certain kind of resets during boot flow, this leaves some UFS resources turned on and causing the suspend failure. To fix this issue, disable UFS controller on every boot cycle.
BUG=b:391449110 TEST=Build Brox BIOS image and boot to OS. Ensure that when the device switches from normal mode to developer mode and vice-versa, the device is able to suspend/resume successfully.
Change-Id: I1d7089a90bc42a2b36c26b05b81c1a2f12861fdc Signed-off-by: Karthikeyan Ramasubramanian kramasub@google.com --- M src/soc/intel/alderlake/romstage/romstage.c 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/11/86111/3