EricR Lai has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/35114 )
Change subject: mb/google/drallion: remove GBE file ......................................................................
mb/google/drallion: remove GBE file
Drallion doesn't have on board LAN, remove GBE bin file config.
BUG=b:139906731 TEST=emerge-drallion coreboot chromeos-bootimage and check image-drallion.bin not include GBE region
Signed-off-by: Eric Lai ericr_lai@compal.corp-partner.google.com Change-Id: Ifbc295afd8d875b5098b0ce75252b51523a5c76e --- M src/mainboard/google/drallion/Kconfig 1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/35114/1
diff --git a/src/mainboard/google/drallion/Kconfig b/src/mainboard/google/drallion/Kconfig index 2484ce7..ffadd0c 100644 --- a/src/mainboard/google/drallion/Kconfig +++ b/src/mainboard/google/drallion/Kconfig @@ -21,7 +21,6 @@ select SYSTEM_TYPE_LAPTOP select TPM2 select MAINBOARD_USES_IFD_EC_REGION - select MAINBOARD_USES_IFD_GBE_REGION select USE_SAR select SAR_ENABLE
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35114 )
Change subject: mb/google/drallion: remove GBE file ......................................................................
Patch Set 1: Code-Review+1
Mathew King has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35114 )
Change subject: mb/google/drallion: remove GBE file ......................................................................
Patch Set 1: Code-Review+2
Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/35114 )
Change subject: mb/google/drallion: remove GBE file ......................................................................
mb/google/drallion: remove GBE file
Drallion doesn't have on board LAN, remove GBE bin file config.
BUG=b:139906731 TEST=emerge-drallion coreboot chromeos-bootimage and check image-drallion.bin not include GBE region
Signed-off-by: Eric Lai ericr_lai@compal.corp-partner.google.com Change-Id: Ifbc295afd8d875b5098b0ce75252b51523a5c76e Reviewed-on: https://review.coreboot.org/c/coreboot/+/35114 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Reviewed-by: Mathew King mathewk@chromium.org --- M src/mainboard/google/drallion/Kconfig 1 file changed, 0 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Mathew King: Looks good to me, approved
diff --git a/src/mainboard/google/drallion/Kconfig b/src/mainboard/google/drallion/Kconfig index 2484ce7..ffadd0c 100644 --- a/src/mainboard/google/drallion/Kconfig +++ b/src/mainboard/google/drallion/Kconfig @@ -21,7 +21,6 @@ select SYSTEM_TYPE_LAPTOP select TPM2 select MAINBOARD_USES_IFD_EC_REGION - select MAINBOARD_USES_IFD_GBE_REGION select USE_SAR select SAR_ENABLE
-
EricR Lai (Code Review) -
Mathew King (Code Review)
-
Patrick Georgi (Code Review)
-
Paul Menzel (Code Review)