Change in coreboot[master]: mb/lenovo/x200: Add support for ThinkLight

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Stefan Ott (Code Review)

22 Apr 2020 22 Apr '20

3:33 p.m.

Stefan Ott has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/40620 )

Change subject: mb/lenovo/x200: Add support for ThinkLight ......................................................................

mb/lenovo/x200: Add support for ThinkLight

With this patch, the ThinkLight on the X200 can be controlled through the OS. The exact same change was done a while ago to the X201 in https://review.coreboot.org/c/coreboot/+/19644.

After applying this patch, the light can be controlled like this:

echo on >/proc/acpi/ibm/light echo off >/proc/acpi/ibm/light

I have tested it on an X200 and it seems to work fine.

Change-Id: I14752ab33484122248959517e73f96b6783b1f65 Signed-off-by: Stefan Ott stefan@ott.net --- M src/mainboard/lenovo/x200/acpi/platform.asl 1 file changed, 15 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/40620/1

diff --git a/src/mainboard/lenovo/x200/acpi/platform.asl b/src/mainboard/lenovo/x200/acpi/platform.asl index 2247461..4047a48 100644 --- a/src/mainboard/lenovo/x200/acpi/platform.asl +++ b/src/mainboard/lenovo/x200/acpi/platform.asl @@ -44,6 +44,21 @@ Return(Package(){0,0}) }

+Method(UCMS, 1, Serialized) +{ + Switch(ToInteger(Arg0)) + { + Case (0x0c) /* Turn on ThinkLight */ + { + _SB.PCI0.LPCB.EC.LGHT(1) + } + Case (0x0d) /* Turn off ThinkLight */ + { + _SB.PCI0.LPCB.EC.LGHT(0) + } + } +} + /* System Bus */

Scope(_SB)

Attachments:

attachment.htm (text/html — 3.5 KB)

Show replies by date

Alexander Couzens (Code Review)

22 Apr 22 Apr

5:23 p.m.

Alexander Couzens has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40620 )

Change subject: mb/lenovo/x200: Add support for ThinkLight ......................................................................

Patch Set 1: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/40620 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I14752ab33484122248959517e73f96b6783b1f65 Gerrit-Change-Number: 40620 Gerrit-PatchSet: 1 Gerrit-Owner: Stefan Ott coreboot@desire.ch Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Wed, 22 Apr 2020 23:23:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Paul Menzel (Code Review)

23 Apr 23 Apr

2:17 a.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40620 )

Change subject: mb/lenovo/x200: Add support for ThinkLight ......................................................................

Patch Set 1: Code-Review+1

(4 comments)

https://review.coreboot.org/c/coreboot/+/40620/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/40620/1//COMMIT_MSG@11 PS1, Line 11: https://review.coreboot.org/c/coreboot/+/19644. Please use the commit hash and summary.

https://review.coreboot.org/c/coreboot/+/40620/1//COMMIT_MSG@16 PS1, Line 16: echo off >/proc/acpi/ibm/light Please indent with four spaces (as in Markdown).

https://review.coreboot.org/c/coreboot/+/40620/1//COMMIT_MSG@18 PS1, Line 18: I have tested it on an X200 and it seems to work fine. With what Linux kernel?

https://review.coreboot.org/c/coreboot/+/40620/1/src/mainboard/lenovo/x200/a... File src/mainboard/lenovo/x200/acpi/platform.asl:

https://review.coreboot.org/c/coreboot/+/40620/1/src/mainboard/lenovo/x200/a... PS1, Line 60: } I guess some refactoring in common/shared code with all the Lenovo ThinkPads would be nice.

-- To view, visit https://review.coreboot.org/c/coreboot/+/40620 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I14752ab33484122248959517e73f96b6783b1f65 Gerrit-Change-Number: 40620 Gerrit-PatchSet: 1 Gerrit-Owner: Stefan Ott coreboot@desire.ch Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Thu, 23 Apr 2020 08:17:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Angel Pons (Code Review)

2:34 a.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40620 )

Change subject: mb/lenovo/x200: Add support for ThinkLight ......................................................................

Patch Set 1: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/40620 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I14752ab33484122248959517e73f96b6783b1f65 Gerrit-Change-Number: 40620 Gerrit-PatchSet: 1 Gerrit-Owner: Stefan Ott coreboot@desire.ch Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Thu, 23 Apr 2020 08:34:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Stefan Ott (Code Review)

3:45 a.m.

Hello build bot (Jenkins), Paul Menzel, Angel Pons, Alexander Couzens, Patrick Rudolph,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/40620

to look at the new patch set (#2).

Change subject: mb/lenovo/x200: Add support for ThinkLight ......................................................................

mb/lenovo/x200: Add support for ThinkLight

With this patch, the ThinkLight on the X200 can be controlled through the OS. The exact same change was done a while ago to the X201 in f63fbdb6: mb/lenovo/x201: Add support for ThinkLight

After applying this patch, the light can be controlled like this:

echo on >/proc/acpi/ibm/light echo off >/proc/acpi/ibm/light

I have tested it on an X200 with Kernel 5.4 and it seems to work fine.

Change-Id: I14752ab33484122248959517e73f96b6783b1f65 Signed-off-by: Stefan Ott stefan@ott.net --- M src/mainboard/lenovo/x200/acpi/platform.asl 1 file changed, 15 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/40620/2

-- To view, visit https://review.coreboot.org/c/coreboot/+/40620 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I14752ab33484122248959517e73f96b6783b1f65 Gerrit-Change-Number: 40620 Gerrit-PatchSet: 2 Gerrit-Owner: Stefan Ott coreboot@desire.ch Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Stefan Ott (Code Review)

4:08 a.m.

Stefan Ott has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40620 )

Change subject: mb/lenovo/x200: Add support for ThinkLight ......................................................................

Patch Set 2:

(1 comment)

...

Patch Set 1: Code-Review+1

(4 comments)

https://review.coreboot.org/c/coreboot/+/40620/1/src/mainboard/lenovo/x200/a... File src/mainboard/lenovo/x200/acpi/platform.asl:

https://review.coreboot.org/c/coreboot/+/40620/1/src/mainboard/lenovo/x200/a... PS1, Line 60: }

...

I guess some refactoring in common/shared code with all the Lenovo ThinkPads would be nice.

I think I could move it to ec/lenovo/h8/acpi/ec.asl instead, that way all the ThinkPads would benefit, but I can't really test it on any non-X20x models.

-- To view, visit https://review.coreboot.org/c/coreboot/+/40620 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I14752ab33484122248959517e73f96b6783b1f65 Gerrit-Change-Number: 40620 Gerrit-PatchSet: 2 Gerrit-Owner: Stefan Ott coreboot@desire.ch Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Thu, 23 Apr 2020 10:08:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: comment

Stefan Ott (Code Review)

6:50 a.m.

New subject: Change in coreboot[master]: mb/lenovo/*: Add support for ThinkLight

Hello build bot (Jenkins), Paul Menzel, Angel Pons, Alexander Couzens, Patrick Rudolph,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/40620

to look at the new patch set (#3).

Change subject: mb/lenovo/*: Add support for ThinkLight ......................................................................

mb/lenovo/*: Add support for ThinkLight

With this patch, the ThinkLight LED on all ThinkPads (that have one) can be controlled through the OS. This was initially done for the X201 in f63fbdb6: mb/lenovo/x201: Add support for ThinkLight.

After applying this patch, the light can be controlled like this:

echo on >/proc/acpi/ibm/light echo off >/proc/acpi/ibm/light

Or through sysfs at /sys/class/leds/tpacpi::thinklight

I have tested it on an X200 with Kernel 5.4 and an X201 with Kernel 4.9. It seems to work fine on both machines.

Change-Id: I14752ab33484122248959517e73f96b6783b1f65 Signed-off-by: Stefan Ott stefan@ott.net --- A src/ec/lenovo/h8/acpi/light.asl M src/mainboard/lenovo/t400/dsdt.asl M src/mainboard/lenovo/t410/acpi/platform.asl M src/mainboard/lenovo/t410/dsdt.asl M src/mainboard/lenovo/t420/dsdt.asl M src/mainboard/lenovo/t420s/dsdt.asl M src/mainboard/lenovo/t430/dsdt.asl M src/mainboard/lenovo/t430s/dsdt.asl M src/mainboard/lenovo/t520/dsdt.asl M src/mainboard/lenovo/t530/dsdt.asl M src/mainboard/lenovo/t60/dsdt.asl M src/mainboard/lenovo/x200/dsdt.asl M src/mainboard/lenovo/x201/acpi/platform.asl M src/mainboard/lenovo/x201/dsdt.asl M src/mainboard/lenovo/x220/dsdt.asl M src/mainboard/lenovo/x230/dsdt.asl 16 files changed, 56 insertions(+), 30 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/40620/3

-- To view, visit https://review.coreboot.org/c/coreboot/+/40620 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I14752ab33484122248959517e73f96b6783b1f65 Gerrit-Change-Number: 40620 Gerrit-PatchSet: 3 Gerrit-Owner: Stefan Ott coreboot@desire.ch Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Stefan Ott (Code Review)

7:05 a.m.

New subject: Change in coreboot[master]: mb/lenovo/*: Add support for ThinkLight

Stefan Ott has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40620 )

Change subject: mb/lenovo/*: Add support for ThinkLight ......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/40620/1/src/mainboard/lenovo/x200/a... File src/mainboard/lenovo/x200/acpi/platform.asl:

https://review.coreboot.org/c/coreboot/+/40620/1/src/mainboard/lenovo/x200/a... PS1, Line 60: }

...

That should work. Testers could be found on the list.

I updated the patch, it should now work on all ThinkPads.

-- To view, visit https://review.coreboot.org/c/coreboot/+/40620 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I14752ab33484122248959517e73f96b6783b1f65 Gerrit-Change-Number: 40620 Gerrit-PatchSet: 3 Gerrit-Owner: Stefan Ott coreboot@desire.ch Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Thu, 23 Apr 2020 13:05:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Stefan Ott coreboot@desire.ch Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: comment

Stefan Ott (Code Review)

7:59 a.m.

New subject: Change in coreboot[master]: mb/lenovo/*: Add support for ThinkLight

Stefan Ott has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40620 )

Change subject: mb/lenovo/*: Add support for ThinkLight ......................................................................

Patch Set 3:

(3 comments)

https://review.coreboot.org/c/coreboot/+/40620/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/40620/1//COMMIT_MSG@11 PS1, Line 11: https://review.coreboot.org/c/coreboot/+/19644.

...

Please use the commit hash and summary.

Done

https://review.coreboot.org/c/coreboot/+/40620/1//COMMIT_MSG@16 PS1, Line 16: echo off >/proc/acpi/ibm/light

...

Please indent with four spaces (as in Markdown).

Done

https://review.coreboot.org/c/coreboot/+/40620/1//COMMIT_MSG@18 PS1, Line 18: I have tested it on an X200 and it seems to work fine.

...

With what Linux kernel?

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/40620 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I14752ab33484122248959517e73f96b6783b1f65 Gerrit-Change-Number: 40620 Gerrit-PatchSet: 3 Gerrit-Owner: Stefan Ott coreboot@desire.ch Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Thu, 23 Apr 2020 13:59:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: comment

Michael Niewöhner (Code Review)

8:21 a.m.

New subject: Change in coreboot[master]: mb/lenovo/*: Add support for ThinkLight

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40620 )

Change subject: mb/lenovo/*: Add support for ThinkLight ......................................................................

Patch Set 3:

ThinkLight is that light in the display frame, replaced by the keyboard LED light on newer ThinkPads, right? Does that make any difference?

Are there ThinkPads without ThinkLight? Then we could add a Kconfig for that

-- To view, visit https://review.coreboot.org/c/coreboot/+/40620 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I14752ab33484122248959517e73f96b6783b1f65 Gerrit-Change-Number: 40620 Gerrit-PatchSet: 3 Gerrit-Owner: Stefan Ott coreboot@desire.ch Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Michael Niewöhner Gerrit-Comment-Date: Thu, 23 Apr 2020 14:21:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Michael Niewöhner (Code Review)

8:22 a.m.

New subject: Change in coreboot[master]: mb/lenovo/*: Add support for ThinkLight

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40620 )

Change subject: mb/lenovo/*: Add support for ThinkLight ......................................................................

Patch Set 3: Code-Review+1

-- To view, visit https://review.coreboot.org/c/coreboot/+/40620 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I14752ab33484122248959517e73f96b6783b1f65 Gerrit-Change-Number: 40620 Gerrit-PatchSet: 3 Gerrit-Owner: Stefan Ott coreboot@desire.ch Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Michael Niewöhner Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Thu, 23 Apr 2020 14:22:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Stefan Ott (Code Review)

8:25 a.m.

New subject: Change in coreboot[master]: mb/lenovo/*: Add support for ThinkLight

Stefan Ott has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40620 )

Change subject: mb/lenovo/*: Add support for ThinkLight ......................................................................

Patch Set 3:

...

Patch Set 3:

ThinkLight is that light in the display frame, replaced by the keyboard LED light on newer ThinkPads, right? Does that make any difference?

Are there ThinkPads without ThinkLight? Then we could add a Kconfig for that

Yes, that's the light in the display frame. I don't know about newer ThinkPads, but it's possible that they don't have it anymore.

Anyway, I will be reorganizing this change a split it into various small changes for the different models.

-- To view, visit https://review.coreboot.org/c/coreboot/+/40620 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I14752ab33484122248959517e73f96b6783b1f65 Gerrit-Change-Number: 40620 Gerrit-PatchSet: 3 Gerrit-Owner: Stefan Ott coreboot@desire.ch Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Michael Niewöhner Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Thu, 23 Apr 2020 14:25:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Stefan Ott (Code Review)

8:25 a.m.

Hello build bot (Jenkins), Paul Menzel, Angel Pons, Michael Niewöhner, Alexander Couzens, Patrick Rudolph,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/40620

to look at the new patch set (#4).

Change subject: mb/lenovo/x200: Add support for ThinkLight ......................................................................

mb/lenovo/x200: Add support for ThinkLight

With this patch, the ThinkLight on the ThinkPad X200 can be controlled through the OS. This was initially done for the X201 in f63fbdb6: mb/lenovo/x201: Add support for ThinkLight.

After applying this patch, the light can be controlled like this:

echo on >/proc/acpi/ibm/light echo off >/proc/acpi/ibm/light

Or through sysfs at /sys/class/leds/tpacpi::thinklight

I have tested it on an X200 with Kernel 5.4 and it seems to work fine.

Change-Id: I14752ab33484122248959517e73f96b6783b1f65 Signed-off-by: Stefan Ott stefan@ott.net --- M src/mainboard/lenovo/x200/dsdt.asl 1 file changed, 3 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/40620/4

-- To view, visit https://review.coreboot.org/c/coreboot/+/40620 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I14752ab33484122248959517e73f96b6783b1f65 Gerrit-Change-Number: 40620 Gerrit-PatchSet: 4 Gerrit-Owner: Stefan Ott coreboot@desire.ch Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Michael Niewöhner Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Stefan Ott (Code Review)

8:27 a.m.

Hello build bot (Jenkins), Paul Menzel, Angel Pons, Michael Niewöhner, Alexander Couzens, Patrick Rudolph,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/40620

to look at the new patch set (#5).

Change subject: mb/lenovo/x200: Add support for ThinkLight ......................................................................

mb/lenovo/x200: Add support for ThinkLight

With this patch, the ThinkLight on the ThinkPad X200 can be controlled through the OS. This was initially done for the X201 in f63fbdb6: mb/lenovo/x201: Add support for ThinkLight.

After applying this patch, the light can be controlled like this:

echo on >/proc/acpi/ibm/light echo off >/proc/acpi/ibm/light

Or through sysfs at /sys/class/leds/tpacpi::thinklight

I have tested it on an X200 with Kernel 5.4 and it seems to work fine.

Change-Id: I14752ab33484122248959517e73f96b6783b1f65 Signed-off-by: Stefan Ott stefan@ott.net --- M src/mainboard/lenovo/x200/dsdt.asl 1 file changed, 3 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/40620/5

-- To view, visit https://review.coreboot.org/c/coreboot/+/40620 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I14752ab33484122248959517e73f96b6783b1f65 Gerrit-Change-Number: 40620 Gerrit-PatchSet: 5 Gerrit-Owner: Stefan Ott coreboot@desire.ch Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Michael Niewöhner Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Stefan Ott (Code Review)

8:53 a.m.

Hello build bot (Jenkins), Paul Menzel, Angel Pons, Michael Niewöhner, Alexander Couzens, Patrick Rudolph,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/40620

to look at the new patch set (#7).

Change subject: mb/lenovo/x200: Add support for ThinkLight ......................................................................

mb/lenovo/x200: Add support for ThinkLight

With this patch, the ThinkLight on the ThinkPad X200 can be controlled through the OS. This was initially done for the X201 in f63fbdb6: mb/lenovo/x201: Add support for ThinkLight.

After applying this patch, the light can be controlled like this:

echo on >/proc/acpi/ibm/light echo off >/proc/acpi/ibm/light

Or through sysfs at /sys/class/leds/tpacpi::thinklight

I have tested it on an X200 with Kernel 5.4 and it seems to work fine.

Change-Id: I14752ab33484122248959517e73f96b6783b1f65 Signed-off-by: Stefan Ott stefan@ott.net --- M src/mainboard/lenovo/x200/dsdt.asl 1 file changed, 3 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/40620/7

-- To view, visit https://review.coreboot.org/c/coreboot/+/40620 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I14752ab33484122248959517e73f96b6783b1f65 Gerrit-Change-Number: 40620 Gerrit-PatchSet: 7 Gerrit-Owner: Stefan Ott coreboot@desire.ch Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Michael Niewöhner Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Stefan Ott (Code Review)

8:54 a.m.

Hello build bot (Jenkins), Paul Menzel, Angel Pons, Michael Niewöhner, Alexander Couzens, Patrick Rudolph,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/40620

to look at the new patch set (#8).

Change subject: mb/lenovo/x200: Add support for ThinkLight ......................................................................

mb/lenovo/x200: Add support for ThinkLight

With this patch, the ThinkLight on the ThinkPad X200 can be controlled through the OS. This was initially done for the X201 in f63fbdb6: mb/lenovo/x201: Add support for ThinkLight.

After applying this patch, the light can be controlled like this:

echo on >/proc/acpi/ibm/light echo off >/proc/acpi/ibm/light

Or through sysfs at /sys/class/leds/tpacpi::thinklight

I have tested it on an X200 with Kernel 5.4 and it seems to work fine.

Change-Id: I14752ab33484122248959517e73f96b6783b1f65 Signed-off-by: Stefan Ott stefan@ott.net --- M src/mainboard/lenovo/x200/dsdt.asl 1 file changed, 2 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/40620/8

-- To view, visit https://review.coreboot.org/c/coreboot/+/40620 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I14752ab33484122248959517e73f96b6783b1f65 Gerrit-Change-Number: 40620 Gerrit-PatchSet: 8 Gerrit-Owner: Stefan Ott coreboot@desire.ch Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Michael Niewöhner Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Michael Niewöhner (Code Review)

11:31 a.m.

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40620 )

Change subject: mb/lenovo/x200: Add support for ThinkLight ......................................................................

Patch Set 8:

...

Patch Set 3:

...
Patch Set 3:

ThinkLight is that light in the display frame, replaced by the keyboard LED light on newer ThinkPads, right? Does that make any difference?

Are there ThinkPads without ThinkLight? Then we could add a Kconfig for that

Yes, that's the light in the display frame. I don't know about newer ThinkPads, but it's possible that they don't have it anymore.

Anyway, I will be reorganizing this change a split it into various small changes for the different models.

I checked now on my x260. /proc/acpi/ibm/light does nothing, while /proc/acpi/ibm/kbdlight is the keyboard background light.

-- To view, visit https://review.coreboot.org/c/coreboot/+/40620 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I14752ab33484122248959517e73f96b6783b1f65 Gerrit-Change-Number: 40620 Gerrit-PatchSet: 8 Gerrit-Owner: Stefan Ott coreboot@desire.ch Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Michael Niewöhner Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Thu, 23 Apr 2020 17:31:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Stefan Ott (Code Review)

11:35 a.m.

Stefan Ott has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40620 )

Change subject: mb/lenovo/x200: Add support for ThinkLight ......................................................................

Patch Set 8:

...

Patch Set 8:

...
Patch Set 3:

...
Patch Set 3:

ThinkLight is that light in the display frame, replaced by the keyboard LED light on newer ThinkPads, right? Does that make any difference?

Are there ThinkPads without ThinkLight? Then we could add a Kconfig for that

Yes, that's the light in the display frame. I don't know about newer ThinkPads, but it's possible that they don't have it anymore.

Anyway, I will be reorganizing this change a split it into various small changes for the different models.

I checked now on my x260. /proc/acpi/ibm/light does nothing, while /proc/acpi/ibm/kbdlight is the keyboard background light.

Thank you. That would be consistent with https://www.thinkwiki.org/wiki/ThinkLight which doesn't list the X260.

-- To view, visit https://review.coreboot.org/c/coreboot/+/40620 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I14752ab33484122248959517e73f96b6783b1f65 Gerrit-Change-Number: 40620 Gerrit-PatchSet: 8 Gerrit-Owner: Stefan Ott coreboot@desire.ch Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Michael Niewöhner Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Thu, 23 Apr 2020 17:35:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Angel Pons (Code Review)

12:51 p.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40620 )

Change subject: mb/lenovo/x200: Add support for ThinkLight ......................................................................

Patch Set 8: Code-Review+1

Waiting for preceding patch

-- To view, visit https://review.coreboot.org/c/coreboot/+/40620 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I14752ab33484122248959517e73f96b6783b1f65 Gerrit-Change-Number: 40620 Gerrit-PatchSet: 8 Gerrit-Owner: Stefan Ott coreboot@desire.ch Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Michael Niewöhner Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Thu, 23 Apr 2020 18:51:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Angel Pons (Code Review)

3:51 p.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40620 )

Change subject: mb/lenovo/x200: Add support for ThinkLight ......................................................................

Patch Set 8: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/40620 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I14752ab33484122248959517e73f96b6783b1f65 Gerrit-Change-Number: 40620 Gerrit-PatchSet: 8 Gerrit-Owner: Stefan Ott coreboot@desire.ch Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Michael Niewöhner Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Thu, 23 Apr 2020 21:51:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Angel Pons (Code Review)

25 Apr 25 Apr

9:28 a.m.

Angel Pons has submitted this change. ( https://review.coreboot.org/c/coreboot/+/40620 )

Change subject: mb/lenovo/x200: Add support for ThinkLight ......................................................................

mb/lenovo/x200: Add support for ThinkLight

With this patch, the ThinkLight on the ThinkPad X200 can be controlled through the OS. This was initially done for the X201 in f63fbdb6: mb/lenovo/x201: Add support for ThinkLight.

After applying this patch, the light can be controlled like this:

echo on >/proc/acpi/ibm/light echo off >/proc/acpi/ibm/light

Or through sysfs at /sys/class/leds/tpacpi::thinklight

I have tested it on an X200 with Kernel 5.4 and it seems to work fine.

Change-Id: I14752ab33484122248959517e73f96b6783b1f65 Signed-off-by: Stefan Ott stefan@ott.net Reviewed-on: https://review.coreboot.org/c/coreboot/+/40620 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com --- M src/mainboard/lenovo/x200/dsdt.asl 1 file changed, 2 insertions(+), 0 deletions(-)

Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved

diff --git a/src/mainboard/lenovo/x200/dsdt.asl b/src/mainboard/lenovo/x200/dsdt.asl index 1357a3a..abe1c27 100644 --- a/src/mainboard/lenovo/x200/dsdt.asl +++ b/src/mainboard/lenovo/x200/dsdt.asl @@ -41,4 +41,6 @@

/* Dock support code */ #include "acpi/dock.asl" + + #include <ec/lenovo/h8/acpi/thinklight.asl> }

-- To view, visit https://review.coreboot.org/c/coreboot/+/40620 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I14752ab33484122248959517e73f96b6783b1f65 Gerrit-Change-Number: 40620 Gerrit-PatchSet: 9 Gerrit-Owner: Stefan Ott coreboot@desire.ch Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Michael Niewöhner Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: merged

9elements QA (Code Review)

9:47 a.m.

9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40620 )

Change subject: mb/lenovo/x200: Add support for ThinkLight ......................................................................

Patch Set 9:

Automatic boot test returned (PASS/FAIL/TOTAL): 4/0/4 Emulation targets: "QEMU x86 q35/ich9" using payload TianoCore : SUCCESS : https://lava.9esec.io/r/2663 "QEMU x86 q35/ich9" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/2662 "QEMU x86 i440fx/piix4" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/2661 "QEMU AArch64" using payload LinuxBoot_u-root_kexec : SUCCESS : https://lava.9esec.io/r/2660

Please note: This test is under development and might not be accurate at all!

-- To view, visit https://review.coreboot.org/c/coreboot/+/40620 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I14752ab33484122248959517e73f96b6783b1f65 Gerrit-Change-Number: 40620 Gerrit-PatchSet: 9 Gerrit-Owner: Stefan Ott coreboot@desire.ch Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Michael Niewöhner Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: 9elements QA hardwaretestrobot@gmail.com Gerrit-Comment-Date: Sat, 25 Apr 2020 15:47:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1842

days inactive

1845

days old

coreboot-gerrit@coreboot.org

21 comments

6 participants

tags (0)

participants (6)

9elements QA (Code Review)
Alexander Couzens (Code Review)
Angel Pons (Code Review)
Michael Niewöhner (Code Review)
Paul Menzel (Code Review)
Stefan Ott (Code Review)