Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36527 )
Change subject: timestamps: COLLECT_TIMESTAMPS is always optional
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36527/3/src/mainboard/intel/galileo...
File src/mainboard/intel/galileo/Kconfig:
https://review.coreboot.org/c/coreboot/+/36527/3/src/mainboard/intel/galileo...
PS3, Line 109: select COLLECT_TIMESTAMPS
What happens when someone decides to change the default to 'n' for COLLECT_TIMESTAMPS going by the s […]
I'm not sure what the dependency is for CYRPTO_SHIELD necessarily. But I think i'm ok given my last comment to Marshall about Chrome OS.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36527
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6ee4195d266440143344781d39db9578cd8bdcb3
Gerrit-Change-Number: 36527
Gerrit-PatchSet: 3
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Comment-Date: Fri, 01 Nov 2019 17:51:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Aaron Durbin
adurbin@chromium.org
Gerrit-MessageType: comment