Marshall Dawson has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37720 )
Change subject: drivers/mrc_cache: Redo indenting ......................................................................
drivers/mrc_cache: Redo indenting
Indent continuation lines of an if test farther than its "true" expression to be executed.
Change-Id: I3dfa4049761095dcbb6797f1533d6a513e3b503c Signed-off-by: Marshall Dawson marshalldawson3rd@gmail.com --- M src/drivers/mrc_cache/mrc_cache.c 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/37720/1
diff --git a/src/drivers/mrc_cache/mrc_cache.c b/src/drivers/mrc_cache/mrc_cache.c index ca0f447..d4a4aab 100644 --- a/src/drivers/mrc_cache/mrc_cache.c +++ b/src/drivers/mrc_cache/mrc_cache.c @@ -415,8 +415,8 @@ printk(BIOS_DEBUG, "MRC: cache data '%s' needs update.\n", cr->name);
if (region_file_update_data(&cache_file, - cbmem_entry_start(to_be_updated), - cbmem_entry_size(to_be_updated)) < 0) + cbmem_entry_start(to_be_updated), + cbmem_entry_size(to_be_updated)) < 0) log_event_cache_update(cr->elog_slot, UPDATE_FAILURE); else log_event_cache_update(cr->elog_slot, UPDATE_SUCCESS);
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37720 )
Change subject: drivers/mrc_cache: Redo indenting ......................................................................
Patch Set 1: Code-Review+2
Marshall Dawson has submitted this change. ( https://review.coreboot.org/c/coreboot/+/37720 )
Change subject: drivers/mrc_cache: Redo indenting ......................................................................
drivers/mrc_cache: Redo indenting
Indent continuation lines of an if test farther than its "true" expression to be executed.
Change-Id: I3dfa4049761095dcbb6797f1533d6a513e3b503c Signed-off-by: Marshall Dawson marshalldawson3rd@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/37720 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Arthur Heymans arthur@aheymans.xyz Reviewed-by: Angel Pons th3fanbus@gmail.com --- M src/drivers/mrc_cache/mrc_cache.c 1 file changed, 2 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Arthur Heymans: Looks good to me, approved Angel Pons: Looks good to me, approved
diff --git a/src/drivers/mrc_cache/mrc_cache.c b/src/drivers/mrc_cache/mrc_cache.c index ca0f447..d4a4aab 100644 --- a/src/drivers/mrc_cache/mrc_cache.c +++ b/src/drivers/mrc_cache/mrc_cache.c @@ -415,8 +415,8 @@ printk(BIOS_DEBUG, "MRC: cache data '%s' needs update.\n", cr->name);
if (region_file_update_data(&cache_file, - cbmem_entry_start(to_be_updated), - cbmem_entry_size(to_be_updated)) < 0) + cbmem_entry_start(to_be_updated), + cbmem_entry_size(to_be_updated)) < 0) log_event_cache_update(cr->elog_slot, UPDATE_FAILURE); else log_event_cache_update(cr->elog_slot, UPDATE_SUCCESS);
-
Arthur Heymans (Code Review) -
Marshall Dawson (Code Review)