Attention is currently required from: Jason Glenesk, Marshall Dawson, Kyösti Mälkki, Felix Held.
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50559 )
Change subject: mb/amd/majolica: Add plain dsdt
......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/amd/majolica/dsdt.asl:
https://review.coreboot.org/c/coreboot/+/50559/comment/c88ec8bf_45c0e1bb
PS1, Line 3: #define MAINBOARD_HAS_SPEAKER 1
At least at the moment, nobody defines this 0, and the test is with "#if". […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/50559
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifd71635d3493e0cf104b60ecf94ebdf70d512b94
Gerrit-Change-Number: 50559
Gerrit-PatchSet: 2
Gerrit-Owner: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Thu, 11 Feb 2021 20:19:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-MessageType: comment