Change in coreboot[master]: ec/google/chromeec: Separate SMBIOS SKU functions - coreboot-gerrit

5 Jun 2021


      Attention is currently required from: Hung-Te Lin, Tim Wawrzynczak.
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55174 )
Change subject: ec/google/chromeec: Separate SMBIOS SKU functions
......................................................................
Patch Set 2:
(2 comments)
File src/ec/google/chromeec/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/55174/comment/99b7d3d9_b1dab070 
PS1, Line 17: smm-$(CONFIG_EC_GOOGLE_CHROMEEC_SKUID) += ec_smbios_skuid.c
...
I don't believe this is required
Done
File src/ec/google/chromeec/ec_smbios_skuid.c:
PS1:
...
suggestion: name this file […]
Done
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/55174
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8916223f5f04afe4761be4ad3313e900efae90d4
Gerrit-Change-Number: 55174
Gerrit-PatchSet: 2
Gerrit-Owner: Yu-Ping Wu yupingso@google.com
Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Hung-Te Lin hungte@chromium.org
Gerrit-Attention: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Comment-Date: Sat, 05 Jun 2021 08:54:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-MessageType: comment