EricR Lai has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/40663 )
Change subject: mb/google/deltaur: Disable POWER_OFF_ON_CR50_UPDATE ......................................................................
mb/google/deltaur: Disable POWER_OFF_ON_CR50_UPDATE
This is missing configuration of Wiloc projects. Following Wilco projects configuration. CB:32436
BUG=b:150165131
Signed-off-by: Eric Lai ericr_lai@compal.corp-partner.google.com Change-Id: I6da89de9401793a4e5c56a23c1018527819718cf --- M src/mainboard/google/deltaur/Kconfig 1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/63/40663/1
diff --git a/src/mainboard/google/deltaur/Kconfig b/src/mainboard/google/deltaur/Kconfig index 74c8201..e480ca5 100644 --- a/src/mainboard/google/deltaur/Kconfig +++ b/src/mainboard/google/deltaur/Kconfig @@ -52,6 +52,10 @@ string default "variants/$(CONFIG_VARIANT_DIR)/overridetree.cb"
+config POWER_OFF_ON_CR50_UPDATE + bool + default n + config MAINBOARD_DIR string default "google/deltaur"
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40663 )
Change subject: mb/google/deltaur: Disable POWER_OFF_ON_CR50_UPDATE ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40663/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40663/1//COMMIT_MSG@11 PS1, Line 11: LGTM, can you just add more detail about why this is needed? something like: The power architecture on this platform is different than most of our other x86 devices and needs some special handling to ensure it powers up again after an EC reset.
Hello build bot (Jenkins), Tim Wawrzynczak, Duncan Laurie,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/40663
to look at the new patch set (#2).
Change subject: mb/google/deltaur: Disable POWER_OFF_ON_CR50_UPDATE ......................................................................
mb/google/deltaur: Disable POWER_OFF_ON_CR50_UPDATE
This is missing configuration of Wiloc projects. Following Wilco projects configuration. CB:32436
The power architecture on this platform is different than most of our other x86 devices and needs some special handling to ensure it powers up again after an EC reset.
BUG=b:150165131
Signed-off-by: Eric Lai ericr_lai@compal.corp-partner.google.com Change-Id: I6da89de9401793a4e5c56a23c1018527819718cf --- M src/mainboard/google/deltaur/Kconfig 1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/63/40663/2
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40663 )
Change subject: mb/google/deltaur: Disable POWER_OFF_ON_CR50_UPDATE ......................................................................
Patch Set 2:
I do believe Intel copy the config from volteer not Drallion and Sarien. Missing some config though.. HDA and DISABLE_SPI_SMM
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40663 )
Change subject: mb/google/deltaur: Disable POWER_OFF_ON_CR50_UPDATE ......................................................................
Patch Set 2:
(1 comment)
I don't't know how to explain so I just copied yours 😄
https://review.coreboot.org/c/coreboot/+/40663/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40663/1//COMMIT_MSG@11 PS1, Line 11:
LGTM, can you just add more detail about why this is needed? […]
Done
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40663 )
Change subject: mb/google/deltaur: Disable POWER_OFF_ON_CR50_UPDATE ......................................................................
Patch Set 2: Code-Review+2
Tim Wawrzynczak has submitted this change. ( https://review.coreboot.org/c/coreboot/+/40663 )
Change subject: mb/google/deltaur: Disable POWER_OFF_ON_CR50_UPDATE ......................................................................
mb/google/deltaur: Disable POWER_OFF_ON_CR50_UPDATE
This is missing configuration of Wiloc projects. Following Wilco projects configuration. CB:32436
The power architecture on this platform is different than most of our other x86 devices and needs some special handling to ensure it powers up again after an EC reset.
BUG=b:150165131
Signed-off-by: Eric Lai ericr_lai@compal.corp-partner.google.com Change-Id: I6da89de9401793a4e5c56a23c1018527819718cf Reviewed-on: https://review.coreboot.org/c/coreboot/+/40663 Reviewed-by: Tim Wawrzynczak twawrzynczak@chromium.org Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/deltaur/Kconfig 1 file changed, 4 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Tim Wawrzynczak: Looks good to me, approved
diff --git a/src/mainboard/google/deltaur/Kconfig b/src/mainboard/google/deltaur/Kconfig index 7395c00..a9197f0 100644 --- a/src/mainboard/google/deltaur/Kconfig +++ b/src/mainboard/google/deltaur/Kconfig @@ -53,6 +53,10 @@ string default "variants/$(CONFIG_VARIANT_DIR)/overridetree.cb"
+config POWER_OFF_ON_CR50_UPDATE + bool + default n + config MAINBOARD_DIR string default "google/deltaur"
9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40663 )
Change subject: mb/google/deltaur: Disable POWER_OFF_ON_CR50_UPDATE ......................................................................
Patch Set 3:
Automatic boot test returned (PASS/FAIL/TOTAL): 4/0/4 Emulation targets: "QEMU x86 q35/ich9" using payload TianoCore : SUCCESS : https://lava.9esec.io/r/2792 "QEMU x86 q35/ich9" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/2791 "QEMU x86 i440fx/piix4" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/2790 "QEMU AArch64" using payload LinuxBoot_u-root_kexec : SUCCESS : https://lava.9esec.io/r/2789
Please note: This test is under development and might not be accurate at all!
-
9elements QA (Code Review) -
EricR Lai (Code Review)
-
Tim Wawrzynczak (Code Review)