Change in coreboot[master]: mb/google/zork: Add HID for max98357a

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Raul Rangel (Code Review)

2 Jun 2020 2 Jun '20

10:51 a.m.

Raul Rangel has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/42015 )

Change subject: mb/google/zork: Add HID for max98357a ......................................................................

mb/google/zork: Add HID for max98357a

The default HID was removed by a1c82c5ebee. We need to explicitly specify it.

BUG=b:154756391 TEST=No longer see ERROR: _HID required message in console

Signed-off-by: Raul E Rangel rrangel@chromium.org Change-Id: I0083f98aea55ba262ac44b0018c9c1d2e12d9f8e --- M src/mainboard/google/zork/variants/baseboard/devicetree.cb 1 file changed, 1 insertion(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/42015/1

diff --git a/src/mainboard/google/zork/variants/baseboard/devicetree.cb b/src/mainboard/google/zork/variants/baseboard/devicetree.cb index c90c322..664e379 100644 --- a/src/mainboard/google/zork/variants/baseboard/devicetree.cb +++ b/src/mainboard/google/zork/variants/baseboard/devicetree.cb @@ -172,6 +172,7 @@ end # domain

chip drivers/generic/max98357a + register "hid" = ""MX98357A"" register "sdmode_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_91)" register "sdmode_delay" = "5" device generic 0.1 on end

Attachments:

attachment.htm (text/html — 2.6 KB)

Show replies by date

Furquan Shaikh (Code Review)

2 Jun 2 Jun

5:19 p.m.

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42015 )

Change subject: mb/google/zork: Add HID for max98357a ......................................................................

Patch Set 1: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/42015 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0083f98aea55ba262ac44b0018c9c1d2e12d9f8e Gerrit-Change-Number: 42015 Gerrit-PatchSet: 1 Gerrit-Owner: Raul Rangel rrangel@chromium.org Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Tue, 02 Jun 2020 23:19:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Aaron Durbin (Code Review)

3 Jun 3 Jun

11:55 a.m.

Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42015 )

Change subject: mb/google/zork: Add HID for max98357a ......................................................................

Patch Set 1: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/42015 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0083f98aea55ba262ac44b0018c9c1d2e12d9f8e Gerrit-Change-Number: 42015 Gerrit-PatchSet: 1 Gerrit-Owner: Raul Rangel rrangel@chromium.org Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Wed, 03 Jun 2020 17:55:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Felix Held (Code Review)

1:18 p.m.

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/42015 )

Change subject: mb/google/zork: Add HID for max98357a ......................................................................

mb/google/zork: Add HID for max98357a

The default HID was removed by a1c82c5ebee. We need to explicitly specify it.

BUG=b:154756391 TEST=No longer see ERROR: _HID required message in console

Signed-off-by: Raul E Rangel rrangel@chromium.org Change-Id: I0083f98aea55ba262ac44b0018c9c1d2e12d9f8e Reviewed-on: https://review.coreboot.org/c/coreboot/+/42015 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Furquan Shaikh furquan@google.com Reviewed-by: Aaron Durbin adurbin@chromium.org --- M src/mainboard/google/zork/variants/baseboard/devicetree.cb 1 file changed, 1 insertion(+), 0 deletions(-)

Approvals: build bot (Jenkins): Verified Aaron Durbin: Looks good to me, approved Furquan Shaikh: Looks good to me, approved

chip drivers/generic/max98357a + register "hid" = ""MX98357A"" register "sdmode_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_91)" register "sdmode_delay" = "5" device generic 0.1 on end

-- To view, visit https://review.coreboot.org/c/coreboot/+/42015 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0083f98aea55ba262ac44b0018c9c1d2e12d9f8e Gerrit-Change-Number: 42015 Gerrit-PatchSet: 2 Gerrit-Owner: Raul Rangel rrangel@chromium.org Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: merged

9elements QA (Code Review)

2:07 p.m.

9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42015 )

Change subject: mb/google/zork: Add HID for max98357a ......................................................................

Patch Set 2:

Automatic boot test returned (PASS/FAIL/TOTAL): 4/0/4 Emulation targets: "QEMU x86 q35/ich9" using payload TianoCore : SUCCESS : https://lava.9esec.io/r/4840 "QEMU x86 q35/ich9" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/4839 "QEMU x86 i440fx/piix4" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/4838 "QEMU AArch64" using payload LinuxBoot_u-root_kexec : SUCCESS : https://lava.9esec.io/r/4837

Please note: This test is under development and might not be accurate at all!

-- To view, visit https://review.coreboot.org/c/coreboot/+/42015 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0083f98aea55ba262ac44b0018c9c1d2e12d9f8e Gerrit-Change-Number: 42015 Gerrit-PatchSet: 2 Gerrit-Owner: Raul Rangel rrangel@chromium.org Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: 9elements QA hardwaretestrobot@gmail.com Gerrit-Comment-Date: Wed, 03 Jun 2020 20:07:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Paul Menzel (Code Review)

4 Jun 4 Jun

8:57 a.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42015 )

Change subject: mb/google/zork: Add HID for max98357a ......................................................................

Patch Set 2:

(1 comment)

I missed to publish my comment. Please keep it in mind for the future.

https://review.coreboot.org/c/coreboot/+/42015/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/42015/1//COMMIT_MSG@9 PS1, Line 9: The default HID was removed by a1c82c5ebee. We need to explicitly Gerrit does not highlight it. Do you need to add *commit* before the hash?

Please use the style below anyway:

...

commit a1c82c5ebee (drivers/generic/max98357a: Allow custom _HID from config)

-- To view, visit https://review.coreboot.org/c/coreboot/+/42015 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0083f98aea55ba262ac44b0018c9c1d2e12d9f8e Gerrit-Change-Number: 42015 Gerrit-PatchSet: 2 Gerrit-Owner: Raul Rangel rrangel@chromium.org Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: 9elements QA hardwaretestrobot@gmail.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Thu, 04 Jun 2020 14:57:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1804

days inactive

1806

days old

coreboot-gerrit@coreboot.org

5 comments

6 participants

tags (0)

participants (6)

9elements QA (Code Review)
Aaron Durbin (Code Review)
Felix Held (Code Review)
Furquan Shaikh (Code Review)
Paul Menzel (Code Review)
Raul Rangel (Code Review)