HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/41489 )
Change subject: src: Remove unused '#include <cpu/x86/lapic.h>' ......................................................................
src: Remove unused '#include <cpu/x86/lapic.h>'
Change-Id: I71cff43d53660dc1e5a760ac3034bcf75f93c6e7 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/cpu/amd/smm/smm_init.c M src/cpu/intel/haswell/smmrelocate.c M src/cpu/intel/hyperthreading/intel_sibling.c M src/cpu/x86/mtrr/mtrr.c M src/mainboard/amd/gardenia/mptable.c M src/mainboard/amd/olivehill/mptable.c M src/mainboard/amd/parmer/mptable.c M src/mainboard/amd/thatcher/mptable.c M src/mainboard/asrock/imb-a180/mptable.c M src/mainboard/asus/am1i-a/mptable.c M src/mainboard/asus/f2a85-m/mptable.c M src/mainboard/bap/ode_e20XX/mptable.c M src/mainboard/bap/ode_e21XX/mptable.c M src/mainboard/bap/ode_e21XX/romstage.c M src/mainboard/biostar/a68n_5200/mptable.c M src/mainboard/biostar/am1ml/mptable.c M src/mainboard/gizmosphere/gizmo2/mptable.c M src/mainboard/google/butterfly/early_init.c M src/mainboard/google/kahlee/mptable.c M src/mainboard/google/link/early_init.c M src/mainboard/google/parrot/early_init.c M src/mainboard/google/stout/early_init.c M src/mainboard/hp/abm/mptable.c M src/mainboard/hp/pavilion_m6_1035dx/mptable.c M src/mainboard/intel/emeraldlake2/early_init.c M src/mainboard/kontron/ktqm77/early_init.c M src/mainboard/lenovo/g505s/mptable.c M src/mainboard/lenovo/x1_carbon_gen1/early_init.c M src/mainboard/lenovo/x201/mainboard.c M src/mainboard/lenovo/x220/early_init.c M src/mainboard/lenovo/x230/variants/x230/early_init.c M src/mainboard/msi/ms7721/mptable.c M src/mainboard/packardbell/ms2290/mainboard.c M src/mainboard/samsung/lumpy/early_init.c M src/mainboard/samsung/stumpy/early_init.c M src/northbridge/amd/agesa/family14/northbridge.c M src/soc/amd/common/block/smbus/sm.c M src/soc/intel/braswell/northcluster.c M src/soc/intel/broadwell/smmrelocate.c M src/soc/intel/cannonlake/smmrelocate.c M src/soc/intel/icelake/smmrelocate.c M src/soc/intel/jasperlake/smmrelocate.c M src/soc/intel/skylake/smmrelocate.c M src/soc/intel/tigerlake/smmrelocate.c M src/soc/intel/xeon_sp/uncore.c M src/southbridge/amd/agesa/hudson/sm.c M src/southbridge/amd/pi/hudson/sm.c 47 files changed, 1 insertion(+), 47 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/41489/1
diff --git a/src/cpu/amd/smm/smm_init.c b/src/cpu/amd/smm/smm_init.c index 0de8fba..71cca82 100644 --- a/src/cpu/amd/smm/smm_init.c +++ b/src/cpu/amd/smm/smm_init.c @@ -1,6 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-#include <cpu/x86/lapic.h> #include <cpu/x86/msr.h> #include <cpu/x86/mtrr.h> #include <cpu/amd/mtrr.h> diff --git a/src/cpu/intel/haswell/smmrelocate.c b/src/cpu/intel/haswell/smmrelocate.c index 1c96188..0f7585a 100644 --- a/src/cpu/intel/haswell/smmrelocate.c +++ b/src/cpu/intel/haswell/smmrelocate.c @@ -5,7 +5,6 @@ #include <device/device.h> #include <device/pci.h> #include <device/pci_ops.h> -#include <cpu/x86/lapic.h> #include <cpu/x86/mp.h> #include <cpu/x86/msr.h> #include <cpu/x86/mtrr.h> diff --git a/src/cpu/intel/hyperthreading/intel_sibling.c b/src/cpu/intel/hyperthreading/intel_sibling.c index 9febc83..329b693 100644 --- a/src/cpu/intel/hyperthreading/intel_sibling.c +++ b/src/cpu/intel/hyperthreading/intel_sibling.c @@ -1,7 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */
#include <console/console.h> -#include <cpu/x86/lapic.h> #include <cpu/intel/hyperthreading.h> #include <device/device.h> #include <option.h> diff --git a/src/cpu/x86/mtrr/mtrr.c b/src/cpu/x86/mtrr/mtrr.c index 6187578..1f37659 100644 --- a/src/cpu/x86/mtrr/mtrr.c +++ b/src/cpu/x86/mtrr/mtrr.c @@ -19,7 +19,6 @@ #include <cpu/x86/msr.h> #include <cpu/x86/mtrr.h> #include <cpu/x86/cache.h> -#include <cpu/x86/lapic.h> #include <memrange.h> #include <cpu/amd/mtrr.h> #include <assert.h> diff --git a/src/mainboard/amd/gardenia/mptable.c b/src/mainboard/amd/gardenia/mptable.c index 3528a13..6460fed 100644 --- a/src/mainboard/amd/gardenia/mptable.c +++ b/src/mainboard/amd/gardenia/mptable.c @@ -4,7 +4,6 @@ #include <arch/ioapic.h> #include <string.h> #include <stdint.h> -#include <cpu/x86/lapic.h> #include <soc/southbridge.h> #include <amdblocks/amd_pci_util.h>
diff --git a/src/mainboard/amd/olivehill/mptable.c b/src/mainboard/amd/olivehill/mptable.c index ab321c0..4761728 100644 --- a/src/mainboard/amd/olivehill/mptable.c +++ b/src/mainboard/amd/olivehill/mptable.c @@ -5,7 +5,6 @@ #include <arch/ioapic.h> #include <string.h> #include <stdint.h> -#include <cpu/x86/lapic.h> #include <southbridge/amd/agesa/hudson/hudson.h>
u8 picr_data[0x54] = { diff --git a/src/mainboard/amd/parmer/mptable.c b/src/mainboard/amd/parmer/mptable.c index 28866e8..c7aa69e 100644 --- a/src/mainboard/amd/parmer/mptable.c +++ b/src/mainboard/amd/parmer/mptable.c @@ -5,7 +5,6 @@ #include <arch/ioapic.h> #include <string.h> #include <stdint.h> -#include <cpu/x86/lapic.h> #include <southbridge/amd/agesa/hudson/hudson.h>
u8 picr_data[0x54] = { diff --git a/src/mainboard/amd/thatcher/mptable.c b/src/mainboard/amd/thatcher/mptable.c index 8b8bc03..bc091e5 100644 --- a/src/mainboard/amd/thatcher/mptable.c +++ b/src/mainboard/amd/thatcher/mptable.c @@ -5,7 +5,6 @@ #include <arch/ioapic.h> #include <string.h> #include <stdint.h> -#include <cpu/x86/lapic.h> #include <southbridge/amd/agesa/hudson/hudson.h>
u8 picr_data[] = { diff --git a/src/mainboard/asrock/imb-a180/mptable.c b/src/mainboard/asrock/imb-a180/mptable.c index 2a35eb9..20c4b8d 100644 --- a/src/mainboard/asrock/imb-a180/mptable.c +++ b/src/mainboard/asrock/imb-a180/mptable.c @@ -5,7 +5,6 @@ #include <arch/ioapic.h> #include <string.h> #include <stdint.h> -#include <cpu/x86/lapic.h> #include <southbridge/amd/agesa/hudson/hudson.h>
diff --git a/src/mainboard/asus/am1i-a/mptable.c b/src/mainboard/asus/am1i-a/mptable.c index 5caa783..cd72ca3 100644 --- a/src/mainboard/asus/am1i-a/mptable.c +++ b/src/mainboard/asus/am1i-a/mptable.c @@ -3,7 +3,6 @@ #include <arch/smp/mpspec.h> #include <arch/ioapic.h> #include <stdint.h> -#include <cpu/x86/lapic.h> #include <southbridge/amd/common/amd_pci_util.h> #include <drivers/generic/ioapic/chip.h>
diff --git a/src/mainboard/asus/f2a85-m/mptable.c b/src/mainboard/asus/f2a85-m/mptable.c index 7d9dcc3..e3c7d80 100644 --- a/src/mainboard/asus/f2a85-m/mptable.c +++ b/src/mainboard/asus/f2a85-m/mptable.c @@ -3,7 +3,6 @@ #include <arch/io.h> #include <arch/ioapic.h> #include <arch/smp/mpspec.h> -#include <cpu/x86/lapic.h> #include <stdint.h> #include <string.h> #include <southbridge/amd/agesa/hudson/hudson.h> diff --git a/src/mainboard/bap/ode_e20XX/mptable.c b/src/mainboard/bap/ode_e20XX/mptable.c index b854b75..c0ad4ed 100644 --- a/src/mainboard/bap/ode_e20XX/mptable.c +++ b/src/mainboard/bap/ode_e20XX/mptable.c @@ -3,7 +3,6 @@ #include <arch/smp/mpspec.h> #include <arch/ioapic.h> #include <stdint.h> -#include <cpu/x86/lapic.h> #include <southbridge/amd/common/amd_pci_util.h> #include <drivers/generic/ioapic/chip.h>
diff --git a/src/mainboard/bap/ode_e21XX/mptable.c b/src/mainboard/bap/ode_e21XX/mptable.c index 0d8c942..c5aeeb0 100644 --- a/src/mainboard/bap/ode_e21XX/mptable.c +++ b/src/mainboard/bap/ode_e21XX/mptable.c @@ -5,7 +5,6 @@ #include <arch/ioapic.h> #include <string.h> #include <stdint.h> -#include <cpu/x86/lapic.h> #include <southbridge/amd/pi/hudson/hudson.h>
u8 picr_data[0x54] = { diff --git a/src/mainboard/bap/ode_e21XX/romstage.c b/src/mainboard/bap/ode_e21XX/romstage.c index 74b8517..6b116fd 100644 --- a/src/mainboard/bap/ode_e21XX/romstage.c +++ b/src/mainboard/bap/ode_e21XX/romstage.c @@ -5,7 +5,6 @@ #include <device/pci_def.h> #include <arch/io.h> #include <arch/cpu.h> -#include <cpu/x86/lapic.h> #include <console/console.h> #include <northbridge/amd/agesa/state_machine.h> #include <southbridge/amd/pi/hudson/hudson.h> diff --git a/src/mainboard/biostar/a68n_5200/mptable.c b/src/mainboard/biostar/a68n_5200/mptable.c index ab321c0..4921c34 100644 --- a/src/mainboard/biostar/a68n_5200/mptable.c +++ b/src/mainboard/biostar/a68n_5200/mptable.c @@ -5,7 +5,7 @@ #include <arch/ioapic.h> #include <string.h> #include <stdint.h> -#include <cpu/x86/lapic.h> + #include <southbridge/amd/agesa/hudson/hudson.h>
u8 picr_data[0x54] = { diff --git a/src/mainboard/biostar/am1ml/mptable.c b/src/mainboard/biostar/am1ml/mptable.c index 7a02800..41e70b9 100644 --- a/src/mainboard/biostar/am1ml/mptable.c +++ b/src/mainboard/biostar/am1ml/mptable.c @@ -3,7 +3,6 @@ #include <arch/smp/mpspec.h> #include <arch/ioapic.h> #include <stdint.h> -#include <cpu/x86/lapic.h> #include <southbridge/amd/common/amd_pci_util.h> #include <drivers/generic/ioapic/chip.h>
diff --git a/src/mainboard/gizmosphere/gizmo2/mptable.c b/src/mainboard/gizmosphere/gizmo2/mptable.c index b854b75..c0ad4ed 100644 --- a/src/mainboard/gizmosphere/gizmo2/mptable.c +++ b/src/mainboard/gizmosphere/gizmo2/mptable.c @@ -3,7 +3,6 @@ #include <arch/smp/mpspec.h> #include <arch/ioapic.h> #include <stdint.h> -#include <cpu/x86/lapic.h> #include <southbridge/amd/common/amd_pci_util.h> #include <drivers/generic/ioapic/chip.h>
diff --git a/src/mainboard/google/butterfly/early_init.c b/src/mainboard/google/butterfly/early_init.c index 21d59d1..df51f66 100644 --- a/src/mainboard/google/butterfly/early_init.c +++ b/src/mainboard/google/butterfly/early_init.c @@ -1,7 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */
#include <stdint.h> -#include <cpu/x86/lapic.h> #include <acpi/acpi.h> #include <northbridge/intel/sandybridge/sandybridge.h> #include <northbridge/intel/sandybridge/raminit.h> diff --git a/src/mainboard/google/kahlee/mptable.c b/src/mainboard/google/kahlee/mptable.c index 3528a13..6460fed 100644 --- a/src/mainboard/google/kahlee/mptable.c +++ b/src/mainboard/google/kahlee/mptable.c @@ -4,7 +4,6 @@ #include <arch/ioapic.h> #include <string.h> #include <stdint.h> -#include <cpu/x86/lapic.h> #include <soc/southbridge.h> #include <amdblocks/amd_pci_util.h>
diff --git a/src/mainboard/google/link/early_init.c b/src/mainboard/google/link/early_init.c index 27f086c..8360f2a 100644 --- a/src/mainboard/google/link/early_init.c +++ b/src/mainboard/google/link/early_init.c @@ -3,7 +3,6 @@ #include <stdint.h> #include <string.h> #include <device/pci_ops.h> -#include <cpu/x86/lapic.h> #include <acpi/acpi.h> #include <console/console.h> #include <northbridge/intel/sandybridge/sandybridge.h> diff --git a/src/mainboard/google/parrot/early_init.c b/src/mainboard/google/parrot/early_init.c index cff8438..3c5c363 100644 --- a/src/mainboard/google/parrot/early_init.c +++ b/src/mainboard/google/parrot/early_init.c @@ -1,7 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */
#include <stdint.h> -#include <cpu/x86/lapic.h> #include <acpi/acpi.h> #include <northbridge/intel/sandybridge/sandybridge.h> #include <northbridge/intel/sandybridge/raminit.h> diff --git a/src/mainboard/google/stout/early_init.c b/src/mainboard/google/stout/early_init.c index 1b73fc0..e71d0ee 100644 --- a/src/mainboard/google/stout/early_init.c +++ b/src/mainboard/google/stout/early_init.c @@ -1,7 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */
#include <stdint.h> -#include <cpu/x86/lapic.h> #include <acpi/acpi.h> #include <console/console.h> #include <northbridge/intel/sandybridge/sandybridge.h> diff --git a/src/mainboard/hp/abm/mptable.c b/src/mainboard/hp/abm/mptable.c index ab321c0..4761728 100644 --- a/src/mainboard/hp/abm/mptable.c +++ b/src/mainboard/hp/abm/mptable.c @@ -5,7 +5,6 @@ #include <arch/ioapic.h> #include <string.h> #include <stdint.h> -#include <cpu/x86/lapic.h> #include <southbridge/amd/agesa/hudson/hudson.h>
u8 picr_data[0x54] = { diff --git a/src/mainboard/hp/pavilion_m6_1035dx/mptable.c b/src/mainboard/hp/pavilion_m6_1035dx/mptable.c index 4433c71..c620be2 100644 --- a/src/mainboard/hp/pavilion_m6_1035dx/mptable.c +++ b/src/mainboard/hp/pavilion_m6_1035dx/mptable.c @@ -3,7 +3,6 @@ #include <arch/io.h> #include <arch/ioapic.h> #include <arch/smp/mpspec.h> -#include <cpu/x86/lapic.h> #include <stdint.h> #include <string.h> #include <southbridge/amd/agesa/hudson/hudson.h> diff --git a/src/mainboard/intel/emeraldlake2/early_init.c b/src/mainboard/intel/emeraldlake2/early_init.c index 6e1f7e3..119346e 100644 --- a/src/mainboard/intel/emeraldlake2/early_init.c +++ b/src/mainboard/intel/emeraldlake2/early_init.c @@ -3,7 +3,6 @@ #include <bootblock_common.h> #include <stdint.h> #include <arch/io.h> -#include <cpu/x86/lapic.h> #include <superio/smsc/sio1007/sio1007.h> #include <northbridge/intel/sandybridge/sandybridge.h> #include <northbridge/intel/sandybridge/raminit.h> diff --git a/src/mainboard/kontron/ktqm77/early_init.c b/src/mainboard/kontron/ktqm77/early_init.c index 31eb05b..b8f44b5 100644 --- a/src/mainboard/kontron/ktqm77/early_init.c +++ b/src/mainboard/kontron/ktqm77/early_init.c @@ -4,7 +4,6 @@ #include <stdint.h> #include <device/pnp_ops.h> #include <device/pci_ops.h> -#include <cpu/x86/lapic.h> #include <cpu/x86/msr.h> #include <device/pci_def.h> #include <northbridge/intel/sandybridge/raminit_native.h> diff --git a/src/mainboard/lenovo/g505s/mptable.c b/src/mainboard/lenovo/g505s/mptable.c index 19ac198..bc1759a 100644 --- a/src/mainboard/lenovo/g505s/mptable.c +++ b/src/mainboard/lenovo/g505s/mptable.c @@ -3,7 +3,6 @@ #include <arch/io.h> #include <arch/ioapic.h> #include <arch/smp/mpspec.h> -#include <cpu/x86/lapic.h> #include <stdint.h> #include <string.h> #include <southbridge/amd/agesa/hudson/hudson.h> diff --git a/src/mainboard/lenovo/x1_carbon_gen1/early_init.c b/src/mainboard/lenovo/x1_carbon_gen1/early_init.c index a709450..f5299ea 100644 --- a/src/mainboard/lenovo/x1_carbon_gen1/early_init.c +++ b/src/mainboard/lenovo/x1_carbon_gen1/early_init.c @@ -2,7 +2,6 @@
#include <stdint.h> #include <string.h> -#include <cpu/x86/lapic.h> #include <console/console.h> #include <northbridge/intel/sandybridge/sandybridge.h> #include <northbridge/intel/sandybridge/raminit_native.h> diff --git a/src/mainboard/lenovo/x201/mainboard.c b/src/mainboard/lenovo/x201/mainboard.c index beb9938..1a306b1 100644 --- a/src/mainboard/lenovo/x201/mainboard.c +++ b/src/mainboard/lenovo/x201/mainboard.c @@ -6,7 +6,6 @@ #include <southbridge/intel/bd82x6x/pch.h> #include "dock.h" #include <drivers/intel/gma/int15.h> -#include <cpu/x86/lapic.h> #include <drivers/lenovo/lenovo.h>
static void fill_ssdt(const struct device *device) diff --git a/src/mainboard/lenovo/x220/early_init.c b/src/mainboard/lenovo/x220/early_init.c index f87a9d4..5f0ad45 100644 --- a/src/mainboard/lenovo/x220/early_init.c +++ b/src/mainboard/lenovo/x220/early_init.c @@ -1,7 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */
#include <stdint.h> -#include <cpu/x86/lapic.h> #include <acpi/acpi.h> #include <northbridge/intel/sandybridge/sandybridge.h> #include <northbridge/intel/sandybridge/raminit.h> diff --git a/src/mainboard/lenovo/x230/variants/x230/early_init.c b/src/mainboard/lenovo/x230/variants/x230/early_init.c index 2089ee6..e6c4ffa 100644 --- a/src/mainboard/lenovo/x230/variants/x230/early_init.c +++ b/src/mainboard/lenovo/x230/variants/x230/early_init.c @@ -1,6 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-#include <cpu/x86/lapic.h> #include <northbridge/intel/sandybridge/sandybridge.h> #include <northbridge/intel/sandybridge/raminit_native.h> #include <southbridge/intel/bd82x6x/pch.h> diff --git a/src/mainboard/msi/ms7721/mptable.c b/src/mainboard/msi/ms7721/mptable.c index 7d9dcc3..e3c7d80 100644 --- a/src/mainboard/msi/ms7721/mptable.c +++ b/src/mainboard/msi/ms7721/mptable.c @@ -3,7 +3,6 @@ #include <arch/io.h> #include <arch/ioapic.h> #include <arch/smp/mpspec.h> -#include <cpu/x86/lapic.h> #include <stdint.h> #include <string.h> #include <southbridge/amd/agesa/hudson/hudson.h> diff --git a/src/mainboard/packardbell/ms2290/mainboard.c b/src/mainboard/packardbell/ms2290/mainboard.c index 6df8fad..ce8d504 100644 --- a/src/mainboard/packardbell/ms2290/mainboard.c +++ b/src/mainboard/packardbell/ms2290/mainboard.c @@ -7,7 +7,6 @@ #include <ec/acpi/ec.h> #include <drivers/intel/gma/int15.h> #include <pc80/keyboard.h> -#include <cpu/x86/lapic.h>
static void mainboard_enable(struct device *dev) { diff --git a/src/mainboard/samsung/lumpy/early_init.c b/src/mainboard/samsung/lumpy/early_init.c index 23309ba..091cbc5 100644 --- a/src/mainboard/samsung/lumpy/early_init.c +++ b/src/mainboard/samsung/lumpy/early_init.c @@ -4,7 +4,6 @@ #include <string.h> #include <arch/io.h> #include <bootblock_common.h> -#include <cpu/x86/lapic.h> #include <cbfs.h> #include <console/console.h> #include <bootmode.h> diff --git a/src/mainboard/samsung/stumpy/early_init.c b/src/mainboard/samsung/stumpy/early_init.c index 6636a6b..f079482 100644 --- a/src/mainboard/samsung/stumpy/early_init.c +++ b/src/mainboard/samsung/stumpy/early_init.c @@ -2,7 +2,6 @@
#include <bootblock_common.h> #include <stdint.h> -#include <cpu/x86/lapic.h> #include <pc80/mc146818rtc.h> #include <console/console.h> #include <bootmode.h> diff --git a/src/northbridge/amd/agesa/family14/northbridge.c b/src/northbridge/amd/agesa/family14/northbridge.c index 5cb99d6..eb7d14f 100644 --- a/src/northbridge/amd/agesa/family14/northbridge.c +++ b/src/northbridge/amd/agesa/family14/northbridge.c @@ -12,7 +12,6 @@ #include <string.h> #include <lib.h> #include <cpu/cpu.h> -#include <cpu/x86/lapic.h> #include <cpu/amd/msr.h> #include <cpu/amd/mtrr.h> #include <northbridge/amd/agesa/nb_common.h> diff --git a/src/soc/amd/common/block/smbus/sm.c b/src/soc/amd/common/block/smbus/sm.c index 2f37a91..5a4edd8 100644 --- a/src/soc/amd/common/block/smbus/sm.c +++ b/src/soc/amd/common/block/smbus/sm.c @@ -6,7 +6,6 @@ #include <device/pci_ids.h> #include <device/smbus.h> #include <device/smbus_host.h> -#include <cpu/x86/lapic.h> #include <arch/ioapic.h> #include <soc/southbridge.h>
diff --git a/src/soc/intel/braswell/northcluster.c b/src/soc/intel/braswell/northcluster.c index 2070cd7..57f8b4f 100644 --- a/src/soc/intel/braswell/northcluster.c +++ b/src/soc/intel/braswell/northcluster.c @@ -6,7 +6,6 @@ #include <device/device.h> #include <device/pci.h> #include <device/pci_ids.h> -#include <cpu/x86/lapic.h> #include <cpu/x86/smm.h> #include <fsp/util.h> #include <soc/iomap.h> diff --git a/src/soc/intel/broadwell/smmrelocate.c b/src/soc/intel/broadwell/smmrelocate.c index 660a688..03ed244 100644 --- a/src/soc/intel/broadwell/smmrelocate.c +++ b/src/soc/intel/broadwell/smmrelocate.c @@ -5,7 +5,6 @@ #include <device/device.h> #include <device/pci.h> #include <device/pci_ops.h> -#include <cpu/x86/lapic.h> #include <cpu/x86/mp.h> #include <cpu/x86/msr.h> #include <cpu/x86/mtrr.h> diff --git a/src/soc/intel/cannonlake/smmrelocate.c b/src/soc/intel/cannonlake/smmrelocate.c index dcf67bc..3aec51b 100644 --- a/src/soc/intel/cannonlake/smmrelocate.c +++ b/src/soc/intel/cannonlake/smmrelocate.c @@ -5,7 +5,6 @@ #include <device/device.h> #include <device/pci.h> #include <device/pci_ops.h> -#include <cpu/x86/lapic.h> #include <cpu/x86/mp.h> #include <cpu/x86/msr.h> #include <cpu/x86/mtrr.h> diff --git a/src/soc/intel/icelake/smmrelocate.c b/src/soc/intel/icelake/smmrelocate.c index d9ca915..f1a7033 100644 --- a/src/soc/intel/icelake/smmrelocate.c +++ b/src/soc/intel/icelake/smmrelocate.c @@ -5,7 +5,6 @@ #include <device/device.h> #include <device/pci.h> #include <device/pci_ops.h> -#include <cpu/x86/lapic.h> #include <cpu/x86/mp.h> #include <cpu/x86/msr.h> #include <cpu/x86/mtrr.h> diff --git a/src/soc/intel/jasperlake/smmrelocate.c b/src/soc/intel/jasperlake/smmrelocate.c index af16fbd..664ea6c 100644 --- a/src/soc/intel/jasperlake/smmrelocate.c +++ b/src/soc/intel/jasperlake/smmrelocate.c @@ -5,7 +5,6 @@ #include <device/device.h> #include <device/pci.h> #include <device/pci_ops.h> -#include <cpu/x86/lapic.h> #include <cpu/x86/mp.h> #include <cpu/x86/msr.h> #include <cpu/x86/mtrr.h> diff --git a/src/soc/intel/skylake/smmrelocate.c b/src/soc/intel/skylake/smmrelocate.c index e45da91..cb83d61 100644 --- a/src/soc/intel/skylake/smmrelocate.c +++ b/src/soc/intel/skylake/smmrelocate.c @@ -5,7 +5,6 @@ #include <device/device.h> #include <device/pci.h> #include <device/pci_ops.h> -#include <cpu/x86/lapic.h> #include <cpu/x86/mp.h> #include <cpu/x86/msr.h> #include <cpu/x86/mtrr.h> diff --git a/src/soc/intel/tigerlake/smmrelocate.c b/src/soc/intel/tigerlake/smmrelocate.c index af16fbd..664ea6c 100644 --- a/src/soc/intel/tigerlake/smmrelocate.c +++ b/src/soc/intel/tigerlake/smmrelocate.c @@ -5,7 +5,6 @@ #include <device/device.h> #include <device/pci.h> #include <device/pci_ops.h> -#include <cpu/x86/lapic.h> #include <cpu/x86/mp.h> #include <cpu/x86/msr.h> #include <cpu/x86/mtrr.h> diff --git a/src/soc/intel/xeon_sp/uncore.c b/src/soc/intel/xeon_sp/uncore.c index 1d46e40..55b561d 100644 --- a/src/soc/intel/xeon_sp/uncore.c +++ b/src/soc/intel/xeon_sp/uncore.c @@ -2,7 +2,6 @@
#include <cbmem.h> #include <console/console.h> -#include <cpu/x86/lapic.h> #include <device/pci.h> #include <device/pci_ids.h> #include <soc/iomap.h> diff --git a/src/southbridge/amd/agesa/hudson/sm.c b/src/southbridge/amd/agesa/hudson/sm.c index 9f14908..39e6752 100644 --- a/src/southbridge/amd/agesa/hudson/sm.c +++ b/src/southbridge/amd/agesa/hudson/sm.c @@ -4,7 +4,6 @@ #include <device/pci.h> #include <device/pci_ids.h> #include <device/smbus.h> -#include <cpu/x86/lapic.h> #include <arch/ioapic.h>
#include "hudson.h" diff --git a/src/southbridge/amd/pi/hudson/sm.c b/src/southbridge/amd/pi/hudson/sm.c index ee30b7f..268d7e4 100644 --- a/src/southbridge/amd/pi/hudson/sm.c +++ b/src/southbridge/amd/pi/hudson/sm.c @@ -4,7 +4,6 @@ #include <device/pci.h> #include <device/pci_ids.h> #include <device/smbus.h> -#include <cpu/x86/lapic.h> #include <arch/ioapic.h>
#include "hudson.h"
Hello Alexander Couzens, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/41489
to look at the new patch set (#2).
Change subject: src: Remove unused '#include <cpu/x86/lapic.h>' ......................................................................
src: Remove unused '#include <cpu/x86/lapic.h>'
Change-Id: I71cff43d53660dc1e5a760ac3034bcf75f93c6e7 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/cpu/amd/smm/smm_init.c M src/cpu/intel/haswell/smmrelocate.c M src/cpu/intel/hyperthreading/intel_sibling.c M src/cpu/x86/mtrr/mtrr.c M src/mainboard/amd/gardenia/mptable.c M src/mainboard/amd/olivehill/mptable.c M src/mainboard/amd/parmer/mptable.c M src/mainboard/amd/thatcher/mptable.c M src/mainboard/asrock/imb-a180/mptable.c M src/mainboard/asus/am1i-a/mptable.c M src/mainboard/asus/f2a85-m/mptable.c M src/mainboard/bap/ode_e20XX/mptable.c M src/mainboard/bap/ode_e21XX/mptable.c M src/mainboard/bap/ode_e21XX/romstage.c M src/mainboard/biostar/a68n_5200/mptable.c M src/mainboard/biostar/am1ml/mptable.c M src/mainboard/gizmosphere/gizmo2/mptable.c M src/mainboard/google/butterfly/early_init.c M src/mainboard/google/kahlee/mptable.c M src/mainboard/google/link/early_init.c M src/mainboard/google/parrot/early_init.c M src/mainboard/google/stout/early_init.c M src/mainboard/hp/abm/mptable.c M src/mainboard/hp/pavilion_m6_1035dx/mptable.c M src/mainboard/intel/emeraldlake2/early_init.c M src/mainboard/kontron/ktqm77/early_init.c M src/mainboard/lenovo/g505s/mptable.c M src/mainboard/lenovo/x1_carbon_gen1/early_init.c M src/mainboard/lenovo/x201/mainboard.c M src/mainboard/lenovo/x220/early_init.c M src/mainboard/lenovo/x230/variants/x230/early_init.c M src/mainboard/msi/ms7721/mptable.c M src/mainboard/packardbell/ms2290/mainboard.c M src/mainboard/samsung/lumpy/early_init.c M src/mainboard/samsung/stumpy/early_init.c M src/northbridge/amd/agesa/family14/northbridge.c M src/soc/amd/common/block/smbus/sm.c M src/soc/intel/braswell/northcluster.c M src/soc/intel/broadwell/smmrelocate.c M src/soc/intel/cannonlake/smmrelocate.c M src/soc/intel/icelake/smmrelocate.c M src/soc/intel/jasperlake/smmrelocate.c M src/soc/intel/skylake/smmrelocate.c M src/soc/intel/tigerlake/smmrelocate.c M src/soc/intel/xeon_sp/uncore.c M src/southbridge/amd/agesa/hudson/sm.c M src/southbridge/amd/pi/hudson/sm.c 47 files changed, 0 insertions(+), 47 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/41489/2
Hello build bot (Jenkins), Alexander Couzens, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/41489
to look at the new patch set (#3).
Change subject: src: Remove unused '#include <cpu/x86/lapic.h>' ......................................................................
src: Remove unused '#include <cpu/x86/lapic.h>'
Change-Id: I71cff43d53660dc1e5a760ac3034bcf75f93c6e7 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/cpu/amd/smm/smm_init.c M src/cpu/intel/haswell/smmrelocate.c M src/cpu/intel/hyperthreading/intel_sibling.c M src/cpu/x86/mtrr/mtrr.c M src/mainboard/amd/gardenia/mptable.c M src/mainboard/amd/olivehill/mptable.c M src/mainboard/amd/parmer/mptable.c M src/mainboard/amd/thatcher/mptable.c M src/mainboard/asrock/imb-a180/mptable.c M src/mainboard/asus/am1i-a/mptable.c M src/mainboard/asus/f2a85-m/mptable.c M src/mainboard/bap/ode_e20XX/mptable.c M src/mainboard/bap/ode_e21XX/mptable.c M src/mainboard/bap/ode_e21XX/romstage.c M src/mainboard/biostar/a68n_5200/mptable.c M src/mainboard/biostar/am1ml/mptable.c M src/mainboard/gizmosphere/gizmo2/mptable.c M src/mainboard/google/butterfly/early_init.c M src/mainboard/google/kahlee/mptable.c M src/mainboard/google/link/early_init.c M src/mainboard/google/parrot/early_init.c M src/mainboard/google/stout/early_init.c M src/mainboard/hp/abm/mptable.c M src/mainboard/hp/pavilion_m6_1035dx/mptable.c M src/mainboard/intel/emeraldlake2/early_init.c M src/mainboard/kontron/ktqm77/early_init.c M src/mainboard/lenovo/g505s/mptable.c M src/mainboard/lenovo/x1_carbon_gen1/early_init.c M src/mainboard/lenovo/x201/mainboard.c M src/mainboard/lenovo/x220/early_init.c M src/mainboard/lenovo/x230/variants/x230/early_init.c M src/mainboard/msi/ms7721/mptable.c M src/mainboard/packardbell/ms2290/mainboard.c M src/mainboard/samsung/lumpy/early_init.c M src/mainboard/samsung/stumpy/early_init.c M src/northbridge/amd/agesa/family14/northbridge.c M src/soc/amd/common/block/smbus/sm.c M src/soc/intel/braswell/northcluster.c M src/soc/intel/broadwell/smmrelocate.c M src/soc/intel/cannonlake/smmrelocate.c M src/soc/intel/icelake/smmrelocate.c M src/soc/intel/jasperlake/smmrelocate.c M src/soc/intel/skylake/smmrelocate.c M src/soc/intel/tigerlake/smmrelocate.c M src/soc/intel/xeon_sp/uncore.c M src/southbridge/amd/agesa/hudson/sm.c M src/southbridge/amd/pi/hudson/sm.c 47 files changed, 1 insertion(+), 47 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/41489/3
Hello build bot (Jenkins), Alexander Couzens, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/41489
to look at the new patch set (#4).
Change subject: src: Remove unused '#include <cpu/x86/lapic.h>' ......................................................................
src: Remove unused '#include <cpu/x86/lapic.h>'
Change-Id: I71cff43d53660dc1e5a760ac3034bcf75f93c6e7 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/cpu/amd/smm/smm_init.c M src/cpu/intel/haswell/smmrelocate.c M src/cpu/intel/hyperthreading/intel_sibling.c M src/cpu/x86/mtrr/mtrr.c M src/mainboard/amd/gardenia/mptable.c M src/mainboard/amd/olivehill/mptable.c M src/mainboard/amd/parmer/mptable.c M src/mainboard/amd/thatcher/mptable.c M src/mainboard/asrock/imb-a180/mptable.c M src/mainboard/asus/am1i-a/mptable.c M src/mainboard/asus/f2a85-m/mptable.c M src/mainboard/bap/ode_e20XX/mptable.c M src/mainboard/bap/ode_e21XX/mptable.c M src/mainboard/bap/ode_e21XX/romstage.c M src/mainboard/biostar/a68n_5200/mptable.c M src/mainboard/biostar/am1ml/mptable.c M src/mainboard/gizmosphere/gizmo2/mptable.c M src/mainboard/google/butterfly/early_init.c M src/mainboard/google/kahlee/mptable.c M src/mainboard/google/link/early_init.c M src/mainboard/google/parrot/early_init.c M src/mainboard/google/stout/early_init.c M src/mainboard/hp/abm/mptable.c M src/mainboard/hp/pavilion_m6_1035dx/mptable.c M src/mainboard/intel/emeraldlake2/early_init.c M src/mainboard/kontron/ktqm77/early_init.c M src/mainboard/lenovo/g505s/mptable.c M src/mainboard/lenovo/x1_carbon_gen1/early_init.c M src/mainboard/lenovo/x201/mainboard.c M src/mainboard/lenovo/x220/early_init.c M src/mainboard/lenovo/x230/variants/x230/early_init.c M src/mainboard/msi/ms7721/mptable.c M src/mainboard/packardbell/ms2290/mainboard.c M src/mainboard/samsung/lumpy/early_init.c M src/mainboard/samsung/stumpy/early_init.c M src/northbridge/amd/agesa/family14/northbridge.c M src/soc/amd/common/block/smbus/sm.c M src/soc/intel/braswell/northcluster.c M src/soc/intel/broadwell/smmrelocate.c M src/soc/intel/cannonlake/smmrelocate.c M src/soc/intel/icelake/smmrelocate.c M src/soc/intel/jasperlake/smmrelocate.c M src/soc/intel/skylake/smmrelocate.c M src/soc/intel/tigerlake/smmrelocate.c M src/soc/intel/xeon_sp/uncore.c M src/southbridge/amd/agesa/hudson/sm.c M src/southbridge/amd/pi/hudson/sm.c 47 files changed, 2 insertions(+), 47 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/41489/4
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41489 )
Change subject: src: Remove unused '#include <cpu/x86/lapic.h>' ......................................................................
Patch Set 5: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/41489/5/src/soc/intel/braswell/nort... File src/soc/intel/braswell/northcluster.c:
https://review.coreboot.org/c/coreboot/+/41489/5/src/soc/intel/braswell/nort... PS5, Line 9: #include <cpu/x86/lapic_def.h> Um... Please mention that.
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41489 )
Change subject: src: Remove unused '#include <cpu/x86/lapic.h>' ......................................................................
Patch Set 5:
(1 comment)
Thank you
https://review.coreboot.org/c/coreboot/+/41489/5/src/soc/intel/braswell/nort... File src/soc/intel/braswell/northcluster.c:
https://review.coreboot.org/c/coreboot/+/41489/5/src/soc/intel/braswell/nort... PS5, Line 9: #include <cpu/x86/lapic_def.h>
Um... Please mention that.
Thx Ack
Hello build bot (Jenkins), Jonathan Zhang, Angel Pons, Alexander Couzens, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/41489
to look at the new patch set (#6).
Change subject: src: Remove unused '#include <cpu/x86/lapic.h>' ......................................................................
src: Remove unused '#include <cpu/x86/lapic.h>'
Also, replace 'lapic.h' by 'lapic_def.h' in soc/intel/braswell/northcluster.c
Change-Id: I71cff43d53660dc1e5a760ac3034bcf75f93c6e7 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/cpu/amd/smm/smm_init.c M src/cpu/intel/haswell/smmrelocate.c M src/cpu/intel/hyperthreading/intel_sibling.c M src/cpu/x86/mtrr/mtrr.c M src/mainboard/amd/gardenia/mptable.c M src/mainboard/amd/olivehill/mptable.c M src/mainboard/amd/parmer/mptable.c M src/mainboard/amd/thatcher/mptable.c M src/mainboard/asrock/imb-a180/mptable.c M src/mainboard/asus/am1i-a/mptable.c M src/mainboard/asus/f2a85-m/mptable.c M src/mainboard/bap/ode_e20XX/mptable.c M src/mainboard/bap/ode_e21XX/mptable.c M src/mainboard/bap/ode_e21XX/romstage.c M src/mainboard/biostar/a68n_5200/mptable.c M src/mainboard/biostar/am1ml/mptable.c M src/mainboard/gizmosphere/gizmo2/mptable.c M src/mainboard/google/butterfly/early_init.c M src/mainboard/google/kahlee/mptable.c M src/mainboard/google/link/early_init.c M src/mainboard/google/parrot/early_init.c M src/mainboard/google/stout/early_init.c M src/mainboard/hp/abm/mptable.c M src/mainboard/hp/pavilion_m6_1035dx/mptable.c M src/mainboard/intel/emeraldlake2/early_init.c M src/mainboard/kontron/ktqm77/early_init.c M src/mainboard/lenovo/g505s/mptable.c M src/mainboard/lenovo/x1_carbon_gen1/early_init.c M src/mainboard/lenovo/x201/mainboard.c M src/mainboard/lenovo/x220/early_init.c M src/mainboard/lenovo/x230/variants/x230/early_init.c M src/mainboard/msi/ms7721/mptable.c M src/mainboard/packardbell/ms2290/mainboard.c M src/mainboard/samsung/lumpy/early_init.c M src/mainboard/samsung/stumpy/early_init.c M src/northbridge/amd/agesa/family14/northbridge.c M src/soc/amd/common/block/smbus/sm.c M src/soc/intel/braswell/northcluster.c M src/soc/intel/broadwell/smmrelocate.c M src/soc/intel/cannonlake/smmrelocate.c M src/soc/intel/icelake/smmrelocate.c M src/soc/intel/jasperlake/smmrelocate.c M src/soc/intel/skylake/smmrelocate.c M src/soc/intel/tigerlake/smmrelocate.c M src/soc/intel/xeon_sp/uncore.c M src/southbridge/amd/agesa/hudson/sm.c M src/southbridge/amd/pi/hudson/sm.c 47 files changed, 2 insertions(+), 47 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/41489/6
Hello build bot (Jenkins), Jonathan Zhang, Angel Pons, Alexander Couzens, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/41489
to look at the new patch set (#7).
Change subject: src: Remove unused '#include <cpu/x86/lapic.h>' ......................................................................
src: Remove unused '#include <cpu/x86/lapic.h>'
Change-Id: I71cff43d53660dc1e5a760ac3034bcf75f93c6e7 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/cpu/amd/smm/smm_init.c M src/cpu/intel/haswell/smmrelocate.c M src/cpu/intel/hyperthreading/intel_sibling.c M src/cpu/x86/mtrr/mtrr.c M src/mainboard/amd/gardenia/mptable.c M src/mainboard/amd/olivehill/mptable.c M src/mainboard/amd/parmer/mptable.c M src/mainboard/amd/thatcher/mptable.c M src/mainboard/asrock/imb-a180/mptable.c M src/mainboard/asus/am1i-a/mptable.c M src/mainboard/asus/f2a85-m/mptable.c M src/mainboard/bap/ode_e20XX/mptable.c M src/mainboard/bap/ode_e21XX/mptable.c M src/mainboard/bap/ode_e21XX/romstage.c M src/mainboard/biostar/a68n_5200/mptable.c M src/mainboard/biostar/am1ml/mptable.c M src/mainboard/gizmosphere/gizmo2/mptable.c M src/mainboard/google/butterfly/early_init.c M src/mainboard/google/kahlee/mptable.c M src/mainboard/google/link/early_init.c M src/mainboard/google/parrot/early_init.c M src/mainboard/google/stout/early_init.c M src/mainboard/hp/abm/mptable.c M src/mainboard/hp/pavilion_m6_1035dx/mptable.c M src/mainboard/intel/emeraldlake2/early_init.c M src/mainboard/kontron/ktqm77/early_init.c M src/mainboard/lenovo/g505s/mptable.c M src/mainboard/lenovo/x1_carbon_gen1/early_init.c M src/mainboard/lenovo/x201/mainboard.c M src/mainboard/lenovo/x220/early_init.c M src/mainboard/lenovo/x230/variants/x230/early_init.c M src/mainboard/msi/ms7721/mptable.c M src/mainboard/packardbell/ms2290/mainboard.c M src/mainboard/samsung/lumpy/early_init.c M src/mainboard/samsung/stumpy/early_init.c M src/northbridge/amd/agesa/family14/northbridge.c M src/soc/amd/common/block/smbus/sm.c M src/soc/intel/braswell/northcluster.c M src/soc/intel/broadwell/smmrelocate.c M src/soc/intel/cannonlake/smmrelocate.c M src/soc/intel/icelake/smmrelocate.c M src/soc/intel/jasperlake/smmrelocate.c M src/soc/intel/skylake/smmrelocate.c M src/soc/intel/tigerlake/smmrelocate.c M src/soc/intel/xeon_sp/uncore.c M src/southbridge/amd/agesa/hudson/sm.c M src/southbridge/amd/pi/hudson/sm.c 47 files changed, 2 insertions(+), 47 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/41489/7
Hello build bot (Jenkins), Jonathan Zhang, Angel Pons, Alexander Couzens, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/41489
to look at the new patch set (#9).
Change subject: src: Remove unused '#include <cpu/x86/lapic.h>' ......................................................................
src: Remove unused '#include <cpu/x86/lapic.h>'
Also, replace 'lapic.h' by 'lapic_def.h' in soc/intel/braswell/northcluster.c
Change-Id: I71cff43d53660dc1e5a760ac3034bcf75f93c6e7 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/cpu/amd/smm/smm_init.c M src/cpu/intel/haswell/smmrelocate.c M src/cpu/intel/hyperthreading/intel_sibling.c M src/cpu/x86/mtrr/mtrr.c M src/mainboard/amd/gardenia/mptable.c M src/mainboard/amd/olivehill/mptable.c M src/mainboard/amd/parmer/mptable.c M src/mainboard/amd/thatcher/mptable.c M src/mainboard/asrock/imb-a180/mptable.c M src/mainboard/asus/am1i-a/mptable.c M src/mainboard/asus/f2a85-m/mptable.c M src/mainboard/bap/ode_e20XX/mptable.c M src/mainboard/bap/ode_e21XX/mptable.c M src/mainboard/bap/ode_e21XX/romstage.c M src/mainboard/biostar/a68n_5200/mptable.c M src/mainboard/biostar/am1ml/mptable.c M src/mainboard/gizmosphere/gizmo2/mptable.c M src/mainboard/google/butterfly/early_init.c M src/mainboard/google/kahlee/mptable.c M src/mainboard/google/link/early_init.c M src/mainboard/google/parrot/early_init.c M src/mainboard/google/stout/early_init.c M src/mainboard/hp/abm/mptable.c M src/mainboard/hp/pavilion_m6_1035dx/mptable.c M src/mainboard/intel/emeraldlake2/early_init.c M src/mainboard/kontron/ktqm77/early_init.c M src/mainboard/lenovo/g505s/mptable.c M src/mainboard/lenovo/x1_carbon_gen1/early_init.c M src/mainboard/lenovo/x201/mainboard.c M src/mainboard/lenovo/x220/early_init.c M src/mainboard/lenovo/x230/variants/x230/early_init.c M src/mainboard/msi/ms7721/mptable.c M src/mainboard/packardbell/ms2290/mainboard.c M src/mainboard/samsung/lumpy/early_init.c M src/mainboard/samsung/stumpy/early_init.c M src/northbridge/amd/agesa/family14/northbridge.c M src/soc/amd/common/block/smbus/sm.c M src/soc/intel/braswell/northcluster.c M src/soc/intel/broadwell/smmrelocate.c M src/soc/intel/cannonlake/smmrelocate.c M src/soc/intel/icelake/smmrelocate.c M src/soc/intel/jasperlake/smmrelocate.c M src/soc/intel/skylake/smmrelocate.c M src/soc/intel/tigerlake/smmrelocate.c M src/soc/intel/xeon_sp/uncore.c M src/southbridge/amd/agesa/hudson/sm.c M src/southbridge/amd/pi/hudson/sm.c 47 files changed, 2 insertions(+), 47 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/41489/9
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41489 )
Change subject: src: Remove unused '#include <cpu/x86/lapic.h>' ......................................................................
Patch Set 10: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/41489/10//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/41489/10//COMMIT_MSG@9 PS10, Line 9: Also, replace 'lapic.h' by 'lapic_def.h' in soc/intel/braswell/northcluster.c Please add a dot/period at the end of that.
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41489 )
Change subject: src: Remove unused '#include <cpu/x86/lapic.h>' ......................................................................
Patch Set 10:
(1 comment)
Thanks
https://review.coreboot.org/c/coreboot/+/41489/10//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/41489/10//COMMIT_MSG@9 PS10, Line 9: Also, replace 'lapic.h' by 'lapic_def.h' in soc/intel/braswell/northcluster.c
Please add a dot/period at the end of that.
Done
Hello build bot (Jenkins), Jonathan Zhang, Paul Menzel, Angel Pons, Alexander Couzens, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/41489
to look at the new patch set (#11).
Change subject: src: Remove unused '#include <cpu/x86/lapic.h>' ......................................................................
src: Remove unused '#include <cpu/x86/lapic.h>'
Also, replace 'lapic.h' by 'lapic_def.h' in 'soc/intel/braswell/northcluster.c'.
Change-Id: I71cff43d53660dc1e5a760ac3034bcf75f93c6e7 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/cpu/amd/smm/smm_init.c M src/cpu/intel/haswell/smmrelocate.c M src/cpu/intel/hyperthreading/intel_sibling.c M src/cpu/x86/mtrr/mtrr.c M src/mainboard/amd/gardenia/mptable.c M src/mainboard/amd/olivehill/mptable.c M src/mainboard/amd/parmer/mptable.c M src/mainboard/amd/thatcher/mptable.c M src/mainboard/asrock/imb-a180/mptable.c M src/mainboard/asus/am1i-a/mptable.c M src/mainboard/asus/f2a85-m/mptable.c M src/mainboard/bap/ode_e20XX/mptable.c M src/mainboard/bap/ode_e21XX/mptable.c M src/mainboard/bap/ode_e21XX/romstage.c M src/mainboard/biostar/a68n_5200/mptable.c M src/mainboard/biostar/am1ml/mptable.c M src/mainboard/gizmosphere/gizmo2/mptable.c M src/mainboard/google/butterfly/early_init.c M src/mainboard/google/kahlee/mptable.c M src/mainboard/google/link/early_init.c M src/mainboard/google/parrot/early_init.c M src/mainboard/google/stout/early_init.c M src/mainboard/hp/abm/mptable.c M src/mainboard/hp/pavilion_m6_1035dx/mptable.c M src/mainboard/intel/emeraldlake2/early_init.c M src/mainboard/kontron/ktqm77/early_init.c M src/mainboard/lenovo/g505s/mptable.c M src/mainboard/lenovo/x1_carbon_gen1/early_init.c M src/mainboard/lenovo/x201/mainboard.c M src/mainboard/lenovo/x220/early_init.c M src/mainboard/lenovo/x230/variants/x230/early_init.c M src/mainboard/msi/ms7721/mptable.c M src/mainboard/packardbell/ms2290/mainboard.c M src/mainboard/samsung/lumpy/early_init.c M src/mainboard/samsung/stumpy/early_init.c M src/northbridge/amd/agesa/family14/northbridge.c M src/soc/amd/common/block/smbus/sm.c M src/soc/intel/braswell/northcluster.c M src/soc/intel/broadwell/smmrelocate.c M src/soc/intel/cannonlake/smmrelocate.c M src/soc/intel/icelake/smmrelocate.c M src/soc/intel/jasperlake/smmrelocate.c M src/soc/intel/skylake/smmrelocate.c M src/soc/intel/tigerlake/smmrelocate.c M src/soc/intel/xeon_sp/uncore.c M src/southbridge/amd/agesa/hudson/sm.c M src/southbridge/amd/pi/hudson/sm.c 47 files changed, 2 insertions(+), 47 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/41489/11
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41489 )
Change subject: src: Remove unused '#include <cpu/x86/lapic.h>' ......................................................................
Patch Set 11: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/41489 )
Change subject: src: Remove unused '#include <cpu/x86/lapic.h>' ......................................................................
src: Remove unused '#include <cpu/x86/lapic.h>'
Also, replace 'lapic.h' by 'lapic_def.h' in 'soc/intel/braswell/northcluster.c'.
Change-Id: I71cff43d53660dc1e5a760ac3034bcf75f93c6e7 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/41489 Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/cpu/amd/smm/smm_init.c M src/cpu/intel/haswell/smmrelocate.c M src/cpu/intel/hyperthreading/intel_sibling.c M src/cpu/x86/mtrr/mtrr.c M src/mainboard/amd/gardenia/mptable.c M src/mainboard/amd/olivehill/mptable.c M src/mainboard/amd/parmer/mptable.c M src/mainboard/amd/thatcher/mptable.c M src/mainboard/asrock/imb-a180/mptable.c M src/mainboard/asus/am1i-a/mptable.c M src/mainboard/asus/f2a85-m/mptable.c M src/mainboard/bap/ode_e20XX/mptable.c M src/mainboard/bap/ode_e21XX/mptable.c M src/mainboard/bap/ode_e21XX/romstage.c M src/mainboard/biostar/a68n_5200/mptable.c M src/mainboard/biostar/am1ml/mptable.c M src/mainboard/gizmosphere/gizmo2/mptable.c M src/mainboard/google/butterfly/early_init.c M src/mainboard/google/kahlee/mptable.c M src/mainboard/google/link/early_init.c M src/mainboard/google/parrot/early_init.c M src/mainboard/google/stout/early_init.c M src/mainboard/hp/abm/mptable.c M src/mainboard/hp/pavilion_m6_1035dx/mptable.c M src/mainboard/intel/emeraldlake2/early_init.c M src/mainboard/kontron/ktqm77/early_init.c M src/mainboard/lenovo/g505s/mptable.c M src/mainboard/lenovo/x1_carbon_gen1/early_init.c M src/mainboard/lenovo/x201/mainboard.c M src/mainboard/lenovo/x220/early_init.c M src/mainboard/lenovo/x230/variants/x230/early_init.c M src/mainboard/msi/ms7721/mptable.c M src/mainboard/packardbell/ms2290/mainboard.c M src/mainboard/samsung/lumpy/early_init.c M src/mainboard/samsung/stumpy/early_init.c M src/northbridge/amd/agesa/family14/northbridge.c M src/soc/amd/common/block/smbus/sm.c M src/soc/intel/braswell/northcluster.c M src/soc/intel/broadwell/smmrelocate.c M src/soc/intel/cannonlake/smmrelocate.c M src/soc/intel/icelake/smmrelocate.c M src/soc/intel/jasperlake/smmrelocate.c M src/soc/intel/skylake/smmrelocate.c M src/soc/intel/tigerlake/smmrelocate.c M src/soc/intel/xeon_sp/uncore.c M src/southbridge/amd/agesa/hudson/sm.c M src/southbridge/amd/pi/hudson/sm.c 47 files changed, 2 insertions(+), 47 deletions(-)
Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Angel Pons: Looks good to me, approved
diff --git a/src/cpu/amd/smm/smm_init.c b/src/cpu/amd/smm/smm_init.c index 0de8fba..71cca82 100644 --- a/src/cpu/amd/smm/smm_init.c +++ b/src/cpu/amd/smm/smm_init.c @@ -1,6 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-#include <cpu/x86/lapic.h> #include <cpu/x86/msr.h> #include <cpu/x86/mtrr.h> #include <cpu/amd/mtrr.h> diff --git a/src/cpu/intel/haswell/smmrelocate.c b/src/cpu/intel/haswell/smmrelocate.c index 1c96188..0f7585a 100644 --- a/src/cpu/intel/haswell/smmrelocate.c +++ b/src/cpu/intel/haswell/smmrelocate.c @@ -5,7 +5,6 @@ #include <device/device.h> #include <device/pci.h> #include <device/pci_ops.h> -#include <cpu/x86/lapic.h> #include <cpu/x86/mp.h> #include <cpu/x86/msr.h> #include <cpu/x86/mtrr.h> diff --git a/src/cpu/intel/hyperthreading/intel_sibling.c b/src/cpu/intel/hyperthreading/intel_sibling.c index 9febc83..329b693 100644 --- a/src/cpu/intel/hyperthreading/intel_sibling.c +++ b/src/cpu/intel/hyperthreading/intel_sibling.c @@ -1,7 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */
#include <console/console.h> -#include <cpu/x86/lapic.h> #include <cpu/intel/hyperthreading.h> #include <device/device.h> #include <option.h> diff --git a/src/cpu/x86/mtrr/mtrr.c b/src/cpu/x86/mtrr/mtrr.c index 6187578..1f37659 100644 --- a/src/cpu/x86/mtrr/mtrr.c +++ b/src/cpu/x86/mtrr/mtrr.c @@ -19,7 +19,6 @@ #include <cpu/x86/msr.h> #include <cpu/x86/mtrr.h> #include <cpu/x86/cache.h> -#include <cpu/x86/lapic.h> #include <memrange.h> #include <cpu/amd/mtrr.h> #include <assert.h> diff --git a/src/mainboard/amd/gardenia/mptable.c b/src/mainboard/amd/gardenia/mptable.c index 3528a13..6460fed 100644 --- a/src/mainboard/amd/gardenia/mptable.c +++ b/src/mainboard/amd/gardenia/mptable.c @@ -4,7 +4,6 @@ #include <arch/ioapic.h> #include <string.h> #include <stdint.h> -#include <cpu/x86/lapic.h> #include <soc/southbridge.h> #include <amdblocks/amd_pci_util.h>
diff --git a/src/mainboard/amd/olivehill/mptable.c b/src/mainboard/amd/olivehill/mptable.c index ab321c0..4761728 100644 --- a/src/mainboard/amd/olivehill/mptable.c +++ b/src/mainboard/amd/olivehill/mptable.c @@ -5,7 +5,6 @@ #include <arch/ioapic.h> #include <string.h> #include <stdint.h> -#include <cpu/x86/lapic.h> #include <southbridge/amd/agesa/hudson/hudson.h>
u8 picr_data[0x54] = { diff --git a/src/mainboard/amd/parmer/mptable.c b/src/mainboard/amd/parmer/mptable.c index 28866e8..c7aa69e 100644 --- a/src/mainboard/amd/parmer/mptable.c +++ b/src/mainboard/amd/parmer/mptable.c @@ -5,7 +5,6 @@ #include <arch/ioapic.h> #include <string.h> #include <stdint.h> -#include <cpu/x86/lapic.h> #include <southbridge/amd/agesa/hudson/hudson.h>
u8 picr_data[0x54] = { diff --git a/src/mainboard/amd/thatcher/mptable.c b/src/mainboard/amd/thatcher/mptable.c index 8b8bc03..bc091e5 100644 --- a/src/mainboard/amd/thatcher/mptable.c +++ b/src/mainboard/amd/thatcher/mptable.c @@ -5,7 +5,6 @@ #include <arch/ioapic.h> #include <string.h> #include <stdint.h> -#include <cpu/x86/lapic.h> #include <southbridge/amd/agesa/hudson/hudson.h>
u8 picr_data[] = { diff --git a/src/mainboard/asrock/imb-a180/mptable.c b/src/mainboard/asrock/imb-a180/mptable.c index 2a35eb9..20c4b8d 100644 --- a/src/mainboard/asrock/imb-a180/mptable.c +++ b/src/mainboard/asrock/imb-a180/mptable.c @@ -5,7 +5,6 @@ #include <arch/ioapic.h> #include <string.h> #include <stdint.h> -#include <cpu/x86/lapic.h> #include <southbridge/amd/agesa/hudson/hudson.h>
diff --git a/src/mainboard/asus/am1i-a/mptable.c b/src/mainboard/asus/am1i-a/mptable.c index 5caa783..cd72ca3 100644 --- a/src/mainboard/asus/am1i-a/mptable.c +++ b/src/mainboard/asus/am1i-a/mptable.c @@ -3,7 +3,6 @@ #include <arch/smp/mpspec.h> #include <arch/ioapic.h> #include <stdint.h> -#include <cpu/x86/lapic.h> #include <southbridge/amd/common/amd_pci_util.h> #include <drivers/generic/ioapic/chip.h>
diff --git a/src/mainboard/asus/f2a85-m/mptable.c b/src/mainboard/asus/f2a85-m/mptable.c index 7d9dcc3..e3c7d80 100644 --- a/src/mainboard/asus/f2a85-m/mptable.c +++ b/src/mainboard/asus/f2a85-m/mptable.c @@ -3,7 +3,6 @@ #include <arch/io.h> #include <arch/ioapic.h> #include <arch/smp/mpspec.h> -#include <cpu/x86/lapic.h> #include <stdint.h> #include <string.h> #include <southbridge/amd/agesa/hudson/hudson.h> diff --git a/src/mainboard/bap/ode_e20XX/mptable.c b/src/mainboard/bap/ode_e20XX/mptable.c index b854b75..c0ad4ed 100644 --- a/src/mainboard/bap/ode_e20XX/mptable.c +++ b/src/mainboard/bap/ode_e20XX/mptable.c @@ -3,7 +3,6 @@ #include <arch/smp/mpspec.h> #include <arch/ioapic.h> #include <stdint.h> -#include <cpu/x86/lapic.h> #include <southbridge/amd/common/amd_pci_util.h> #include <drivers/generic/ioapic/chip.h>
diff --git a/src/mainboard/bap/ode_e21XX/mptable.c b/src/mainboard/bap/ode_e21XX/mptable.c index 0d8c942..c5aeeb0 100644 --- a/src/mainboard/bap/ode_e21XX/mptable.c +++ b/src/mainboard/bap/ode_e21XX/mptable.c @@ -5,7 +5,6 @@ #include <arch/ioapic.h> #include <string.h> #include <stdint.h> -#include <cpu/x86/lapic.h> #include <southbridge/amd/pi/hudson/hudson.h>
u8 picr_data[0x54] = { diff --git a/src/mainboard/bap/ode_e21XX/romstage.c b/src/mainboard/bap/ode_e21XX/romstage.c index 74b8517..6b116fd 100644 --- a/src/mainboard/bap/ode_e21XX/romstage.c +++ b/src/mainboard/bap/ode_e21XX/romstage.c @@ -5,7 +5,6 @@ #include <device/pci_def.h> #include <arch/io.h> #include <arch/cpu.h> -#include <cpu/x86/lapic.h> #include <console/console.h> #include <northbridge/amd/agesa/state_machine.h> #include <southbridge/amd/pi/hudson/hudson.h> diff --git a/src/mainboard/biostar/a68n_5200/mptable.c b/src/mainboard/biostar/a68n_5200/mptable.c index ab321c0..4761728 100644 --- a/src/mainboard/biostar/a68n_5200/mptable.c +++ b/src/mainboard/biostar/a68n_5200/mptable.c @@ -5,7 +5,6 @@ #include <arch/ioapic.h> #include <string.h> #include <stdint.h> -#include <cpu/x86/lapic.h> #include <southbridge/amd/agesa/hudson/hudson.h>
u8 picr_data[0x54] = { diff --git a/src/mainboard/biostar/am1ml/mptable.c b/src/mainboard/biostar/am1ml/mptable.c index 7a02800..41e70b9 100644 --- a/src/mainboard/biostar/am1ml/mptable.c +++ b/src/mainboard/biostar/am1ml/mptable.c @@ -3,7 +3,6 @@ #include <arch/smp/mpspec.h> #include <arch/ioapic.h> #include <stdint.h> -#include <cpu/x86/lapic.h> #include <southbridge/amd/common/amd_pci_util.h> #include <drivers/generic/ioapic/chip.h>
diff --git a/src/mainboard/gizmosphere/gizmo2/mptable.c b/src/mainboard/gizmosphere/gizmo2/mptable.c index b854b75..c0ad4ed 100644 --- a/src/mainboard/gizmosphere/gizmo2/mptable.c +++ b/src/mainboard/gizmosphere/gizmo2/mptable.c @@ -3,7 +3,6 @@ #include <arch/smp/mpspec.h> #include <arch/ioapic.h> #include <stdint.h> -#include <cpu/x86/lapic.h> #include <southbridge/amd/common/amd_pci_util.h> #include <drivers/generic/ioapic/chip.h>
diff --git a/src/mainboard/google/butterfly/early_init.c b/src/mainboard/google/butterfly/early_init.c index 21d59d1..df51f66 100644 --- a/src/mainboard/google/butterfly/early_init.c +++ b/src/mainboard/google/butterfly/early_init.c @@ -1,7 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */
#include <stdint.h> -#include <cpu/x86/lapic.h> #include <acpi/acpi.h> #include <northbridge/intel/sandybridge/sandybridge.h> #include <northbridge/intel/sandybridge/raminit.h> diff --git a/src/mainboard/google/kahlee/mptable.c b/src/mainboard/google/kahlee/mptable.c index 3528a13..6460fed 100644 --- a/src/mainboard/google/kahlee/mptable.c +++ b/src/mainboard/google/kahlee/mptable.c @@ -4,7 +4,6 @@ #include <arch/ioapic.h> #include <string.h> #include <stdint.h> -#include <cpu/x86/lapic.h> #include <soc/southbridge.h> #include <amdblocks/amd_pci_util.h>
diff --git a/src/mainboard/google/link/early_init.c b/src/mainboard/google/link/early_init.c index 27f086c..8360f2a 100644 --- a/src/mainboard/google/link/early_init.c +++ b/src/mainboard/google/link/early_init.c @@ -3,7 +3,6 @@ #include <stdint.h> #include <string.h> #include <device/pci_ops.h> -#include <cpu/x86/lapic.h> #include <acpi/acpi.h> #include <console/console.h> #include <northbridge/intel/sandybridge/sandybridge.h> diff --git a/src/mainboard/google/parrot/early_init.c b/src/mainboard/google/parrot/early_init.c index cff8438..3c5c363 100644 --- a/src/mainboard/google/parrot/early_init.c +++ b/src/mainboard/google/parrot/early_init.c @@ -1,7 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */
#include <stdint.h> -#include <cpu/x86/lapic.h> #include <acpi/acpi.h> #include <northbridge/intel/sandybridge/sandybridge.h> #include <northbridge/intel/sandybridge/raminit.h> diff --git a/src/mainboard/google/stout/early_init.c b/src/mainboard/google/stout/early_init.c index 1b73fc0..e71d0ee 100644 --- a/src/mainboard/google/stout/early_init.c +++ b/src/mainboard/google/stout/early_init.c @@ -1,7 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */
#include <stdint.h> -#include <cpu/x86/lapic.h> #include <acpi/acpi.h> #include <console/console.h> #include <northbridge/intel/sandybridge/sandybridge.h> diff --git a/src/mainboard/hp/abm/mptable.c b/src/mainboard/hp/abm/mptable.c index ab321c0..4761728 100644 --- a/src/mainboard/hp/abm/mptable.c +++ b/src/mainboard/hp/abm/mptable.c @@ -5,7 +5,6 @@ #include <arch/ioapic.h> #include <string.h> #include <stdint.h> -#include <cpu/x86/lapic.h> #include <southbridge/amd/agesa/hudson/hudson.h>
u8 picr_data[0x54] = { diff --git a/src/mainboard/hp/pavilion_m6_1035dx/mptable.c b/src/mainboard/hp/pavilion_m6_1035dx/mptable.c index 4433c71..c620be2 100644 --- a/src/mainboard/hp/pavilion_m6_1035dx/mptable.c +++ b/src/mainboard/hp/pavilion_m6_1035dx/mptable.c @@ -3,7 +3,6 @@ #include <arch/io.h> #include <arch/ioapic.h> #include <arch/smp/mpspec.h> -#include <cpu/x86/lapic.h> #include <stdint.h> #include <string.h> #include <southbridge/amd/agesa/hudson/hudson.h> diff --git a/src/mainboard/intel/emeraldlake2/early_init.c b/src/mainboard/intel/emeraldlake2/early_init.c index 6e1f7e3..119346e 100644 --- a/src/mainboard/intel/emeraldlake2/early_init.c +++ b/src/mainboard/intel/emeraldlake2/early_init.c @@ -3,7 +3,6 @@ #include <bootblock_common.h> #include <stdint.h> #include <arch/io.h> -#include <cpu/x86/lapic.h> #include <superio/smsc/sio1007/sio1007.h> #include <northbridge/intel/sandybridge/sandybridge.h> #include <northbridge/intel/sandybridge/raminit.h> diff --git a/src/mainboard/kontron/ktqm77/early_init.c b/src/mainboard/kontron/ktqm77/early_init.c index 31eb05b..b8f44b5 100644 --- a/src/mainboard/kontron/ktqm77/early_init.c +++ b/src/mainboard/kontron/ktqm77/early_init.c @@ -4,7 +4,6 @@ #include <stdint.h> #include <device/pnp_ops.h> #include <device/pci_ops.h> -#include <cpu/x86/lapic.h> #include <cpu/x86/msr.h> #include <device/pci_def.h> #include <northbridge/intel/sandybridge/raminit_native.h> diff --git a/src/mainboard/lenovo/g505s/mptable.c b/src/mainboard/lenovo/g505s/mptable.c index 19ac198..bc1759a 100644 --- a/src/mainboard/lenovo/g505s/mptable.c +++ b/src/mainboard/lenovo/g505s/mptable.c @@ -3,7 +3,6 @@ #include <arch/io.h> #include <arch/ioapic.h> #include <arch/smp/mpspec.h> -#include <cpu/x86/lapic.h> #include <stdint.h> #include <string.h> #include <southbridge/amd/agesa/hudson/hudson.h> diff --git a/src/mainboard/lenovo/x1_carbon_gen1/early_init.c b/src/mainboard/lenovo/x1_carbon_gen1/early_init.c index a709450..f5299ea 100644 --- a/src/mainboard/lenovo/x1_carbon_gen1/early_init.c +++ b/src/mainboard/lenovo/x1_carbon_gen1/early_init.c @@ -2,7 +2,6 @@
#include <stdint.h> #include <string.h> -#include <cpu/x86/lapic.h> #include <console/console.h> #include <northbridge/intel/sandybridge/sandybridge.h> #include <northbridge/intel/sandybridge/raminit_native.h> diff --git a/src/mainboard/lenovo/x201/mainboard.c b/src/mainboard/lenovo/x201/mainboard.c index beb9938..1a306b1 100644 --- a/src/mainboard/lenovo/x201/mainboard.c +++ b/src/mainboard/lenovo/x201/mainboard.c @@ -6,7 +6,6 @@ #include <southbridge/intel/bd82x6x/pch.h> #include "dock.h" #include <drivers/intel/gma/int15.h> -#include <cpu/x86/lapic.h> #include <drivers/lenovo/lenovo.h>
static void fill_ssdt(const struct device *device) diff --git a/src/mainboard/lenovo/x220/early_init.c b/src/mainboard/lenovo/x220/early_init.c index f87a9d4..5f0ad45 100644 --- a/src/mainboard/lenovo/x220/early_init.c +++ b/src/mainboard/lenovo/x220/early_init.c @@ -1,7 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */
#include <stdint.h> -#include <cpu/x86/lapic.h> #include <acpi/acpi.h> #include <northbridge/intel/sandybridge/sandybridge.h> #include <northbridge/intel/sandybridge/raminit.h> diff --git a/src/mainboard/lenovo/x230/variants/x230/early_init.c b/src/mainboard/lenovo/x230/variants/x230/early_init.c index 2089ee6..e6c4ffa 100644 --- a/src/mainboard/lenovo/x230/variants/x230/early_init.c +++ b/src/mainboard/lenovo/x230/variants/x230/early_init.c @@ -1,6 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-#include <cpu/x86/lapic.h> #include <northbridge/intel/sandybridge/sandybridge.h> #include <northbridge/intel/sandybridge/raminit_native.h> #include <southbridge/intel/bd82x6x/pch.h> diff --git a/src/mainboard/msi/ms7721/mptable.c b/src/mainboard/msi/ms7721/mptable.c index 7d9dcc3..e3c7d80 100644 --- a/src/mainboard/msi/ms7721/mptable.c +++ b/src/mainboard/msi/ms7721/mptable.c @@ -3,7 +3,6 @@ #include <arch/io.h> #include <arch/ioapic.h> #include <arch/smp/mpspec.h> -#include <cpu/x86/lapic.h> #include <stdint.h> #include <string.h> #include <southbridge/amd/agesa/hudson/hudson.h> diff --git a/src/mainboard/packardbell/ms2290/mainboard.c b/src/mainboard/packardbell/ms2290/mainboard.c index 6df8fad..ce8d504 100644 --- a/src/mainboard/packardbell/ms2290/mainboard.c +++ b/src/mainboard/packardbell/ms2290/mainboard.c @@ -7,7 +7,6 @@ #include <ec/acpi/ec.h> #include <drivers/intel/gma/int15.h> #include <pc80/keyboard.h> -#include <cpu/x86/lapic.h>
static void mainboard_enable(struct device *dev) { diff --git a/src/mainboard/samsung/lumpy/early_init.c b/src/mainboard/samsung/lumpy/early_init.c index 23309ba..091cbc5 100644 --- a/src/mainboard/samsung/lumpy/early_init.c +++ b/src/mainboard/samsung/lumpy/early_init.c @@ -4,7 +4,6 @@ #include <string.h> #include <arch/io.h> #include <bootblock_common.h> -#include <cpu/x86/lapic.h> #include <cbfs.h> #include <console/console.h> #include <bootmode.h> diff --git a/src/mainboard/samsung/stumpy/early_init.c b/src/mainboard/samsung/stumpy/early_init.c index 6636a6b..f079482 100644 --- a/src/mainboard/samsung/stumpy/early_init.c +++ b/src/mainboard/samsung/stumpy/early_init.c @@ -2,7 +2,6 @@
#include <bootblock_common.h> #include <stdint.h> -#include <cpu/x86/lapic.h> #include <pc80/mc146818rtc.h> #include <console/console.h> #include <bootmode.h> diff --git a/src/northbridge/amd/agesa/family14/northbridge.c b/src/northbridge/amd/agesa/family14/northbridge.c index 34fc0c0..7c5ecdc 100644 --- a/src/northbridge/amd/agesa/family14/northbridge.c +++ b/src/northbridge/amd/agesa/family14/northbridge.c @@ -12,7 +12,6 @@ #include <string.h> #include <lib.h> #include <cpu/cpu.h> -#include <cpu/x86/lapic.h> #include <cpu/amd/msr.h> #include <cpu/amd/mtrr.h> #include <northbridge/amd/agesa/nb_common.h> diff --git a/src/soc/amd/common/block/smbus/sm.c b/src/soc/amd/common/block/smbus/sm.c index 2f37a91..5a4edd8 100644 --- a/src/soc/amd/common/block/smbus/sm.c +++ b/src/soc/amd/common/block/smbus/sm.c @@ -6,7 +6,6 @@ #include <device/pci_ids.h> #include <device/smbus.h> #include <device/smbus_host.h> -#include <cpu/x86/lapic.h> #include <arch/ioapic.h> #include <soc/southbridge.h>
diff --git a/src/soc/intel/braswell/northcluster.c b/src/soc/intel/braswell/northcluster.c index 94b91cc..dd49acd 100644 --- a/src/soc/intel/braswell/northcluster.c +++ b/src/soc/intel/braswell/northcluster.c @@ -6,7 +6,7 @@ #include <device/device.h> #include <device/pci.h> #include <device/pci_ids.h> -#include <cpu/x86/lapic.h> +#include <cpu/x86/lapic_def.h> #include <cpu/x86/smm.h> #include <fsp/util.h> #include <soc/iomap.h> diff --git a/src/soc/intel/broadwell/smmrelocate.c b/src/soc/intel/broadwell/smmrelocate.c index 660a688..03ed244 100644 --- a/src/soc/intel/broadwell/smmrelocate.c +++ b/src/soc/intel/broadwell/smmrelocate.c @@ -5,7 +5,6 @@ #include <device/device.h> #include <device/pci.h> #include <device/pci_ops.h> -#include <cpu/x86/lapic.h> #include <cpu/x86/mp.h> #include <cpu/x86/msr.h> #include <cpu/x86/mtrr.h> diff --git a/src/soc/intel/cannonlake/smmrelocate.c b/src/soc/intel/cannonlake/smmrelocate.c index dcf67bc..3aec51b 100644 --- a/src/soc/intel/cannonlake/smmrelocate.c +++ b/src/soc/intel/cannonlake/smmrelocate.c @@ -5,7 +5,6 @@ #include <device/device.h> #include <device/pci.h> #include <device/pci_ops.h> -#include <cpu/x86/lapic.h> #include <cpu/x86/mp.h> #include <cpu/x86/msr.h> #include <cpu/x86/mtrr.h> diff --git a/src/soc/intel/icelake/smmrelocate.c b/src/soc/intel/icelake/smmrelocate.c index d9ca915..f1a7033 100644 --- a/src/soc/intel/icelake/smmrelocate.c +++ b/src/soc/intel/icelake/smmrelocate.c @@ -5,7 +5,6 @@ #include <device/device.h> #include <device/pci.h> #include <device/pci_ops.h> -#include <cpu/x86/lapic.h> #include <cpu/x86/mp.h> #include <cpu/x86/msr.h> #include <cpu/x86/mtrr.h> diff --git a/src/soc/intel/jasperlake/smmrelocate.c b/src/soc/intel/jasperlake/smmrelocate.c index af16fbd..664ea6c 100644 --- a/src/soc/intel/jasperlake/smmrelocate.c +++ b/src/soc/intel/jasperlake/smmrelocate.c @@ -5,7 +5,6 @@ #include <device/device.h> #include <device/pci.h> #include <device/pci_ops.h> -#include <cpu/x86/lapic.h> #include <cpu/x86/mp.h> #include <cpu/x86/msr.h> #include <cpu/x86/mtrr.h> diff --git a/src/soc/intel/skylake/smmrelocate.c b/src/soc/intel/skylake/smmrelocate.c index e45da91..cb83d61 100644 --- a/src/soc/intel/skylake/smmrelocate.c +++ b/src/soc/intel/skylake/smmrelocate.c @@ -5,7 +5,6 @@ #include <device/device.h> #include <device/pci.h> #include <device/pci_ops.h> -#include <cpu/x86/lapic.h> #include <cpu/x86/mp.h> #include <cpu/x86/msr.h> #include <cpu/x86/mtrr.h> diff --git a/src/soc/intel/tigerlake/smmrelocate.c b/src/soc/intel/tigerlake/smmrelocate.c index af16fbd..664ea6c 100644 --- a/src/soc/intel/tigerlake/smmrelocate.c +++ b/src/soc/intel/tigerlake/smmrelocate.c @@ -5,7 +5,6 @@ #include <device/device.h> #include <device/pci.h> #include <device/pci_ops.h> -#include <cpu/x86/lapic.h> #include <cpu/x86/mp.h> #include <cpu/x86/msr.h> #include <cpu/x86/mtrr.h> diff --git a/src/soc/intel/xeon_sp/uncore.c b/src/soc/intel/xeon_sp/uncore.c index 1d46e40..a549acb 100644 --- a/src/soc/intel/xeon_sp/uncore.c +++ b/src/soc/intel/xeon_sp/uncore.c @@ -2,7 +2,7 @@
#include <cbmem.h> #include <console/console.h> -#include <cpu/x86/lapic.h> +#include <cpu/x86/lapic_def.h> #include <device/pci.h> #include <device/pci_ids.h> #include <soc/iomap.h> diff --git a/src/southbridge/amd/agesa/hudson/sm.c b/src/southbridge/amd/agesa/hudson/sm.c index 9f14908..39e6752 100644 --- a/src/southbridge/amd/agesa/hudson/sm.c +++ b/src/southbridge/amd/agesa/hudson/sm.c @@ -4,7 +4,6 @@ #include <device/pci.h> #include <device/pci_ids.h> #include <device/smbus.h> -#include <cpu/x86/lapic.h> #include <arch/ioapic.h>
#include "hudson.h" diff --git a/src/southbridge/amd/pi/hudson/sm.c b/src/southbridge/amd/pi/hudson/sm.c index ee30b7f..268d7e4 100644 --- a/src/southbridge/amd/pi/hudson/sm.c +++ b/src/southbridge/amd/pi/hudson/sm.c @@ -4,7 +4,6 @@ #include <device/pci.h> #include <device/pci_ids.h> #include <device/smbus.h> -#include <cpu/x86/lapic.h> #include <arch/ioapic.h>
#include "hudson.h"
9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41489 )
Change subject: src: Remove unused '#include <cpu/x86/lapic.h>' ......................................................................
Patch Set 12:
Automatic boot test returned (PASS/FAIL/TOTAL): 4/0/4 Emulation targets: "QEMU x86 q35/ich9" using payload TianoCore : SUCCESS : https://lava.9esec.io/r/4564 "QEMU x86 q35/ich9" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/4563 "QEMU x86 i440fx/piix4" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/4562 "QEMU AArch64" using payload LinuxBoot_u-root_kexec : SUCCESS : https://lava.9esec.io/r/4561
Please note: This test is under development and might not be accurate at all!
-
9elements QA (Code Review) -
Angel Pons (Code Review)
-
HAOUAS Elyes (Code Review)
-
Patrick Georgi (Code Review)
-
Paul Menzel (Code Review)