Attention is currently required from: CoolStar, Martin L Roth, Matt DeVillier, Matt DeVillier, Paul Menzel.
Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/77628?usp=email )
Change subject: device/pci_rom: Set VBIOS checksum when filling VFCT table
......................................................................
Patch Set 4:
(1 comment)
File src/device/pci_rom.c:
https://review.coreboot.org/c/coreboot/+/77628/comment/19c82aa8_0f572759 :
PS4, Line 255: header->VbiosContent[VFCT_VBIOS_CHECKSUM_OFFSET] = 0;
because the checksum will otherwise be incorrect, since it's just an inverted sum of the values
I see but not all the code clear the data first. Do we need fix? Is write_le8 the right way?
https://source.chromium.org/search?q=acpi_checksum&ss=chromiumos%2Fchrom...
--
To view, visit
https://review.coreboot.org/c/coreboot/+/77628?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I809f87865fd2a25fb106444574b619746aec068d
Gerrit-Change-Number: 77628
Gerrit-PatchSet: 4
Gerrit-Owner: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: CoolStar
coolstarorganization@gmail.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-CC: Martin L Roth
gaumless@gmail.com
Gerrit-CC: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: CoolStar
coolstarorganization@gmail.com
Gerrit-Comment-Date: Tue, 05 Sep 2023 14:19:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Matt DeVillier
matt.devillier@gmail.com
Comment-In-Reply-To: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-MessageType: comment