Change in coreboot[master]: soc/intel/common/block: Update SA resource length to support 64 bit

[Subrata Banik (Code Review)]

Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/40336 )

Change subject: soc/intel/common/block: Update SA resource length to support 64 bit
......................................................................

soc/intel/common/block: Update SA resource length to support 64 bit

This patch provides an option for accommodating 64 bit width resource
request.

Change-Id: I9a8448af7e9f26c8e0176e58e4fe253a6e77b69a
Signed-off-by: Subrata Banik 
---
M src/soc/intel/common/block/include/intelblocks/systemagent.h
1 file changed, 2 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/40336/1

diff --git a/src/soc/intel/common/block/include/intelblocks/systemagent.h b/src/soc/intel/common/block/include/intelblocks/systemagent.h
index c6aa4b4..04028b5 100644
--- a/src/soc/intel/common/block/include/intelblocks/systemagent.h
+++ b/src/soc/intel/common/block/include/intelblocks/systemagent.h
@@ -32,13 +32,13 @@
  *   INDEX = Either PCI configuration space registers or MMIO offsets
  *   mapped from REG.
  *   BASE = 64 bit Address.
- *   SIZE = base length
+ *   SIZE = 64 bit base length
  *   DESCRIPTION = Name of the register/offset.
  */
 struct sa_mmio_descriptor {
    unsigned int index;
    uint64_t base;
-	size_t size;
+	uint64_t size;
    const char *description;
 };

[Pratikkumar V Prajapati (Code Review)]

Pratikkumar V Prajapati has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40336 )

Change subject: soc/intel/common/block: Update SA resource length to support 64 bit
......................................................................

Patch Set 3: Code-Review+1

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40336 )

Change subject: soc/intel/common/block: Update SA resource length to support 64 bit
......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/c/coreboot/+/40336/4//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/40336/4//COMMIT_MSG@9 
PS4, Line 9: his patch provides an option for accommodating 64 bit width resource
           : request.
Can you please add the motivation for doing this as well?

[Subrata Banik (Code Review)]

Hello build bot (Jenkins), Furquan Shaikh, Duncan Laurie, Usha P, Pratikkumar V Prajapati, Aaron Durbin, Patrick Rudolph,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/40336

to look at the new patch set (#5).

Change subject: soc/intel/common/block: Update SA resource length to support 64 bit
......................................................................

soc/intel/common/block: Update SA resource length to support 64 bit

This patch provides an option for accommodating 64 bit width resource
request with PCIEX BAR length 4096MB (Bus 0-4095).

Change-Id: I9a8448af7e9f26c8e0176e58e4fe253a6e77b69a
Signed-off-by: Subrata Banik 
---
M src/soc/intel/common/block/include/intelblocks/systemagent.h
1 file changed, 2 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/40336/5

[Subrata Banik (Code Review)]

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40336 )

Change subject: soc/intel/common/block: Update SA resource length to support 64 bit
......................................................................

Patch Set 5:

(1 comment)

https://review.coreboot.org/c/coreboot/+/40336/4//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/40336/4//COMMIT_MSG@9 
PS4, Line 9: his patch provides an option for accommodating 64 bit width resource
           : request.
> Can you please add the motivation for doing this as well?

Added.

[Lean Sheng Tan (Code Review)]

Lean Sheng Tan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40336 )

Change subject: soc/intel/common/block: Update SA resource length to support 64 bit
......................................................................

Patch Set 5: Code-Review+1

[Subrata Banik (Code Review)]

Hello build bot (Jenkins), Furquan Shaikh, Duncan Laurie, Lean Sheng Tan, Usha P, Pratikkumar V Prajapati, Aaron Durbin, Patrick Rudolph,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/40336

to look at the new patch set (#6).

Change subject: soc/intel/common/block: Update SA resource length to support 64 bit
......................................................................

soc/intel/common/block: Update SA resource length to support 64 bit

This patch provides an option for accommodating 64 bit width resource
request with CONFIG_PCI_SEGMENT_GROUPS = 16 refer as PCIEX BAR length 4096MB
(Bus 0-4095).

Change-Id: I9a8448af7e9f26c8e0176e58e4fe253a6e77b69a
Signed-off-by: Subrata Banik 
---
M src/soc/intel/common/block/include/intelblocks/systemagent.h
1 file changed, 2 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/40336/6

[Lean Sheng Tan (Code Review)]

Lean Sheng Tan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40336 )

Change subject: soc/intel/common/block: Update SA resource length to support 64 bit
......................................................................

Patch Set 6: Code-Review+1

[Wonkyu Kim (Code Review)]

Wonkyu Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40336 )

Change subject: soc/intel/common/block: Update SA resource length to support 64 bit
......................................................................

Patch Set 8: Code-Review+1

[Aaron Durbin (Code Review)]

Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40336 )

Change subject: soc/intel/common/block: Update SA resource length to support 64 bit
......................................................................

Patch Set 8: Code-Review+2

[Subrata Banik (Code Review)]

Subrata Banik has submitted this change. ( https://review.coreboot.org/c/coreboot/+/40336 )

Change subject: soc/intel/common/block: Update SA resource length to support 64 bit
......................................................................

soc/intel/common/block: Update SA resource length to support 64 bit

This patch provides an option for accommodating 64 bit width resource
request with CONFIG_PCI_SEGMENT_GROUPS = 16 refer as PCIEX BAR length 4096MB
(Bus 0-4095).

Change-Id: I9a8448af7e9f26c8e0176e58e4fe253a6e77b69a
Signed-off-by: Subrata Banik 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/40336
Reviewed-by: Wonkyu Kim 
Reviewed-by: Aaron Durbin 
Reviewed-by: Lean Sheng Tan 
Tested-by: build bot (Jenkins) 
---
M src/soc/intel/common/block/include/intelblocks/systemagent.h
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Aaron Durbin: Looks good to me, approved
  Wonkyu Kim: Looks good to me, but someone else must approve
  Lean Sheng Tan: Looks good to me, but someone else must approve

diff --git a/src/soc/intel/common/block/include/intelblocks/systemagent.h b/src/soc/intel/common/block/include/intelblocks/systemagent.h
index 11ea76a..30c892b 100644
--- a/src/soc/intel/common/block/include/intelblocks/systemagent.h
+++ b/src/soc/intel/common/block/include/intelblocks/systemagent.h
@@ -31,13 +31,13 @@
  *   INDEX = Either PCI configuration space registers or MMIO offsets
  *   mapped from REG.
  *   BASE = 64 bit Address.
- *   SIZE = base length
+ *   SIZE = 64 bit base length
  *   DESCRIPTION = Name of the register/offset.
  */
 struct sa_mmio_descriptor {
    unsigned int index;
    uint64_t base;
-	size_t size;
+	uint64_t size;
    const char *description;
 };

[9elements QA (Code Review)]

9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40336 )

Change subject: soc/intel/common/block: Update SA resource length to support 64 bit
......................................................................

Patch Set 9:

Automatic boot test returned (PASS/FAIL/TOTAL): 4/0/4
Emulation targets:
"QEMU x86 q35/ich9" using payload TianoCore : SUCCESS : https://lava.9esec.io/r/3912
"QEMU x86 q35/ich9" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/3911
"QEMU x86 i440fx/piix4" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/3910
"QEMU AArch64" using payload LinuxBoot_u-root_kexec : SUCCESS : https://lava.9esec.io/r/3909

Please note: This test is under development and might not be accurate at all!