Attention is currently required from: Jakub Czapiga, Julius Werner, Jérémy Compostella, Werner Zeh.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79946?usp=email )
Change subject: [RFC] region: Turn region_end() into an inclusive region_last() ......................................................................
Patch Set 5:
(2 comments)
File src/commonlib/region.c:
https://review.coreboot.org/c/coreboot/+/79946/comment/06066242_6b26d9c0 : PS5, Line 16: if (region_last(c) < region_offset(p))
What's the point of this change? All this is trying to check is that `c` doesn't wrap, so the equiva […]
Sorry, about that, I really messed up the push. It's not the final version I had locally.
File tests/commonlib/region-test.c:
https://review.coreboot.org/c/coreboot/+/79946/comment/77b195e4_62b92338 : PS5, Line 338: assert_true((uintptr_t)backing <= SIZE_MAX);
I think a lot of our code assumes that coreboot is built and run on a flat linear address space, and […]
This was about asserting the unit-test was valid. I probably have seen too many unit-tests with undefined behavior (not in coreboot! I'm actually quite fond of these), so I wanted to be sure.