Hello Maccraft123,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/40320
to review the following change.
Change subject: drivers/pc80/rtc: Turn comment into warning message ......................................................................
drivers/pc80/rtc: Turn comment into warning message
Change-Id: I80786042b1c464268cae8093bd5d3e8d73be5aee Signed-off-by: Nico Huber nico.h@gmx.de --- M src/drivers/pc80/rtc/mc146818rtc_boot.c 1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/40320/1
diff --git a/src/drivers/pc80/rtc/mc146818rtc_boot.c b/src/drivers/pc80/rtc/mc146818rtc_boot.c index 37f1470..d470d8f 100644 --- a/src/drivers/pc80/rtc/mc146818rtc_boot.c +++ b/src/drivers/pc80/rtc/mc146818rtc_boot.c @@ -2,6 +2,7 @@ /* This file is part of the coreboot project. */
#include <stdint.h> +#include <console/console.h> #include <option.h> #include <pc80/mc146818rtc.h> #include <fallback.h> @@ -35,9 +36,8 @@ unsigned char byte;
if (cmos_error() || (CONFIG(USE_OPTION_TABLE) && !cmos_lb_cks_valid())) { - /* Invalid CMOS checksum detected! - * Force fallback boot... - */ + printk(BIOS_WARNING, + "Invalid CMOS checksum detected! Force fallback boot...\n"); byte = cmos_read(RTC_BOOT_BYTE); byte &= boot_set_fallback(byte) & 0x0f; byte |= 0xf << 4;
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40320 )
Change subject: drivers/pc80/rtc: Turn comment into warning message ......................................................................
Patch Set 1: Code-Review+1
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40320 )
Change subject: drivers/pc80/rtc: Turn comment into warning message ......................................................................
Patch Set 1: Code-Review+2
Nico Huber has submitted this change. ( https://review.coreboot.org/c/coreboot/+/40320 )
Change subject: drivers/pc80/rtc: Turn comment into warning message ......................................................................
drivers/pc80/rtc: Turn comment into warning message
Change-Id: I80786042b1c464268cae8093bd5d3e8d73be5aee Signed-off-by: Nico Huber nico.h@gmx.de Reviewed-on: https://review.coreboot.org/c/coreboot/+/40320 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Kyösti Mälkki kyosti.malkki@gmail.com Reviewed-by: Angel Pons th3fanbus@gmail.com --- M src/drivers/pc80/rtc/mc146818rtc_boot.c 1 file changed, 3 insertions(+), 3 deletions(-)
Approvals: build bot (Jenkins): Verified Kyösti Mälkki: Looks good to me, but someone else must approve Angel Pons: Looks good to me, approved
diff --git a/src/drivers/pc80/rtc/mc146818rtc_boot.c b/src/drivers/pc80/rtc/mc146818rtc_boot.c index 37f1470..d470d8f 100644 --- a/src/drivers/pc80/rtc/mc146818rtc_boot.c +++ b/src/drivers/pc80/rtc/mc146818rtc_boot.c @@ -2,6 +2,7 @@ /* This file is part of the coreboot project. */
#include <stdint.h> +#include <console/console.h> #include <option.h> #include <pc80/mc146818rtc.h> #include <fallback.h> @@ -35,9 +36,8 @@ unsigned char byte;
if (cmos_error() || (CONFIG(USE_OPTION_TABLE) && !cmos_lb_cks_valid())) { - /* Invalid CMOS checksum detected! - * Force fallback boot... - */ + printk(BIOS_WARNING, + "Invalid CMOS checksum detected! Force fallback boot...\n"); byte = cmos_read(RTC_BOOT_BYTE); byte &= boot_set_fallback(byte) & 0x0f; byte |= 0xf << 4;
9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40320 )
Change subject: drivers/pc80/rtc: Turn comment into warning message ......................................................................
Patch Set 2:
Automatic boot test returned (PASS/FAIL/TOTAL): 4/0/4 Emulation targets: EMULATION_QEMU_X86_Q35 using payload TianoCore : SUCCESS : https://lava.9esec.io/r/2464 EMULATION_QEMU_X86_Q35 using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/2463 EMULATION_QEMU_X86_I440FX using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/2462 EMULATION_QEMU_AARCH64_FIT_SUPPORT_TIMESTAMPS using payload LinuxBoot_u-root_kexec_AARCH64 : SUCCESS : https://lava.9esec.io/r/2461
Please note: This test is under development and might not be accurate at all!
-
9elements QA (Code Review) -
Angel Pons (Code Review)
-
Kyösti Mälkki (Code Review)
-
Nico Huber (Code Review)