HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37508 )
Change subject: superio/serverengines/pilot: Fix typo ......................................................................
superio/serverengines/pilot: Fix typo
Change-Id: Ic7cd93150252b2e5235c82c8c63540059b68d22b Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/superio/serverengines/pilot/early_serial.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/08/37508/1
diff --git a/src/superio/serverengines/pilot/early_serial.c b/src/superio/serverengines/pilot/early_serial.c index 555e4f5..3c140fb 100644 --- a/src/superio/serverengines/pilot/early_serial.c +++ b/src/superio/serverengines/pilot/early_serial.c @@ -22,7 +22,7 @@ #include <device/pnp.h> #include "pilot.h"
-/* Pilot uses 0x5A/0xA5 pattern to actiavte deactivate config access. */ +/* Pilot uses 0x5A/0xA5 pattern to activate deactivate config access. */ void pnp_enter_ext_func_mode(pnp_devfn_t dev) { u16 port = dev >> 8;
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37508 )
Change subject: superio/serverengines/pilot: Fix typo ......................................................................
Patch Set 1: Code-Review+1
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37508 )
Change subject: superio/serverengines/pilot: Fix typo ......................................................................
Patch Set 1: Code-Review+2
Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/37508 )
Change subject: superio/serverengines/pilot: Fix typo ......................................................................
superio/serverengines/pilot: Fix typo
Change-Id: Ic7cd93150252b2e5235c82c8c63540059b68d22b Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/37508 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Reviewed-by: Felix Held felix-coreboot@felixheld.de --- M src/superio/serverengines/pilot/early_serial.c 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Felix Held: Looks good to me, approved
diff --git a/src/superio/serverengines/pilot/early_serial.c b/src/superio/serverengines/pilot/early_serial.c index 555e4f5..3c140fb 100644 --- a/src/superio/serverengines/pilot/early_serial.c +++ b/src/superio/serverengines/pilot/early_serial.c @@ -22,7 +22,7 @@ #include <device/pnp.h> #include "pilot.h"
-/* Pilot uses 0x5A/0xA5 pattern to actiavte deactivate config access. */ +/* Pilot uses 0x5A/0xA5 pattern to activate deactivate config access. */ void pnp_enter_ext_func_mode(pnp_devfn_t dev) { u16 port = dev >> 8;
-
Felix Held (Code Review) -
HAOUAS Elyes (Code Review)
-
Paul Menzel (Code Review)