Attention is currently required from: Chen, Gang C.
Hello Chen, Gang C,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/76215?usp=email
to review the following change.
Change subject: vc/intel/edk: Add CFLAGS -fshort-wchar for UDK_202302_BINDING ......................................................................
vc/intel/edk: Add CFLAGS -fshort-wchar for UDK_202302_BINDING
Edk2-stable202302 adds wchar_t check and limit L'A' equals to 2. Add CFLAGS to override gcc default wchar_t size.
w/o this patch: src/vendorcode/intel/edk2/edk2-stable202302/MdePkg/Include/Base.h:795:1: note: in expansion of macro 'STATIC_ASSERT' 795 | STATIC_ASSERT (sizeof (L'A') == 2, "sizeof (L'A') does not meet UEFI Specification Data Type requirements"); | ^~~~~~~~~~~~~ src/vendorcode/intel/edk2/edk2-stable202302/MdePkg/Include/Base.h:796:1: note: in expansion of macro 'STATIC_ASSERT' 796 | STATIC_ASSERT (sizeof (L"A") == 4, "sizeof (L"A") does not meet UEFI Specification Data Type requirements"); | ^~~~~~~~~~~~~
Change-Id: Idf9505837d18fb8cf522af8044581b2826df7855 Signed-off-by: Jincheng Li jincheng.li@intel.com Signed-off-by: Gang Chen gang.c.chen@intel.com --- M src/soc/intel/meteorlake/Makefile.inc M src/vendorcode/intel/Makefile.inc 2 files changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/76215/1
diff --git a/src/soc/intel/meteorlake/Makefile.inc b/src/soc/intel/meteorlake/Makefile.inc index aa82381..688f75c 100644 --- a/src/soc/intel/meteorlake/Makefile.inc +++ b/src/soc/intel/meteorlake/Makefile.inc @@ -59,5 +59,4 @@ CPPFLAGS_common += -I$(src)/soc/intel/meteorlake CPPFLAGS_common += -I$(src)/soc/intel/meteorlake/include
-CFLAGS_common += -fshort-wchar endif diff --git a/src/vendorcode/intel/Makefile.inc b/src/vendorcode/intel/Makefile.inc index 4396ed3..ea690ba 100644 --- a/src/vendorcode/intel/Makefile.inc +++ b/src/vendorcode/intel/Makefile.inc @@ -27,4 +27,5 @@ CPPFLAGS_common += -I$(src)/vendorcode/intel/edk2/edk2-stable202302/MdePkg/Include CPPFLAGS_common += -I$(src)/vendorcode/intel/edk2/edk2-stable202302/IntelFsp2Pkg/Include CPPFLAGS_common += -I$(src)/vendorcode/intel/edk2/edk2-stable202302/UefiCpuPkg/Include/ +CFLAGS_common += -fshort-wchar endif