Attention is currently required from: Jayvik Desai, Kapil Porwal, Karthik Ramasubramanian, Nick Vaccaro, Subrata Banik.
Dinesh Gehlot has posted comments on this change by Karthik Ramasubramanian. ( https://review.coreboot.org/c/coreboot/+/85103?usp=email )
Change subject: soc/intel/alderlake: Display early Sign of Life for CSE FW Sync
......................................................................
Patch Set 2:
(1 comment)
File src/soc/intel/alderlake/romstage/romstage.c:
https://review.coreboot.org/c/coreboot/+/85103/comment/86e8ffc8_6d7ae644?usp... :
PS1, Line 188: ux_inform_user_of_update_operation("CSE update");
Earlier it was getting logged from cse_fw_update. […]
We might not need extensively relocated event logging. It's currently right after the CSE sync update, which serves the purpose of event logging. The patch CB:84398 actually moved the CSE sync logging during CSE FW sync.
Furthermore, ESOL and event logging for CSE sync are two different entities. We may not need to check ESOL status; the log just informs that the CSE sync operation has been performed.
Therefore, I believe we might not need CB:85111.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85103?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I5e7b71da7a98be87361dc7ab9e6c4ae572f61773
Gerrit-Change-Number: 85103
Gerrit-PatchSet: 2
Gerrit-Owner: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Jayvik Desai
jayvik@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jayvik Desai
jayvik@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Wed, 13 Nov 2024 03:04:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com