Change in coreboot[master]: mb/google/deltaur: Enable Melfas touch screen

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

EricR Lai (Code Review)

3 Apr 2020 3 Apr '20

2:51 a.m.

EricR Lai has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/40113 )

Change subject: mb/google/deltaur: Enable Melfas touch screen ......................................................................

mb/google/deltaur: Enable Melfas touch screen

Reference Drallion to add device tree for Melfas touch screen.

BUG=b:152924290

Signed-off-by: Eric Lai ericr_lai@compal.corp-partner.google.com Change-Id: I7b0a42119891c6c2d5978d7f33eefffa2d62df76 --- M src/mainboard/google/deltaur/variants/deltan/overridetree.cb 1 file changed, 19 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/40113/1

diff --git a/src/mainboard/google/deltaur/variants/deltan/overridetree.cb b/src/mainboard/google/deltaur/variants/deltan/overridetree.cb index 32204c5..750c3c5 100644 --- a/src/mainboard/google/deltaur/variants/deltan/overridetree.cb +++ b/src/mainboard/google/deltaur/variants/deltan/overridetree.cb @@ -3,4 +3,23 @@ device domain 0 on end

+ device pci 15.0 on + chip drivers/i2c/generic + register "hid" = ""MLFS0000"" + register "desc" = ""Melfas Touchscreen"" + register "irq" = "ACPI_IRQ_EDGE_LOW(GPP_E1_IRQ)" + register "probed" = "1" + register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_A10)" + register "reset_delay_ms" = "10" + register "reset_off_delay_ms" = "5" + register "stop_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_B3)" + register "stop_delay_ms" = "10" + register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_B21)" + register "enable_delay_ms" = "55" + register "has_power_resource" = "1" + register "device_present_gpio" = "GPP_B4" + register "device_present_gpio_invert" = "1" + device i2c 34 on end + end + end # I2C #0 end

Attachments:

attachment.htm (text/html — 4.3 KB)

Show replies by date

Paul Menzel (Code Review)

3 Apr 3 Apr

6:30 a.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40113 )

Change subject: mb/google/deltaur: Enable Melfas touch screen ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/40113/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/40113/1//COMMIT_MSG@10 PS1, Line 10: Tested how?

-- To view, visit https://review.coreboot.org/c/coreboot/+/40113 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7b0a42119891c6c2d5978d7f33eefffa2d62df76 Gerrit-Change-Number: 40113 Gerrit-PatchSet: 1 Gerrit-Owner: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Fri, 03 Apr 2020 09:30:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

EricR Lai (Code Review)

6:44 a.m.

EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40113 )

Change subject: mb/google/deltaur: Enable Melfas touch screen ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/40113/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/40113/1//COMMIT_MSG@10 PS1, Line 10:

...

Tested how?

We don't have any board now. No tested. Just implemented from others projects.

-- To view, visit https://review.coreboot.org/c/coreboot/+/40113 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7b0a42119891c6c2d5978d7f33eefffa2d62df76 Gerrit-Change-Number: 40113 Gerrit-PatchSet: 1 Gerrit-Owner: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Fri, 03 Apr 2020 09:44:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: comment

Tim Wawrzynczak (Code Review)

1:41 p.m.

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40113 )

Change subject: mb/google/deltaur: Enable Melfas touch screen ......................................................................

Patch Set 1: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/40113 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7b0a42119891c6c2d5978d7f33eefffa2d62df76 Gerrit-Change-Number: 40113 Gerrit-PatchSet: 1 Gerrit-Owner: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-Reviewer: Bora Guvendik bora.guvendik@intel.com Gerrit-Reviewer: Kevin Chowski chowski@google.com Gerrit-Reviewer: Selma Bensaid selma.bensaid@intel.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Fri, 03 Apr 2020 16:41:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Tim Wawrzynczak (Code Review)

1:41 p.m.

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40113 )

Change subject: mb/google/deltaur: Enable Melfas touch screen ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/40113/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/40113/1//COMMIT_MSG@7 PS1, Line 7: screen for Deltan

-- To view, visit https://review.coreboot.org/c/coreboot/+/40113 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7b0a42119891c6c2d5978d7f33eefffa2d62df76 Gerrit-Change-Number: 40113 Gerrit-PatchSet: 1 Gerrit-Owner: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-Reviewer: Bora Guvendik bora.guvendik@intel.com Gerrit-Reviewer: Kevin Chowski chowski@google.com Gerrit-Reviewer: Selma Bensaid selma.bensaid@intel.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Fri, 03 Apr 2020 16:41:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

EricR Lai (Code Review)

1:44 p.m.

New subject: Change in coreboot[master]: mb/google/deltaur: Enable Melfas touch screen for Deltan

Hello Bora Guvendik, build bot (Jenkins), Selma Bensaid, Tim Wawrzynczak, Kevin Chowski,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/40113

to look at the new patch set (#2).

Change subject: mb/google/deltaur: Enable Melfas touch screen for Deltan ......................................................................

mb/google/deltaur: Enable Melfas touch screen for Deltan

Reference Drallion to add device tree for Melfas touch screen.

BUG=b:152924290

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/40113/2

-- To view, visit https://review.coreboot.org/c/coreboot/+/40113 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7b0a42119891c6c2d5978d7f33eefffa2d62df76 Gerrit-Change-Number: 40113 Gerrit-PatchSet: 2 Gerrit-Owner: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-Reviewer: Bora Guvendik bora.guvendik@intel.com Gerrit-Reviewer: Kevin Chowski chowski@google.com Gerrit-Reviewer: Selma Bensaid selma.bensaid@intel.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

EricR Lai (Code Review)

1:44 p.m.

New subject: Change in coreboot[master]: mb/google/deltaur: Enable Melfas touch screen for Deltan

EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40113 )

Change subject: mb/google/deltaur: Enable Melfas touch screen for Deltan ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/40113/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/40113/1//COMMIT_MSG@7 PS1, Line 7: screen

...

for Deltan

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/40113 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7b0a42119891c6c2d5978d7f33eefffa2d62df76 Gerrit-Change-Number: 40113 Gerrit-PatchSet: 2 Gerrit-Owner: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-Reviewer: Bora Guvendik bora.guvendik@intel.com Gerrit-Reviewer: Kevin Chowski chowski@google.com Gerrit-Reviewer: Selma Bensaid selma.bensaid@intel.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Fri, 03 Apr 2020 16:44:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-MessageType: comment

Patrick Georgi (Code Review)

14 Apr 14 Apr

7:08 a.m.

New subject: Change in coreboot[master]: mb/google/deltaur: Enable Melfas touch screen for Deltan

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/40113 )

Change subject: mb/google/deltaur: Enable Melfas touch screen for Deltan ......................................................................

mb/google/deltaur: Enable Melfas touch screen for Deltan

Reference Drallion to add device tree for Melfas touch screen.

BUG=b:152924290

Signed-off-by: Eric Lai ericr_lai@compal.corp-partner.google.com Change-Id: I7b0a42119891c6c2d5978d7f33eefffa2d62df76 Reviewed-on: https://review.coreboot.org/c/coreboot/+/40113 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Tim Wawrzynczak twawrzynczak@chromium.org --- M src/mainboard/google/deltaur/variants/deltan/overridetree.cb 1 file changed, 19 insertions(+), 0 deletions(-)

Approvals: build bot (Jenkins): Verified Tim Wawrzynczak: Looks good to me, approved

diff --git a/src/mainboard/google/deltaur/variants/deltan/overridetree.cb b/src/mainboard/google/deltaur/variants/deltan/overridetree.cb index 6a2719b..be1f29f 100644 --- a/src/mainboard/google/deltaur/variants/deltan/overridetree.cb +++ b/src/mainboard/google/deltaur/variants/deltan/overridetree.cb @@ -9,4 +9,23 @@ device pci 1f.6 on end # GbE 0x15FC end

-- To view, visit https://review.coreboot.org/c/coreboot/+/40113 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7b0a42119891c6c2d5978d7f33eefffa2d62df76 Gerrit-Change-Number: 40113 Gerrit-PatchSet: 4 Gerrit-Owner: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-Reviewer: Bora Guvendik bora.guvendik@intel.com Gerrit-Reviewer: Kevin Chowski chowski@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Selma Bensaid selma.bensaid@intel.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: merged

1834

days inactive

1845

days old

coreboot-gerrit@coreboot.org

7 comments

4 participants

tags (0)

participants (4)

EricR Lai (Code Review)
Patrick Georgi (Code Review)
Paul Menzel (Code Review)
Tim Wawrzynczak (Code Review)