Attention is currently required from: Subrata Banik, Arthur Heymans.
Johnny Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55745 )
Change subject: util/ifdtool: Add Cooper Lake platform support under IFDv2
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3:
if you pass -p cpx and add platform name check inside IFDv2 function, would be enough for unique ide […]
Yes, that's what I did in patchset 1, Arthur found some other things that should be fixed for CPL as well so he added patchset 2 for that. But yes patchset 1 is enough for fixing IFDv2 detection.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/55745
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I444e7d35a85d9d42fc25d654e57386f38cf1ec85
Gerrit-Change-Number: 55745
Gerrit-PatchSet: 3
Gerrit-Owner: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Anjaneya "Reddy" Chagam
anjaneya.chagam@intel.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Jingle Hsu
jingle_hsu@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Wed, 23 Jun 2021 06:38:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subrata.banik@intel.com
Gerrit-MessageType: comment