Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31549 )
Change subject: cpu/x86/pae/pgtbl: Add memset with PAE ......................................................................
Patch Set 10:
(7 comments)
https://review.coreboot.org/#/c/31549/7/src/cpu/x86/pae/pgtbl.c File src/cpu/x86/pae/pgtbl.c:
https://review.coreboot.org/#/c/31549/7/src/cpu/x86/pae/pgtbl.c@122 PS7, Line 122: * @param pat The pattern to write to the pyhsical memory
I don't get your point. Regular memset declares […]
Done
https://review.coreboot.org/#/c/31549/7/src/cpu/x86/pae/pgtbl.c@148 PS7, Line 148: * Point the page directory pointers at the page : * directories.
Dosen’t this fit on one line?
Done
https://review.coreboot.org/#/c/31549/7/src/cpu/x86/pae/pgtbl.c@163 PS7, Line 163: PDE_A | PDE_D |
As far as I understood, the processor would not interpret these, […]
Done
https://review.coreboot.org/#/c/31549/7/src/cpu/x86/pae/pgtbl.c@177 PS7, Line 177: ~((1UL << PDE_IDX_SHIFT) - 1)
yes, but that assumes no PAE 4KiB PDE mode. […]
Removed as it's already aligned.
https://review.coreboot.org/#/c/31549/8/src/cpu/x86/pae/pgtbl.c File src/cpu/x86/pae/pgtbl.c:
https://review.coreboot.org/#/c/31549/8/src/cpu/x86/pae/pgtbl.c@157 PS8, Line 157: ((dest < pgtbl_e) && (dest + length > pgtbl_e))) {
This is usually simpler. If you have two ranges [a, b) and […]
Done
https://review.coreboot.org/#/c/31549/8/src/cpu/x86/pae/pgtbl.c@158 PS8, Line 158: printk(BIOS_ERR, "%s: destination overlaps page tables\n", __func__);
line over 80 characters
Done
https://review.coreboot.org/#/c/31549/8/src/cpu/x86/pae/pgtbl.c@166 PS8, Line 166: printk(BIOS_ERR, "%s: vmem address overlaps page tables\n", __func__);
line over 80 characters
Done
-
Patrick Rudolph (Code Review)