Jonathan Kollasch has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/22214 )
Change subject: nb/intel/sandybridge/raminit: Add ECC detection support ......................................................................
Patch Set 8:
(2 comments)
https://review.coreboot.org/c/coreboot/+/22214/8//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/22214/8//COMMIT_MSG@9 PS8, Line 9: forced While "forced" is not inaccurate, perhaps "required" would be a better, less frustration-charged, term to use throughout this change? Not so much an objection but a friendly suggestion.
https://review.coreboot.org/c/coreboot/+/22214/8/src/northbridge/intel/sandy... File src/northbridge/intel/sandybridge/raminit_common.c:
https://review.coreboot.org/c/coreboot/+/22214/8/src/northbridge/intel/sandy... PS8, Line 588: presedence Should probably be spelled "precedence".
-
Jonathan Kollasch (Code Review)