Attention is currently required from: Sean Rhodes, Angel Pons, Maximilian Brune, Lean Sheng Tan.
Benjamin Doron has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74121 )
Change subject: [RFC] drivers/option: Add option list in cbtable
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3:
Just a thought, most options list will be pretty long. […]
Use different forms for this? While emitting true "form" IFR in EDK2 will be fairly difficult (form *updating* is performed by comparing the buffer to what exists in the existing setup menu VFR package, but new forms do not. It's probably still *doable* though), I plan to write subtitles for them, if the setup menu can render that.
We're still finalising how text options can be used, so writing your own separators that way is a possibility too.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74121
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I304de7d26d79245a2e31a6d01f6c5643b31cb772
Gerrit-Change-Number: 74121
Gerrit-PatchSet: 3
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-Reviewer: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Daniel Maslowski
info@orangecms.org
Gerrit-CC: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-CC: Matt DeVillier
matt.devillier@gmail.com
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Sean Rhodes
sean@starlabs.systems
Gerrit-Attention: Sean Rhodes
sean@starlabs.systems
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Attention: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Comment-Date: Sat, 29 Apr 2023 21:19:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sean Rhodes
sean@starlabs.systems
Gerrit-MessageType: comment