Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34396 )
Change subject: mb/google/hatch: Fix SD card is detected as read only issue
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34396/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/34396/2//COMMIT_MSG@9
PS2, Line 9: This patch configures GPIO pin GPP_G7 as NF1 with internal pull down.
oh no, there is an issue where physical pin is not connected in board
It would be good to point out in the commit message that the pin is not connected, and so the code must configure the GPIO with an internal pull-down.
Does the lack of a connection on G7 affect the ability of the SD card interface to use a read-only SD card? (Do they even make cards with the physical write-protect switch any more?)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34396
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0187267670e1dea3e1d5e83d0b29967714d6065e
Gerrit-Change-Number: 34396
Gerrit-PatchSet: 2
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Medha Garima
medha.garima@intel.com
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Usha P
usha.p@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 18 Jul 2019 14:08:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subrata.banik@intel.com
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment