18 Jul
2019
18 Jul
'19
1:56 p.m.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34396 )
Change subject: mb/google/hatch: Fix SD card is detected as read only issue ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34396/2/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/34396/2/src/mainboard/google/hatch/... PS2, Line 327: */ Can you please add a comment indicating why this pin is configured this way?
--
To view, visit https://review.coreboot.org/c/coreboot/+/34396
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0187267670e1dea3e1d5e83d0b29967714d6065e
Gerrit-Change-Number: 34396
Gerrit-PatchSet: 2
Gerrit-Owner: Subrata Banik subrata.banik@intel.com
Gerrit-Reviewer: Aamir Bohra aamir.bohra@intel.com
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Medha Garima medha.garima@intel.com
Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com
Gerrit-Reviewer: Usha P usha.p@intel.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 18 Jul 2019 13:56:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
1750
days inactive
1750
days old
0 comments
1 participants
participants (1)
-
Furquan Shaikh (Code Review)