Change in coreboot[master]: soc/intel/tgl,mb/google/volteer: Add API for Type-C aux bias pads
Attention is currently required from: Shaunak Saha, Martin Roth, Tim Wawrzynczak, Angel Pons, Subrata Banik, Michael Niewöhner, Patrick Rudolph. Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51649 )
Change subject: soc/intel/tgl,mb/google/volteer: Add API for Type-C aux bias pads ......................................................................
Patch Set 22:
(3 comments)
File src/soc/intel/common/block/tcss/tcss.c:
https://review.coreboot.org/c/coreboot/+/51649/comment/db542cf8_75abe5e8 PS22, Line 325: cpu_pid Isn't this the same as cpu_portid above?
https://review.coreboot.org/c/coreboot/+/51649/comment/05e4238a_6e30501a PS22, Line 331: tcss_configure_aux_bias_pads Now that this function is implemented in the common tcss driver, should it be called from `tcss_configure()` instead of having the SoC call it?
https://review.coreboot.org/c/coreboot/+/51649/comment/63db3b96_26fc47ed PS22, Line 333: MAX_TYPE_C_PORTS Not for this change, but I think we should change this to a Kconfig. Not all SoCs will support the same number of type-C ports.
-
Furquan Shaikh (Code Review)