Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50401 )
Change subject: soc/amd/picasso: move bert_reserved_region to common/block/cpu/noncar
......................................................................
Patch Set 2:
(1 comment)
File src/soc/amd/common/block/cpu/noncar/memmap.c:
https://review.coreboot.org/c/coreboot/+/50401/comment/36fc6ddf_97a40eb3
PS2, Line 84: bert_reserved_region
same comment as last patch. Maybe this function could be renamed to have a verb in a future patch.
basically same comment as on the last one, but it's called from src/arch/x86/acpi_bert_storage.c in this case
--
To view, visit
https://review.coreboot.org/c/coreboot/+/50401
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib49124c2c774ad3352ea2f7d8d827388029be041
Gerrit-Change-Number: 50401
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Comment-Date: Mon, 08 Feb 2021 19:45:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Martin Roth
martinroth@google.com
Gerrit-MessageType: comment