[L] Change in coreboot[main]: soc/intel/common/block/imc: Add Integrated Memory Controller driver

[Paul Menzel (Code Review)]

Attention is currently required from: Felix Singer, Jérémy Compostella, [e-mail].

Paul Menzel has posted comments on this change by [e-mail]. ( https://review.coreboot.org/c/coreboot/+/83320?usp=email )

The change is no longer submittable: All-Comments-Resolved is unsatisfied now.

Change subject: soc/intel/common/block/imc: Add Integrated Memory Controller driver
......................................................................

Patch Set 21:

(8 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/83320/comment/8f30ecfd_dd04a610?usp... :
PS21, Line 11: 
Please document the datasheet you used for reference.

https://review.coreboot.org/c/coreboot/+/83320/comment/9ca3ffac_893a286c?usp... :
PS21, Line 12: Change-Id: I3f47ddeda94d3882852d64c0052f8fb42b6b7ad2
Please add a TEST= line, and also paste the new log messages.

File src/soc/intel/common/block/imc/Kconfig:

https://review.coreboot.org/c/coreboot/+/83320/comment/4ebca8d5_5ca20fc9?usp... :
PS21, Line 8: Support for Integrated Memory Controller.
Elaborate, and maybe also add a reference?

File src/soc/intel/common/block/imc/imc.c:

https://review.coreboot.org/c/coreboot/+/83320/comment/18e97e8c_fa06021d?usp... :
PS21, Line 4: IO based access will not work.
Why? Bug or by design?

https://review.coreboot.org/c/coreboot/+/83320/comment/81626e1d_0206e68e?usp... :
PS21, Line 39: /**<
Why this format, and not just `/*`?

https://review.coreboot.org/c/coreboot/+/83320/comment/8a99551b_ff0c9283?usp... :
PS21, Line 64: does
is

https://review.coreboot.org/c/coreboot/+/83320/comment/07dba728_fb7b62bb?usp... :
PS21, Line 180: doesn't finished
didn’t finish

File src/soc/intel/common/block/smbus/smbuslib.c:

https://review.coreboot.org/c/coreboot/+/83320/comment/0cf6e4b1_31d29fe9?usp... :
PS21, Line 85: /**
/*