Kyösti Mälkki has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/36828 )
Change subject: [WIP] arch/x86: Declare acpi_disable_sci_on_exit() ......................................................................
[WIP] arch/x86: Declare acpi_disable_sci_on_exit()
Change-Id: I9d9b2085c0f06235f1e7ea395c9df826c3988027 Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com --- M src/include/cpu/x86/smm.h M src/soc/amd/picasso/finalize.c M src/soc/amd/stoneyridge/finalize.c M src/soc/intel/broadwell/lpc.c M src/soc/intel/common/block/pmc/pmc.c M src/soc/intel/denverton_ns/pmc.c M src/southbridge/amd/agesa/hudson/lpc.c M src/southbridge/amd/pi/hudson/lpc.c M src/southbridge/intel/bd82x6x/lpc.c M src/southbridge/intel/i82801gx/lpc.c M src/southbridge/intel/i82801ix/lpc.c M src/southbridge/intel/i82801jx/lpc.c M src/southbridge/intel/ibexpeak/lpc.c M src/southbridge/intel/lynxpoint/lpc.c 14 files changed, 48 insertions(+), 57 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/36828/1
diff --git a/src/include/cpu/x86/smm.h b/src/include/cpu/x86/smm.h index c3e1b9c..0f0d19b 100644 --- a/src/include/cpu/x86/smm.h +++ b/src/include/cpu/x86/smm.h @@ -62,6 +62,11 @@ return CONFIG(HAVE_SMI_HANDLER); }
+static inline int acpi_disable_sci_on_exit(void) +{ + return CONFIG(HAVE_SMI_HANDLER); +} + /* This is the SMM handler. */ extern unsigned char _binary_smm_start[]; extern unsigned char _binary_smm_end[]; diff --git a/src/soc/amd/picasso/finalize.c b/src/soc/amd/picasso/finalize.c index 947337d..eb6dd3d 100644 --- a/src/soc/amd/picasso/finalize.c +++ b/src/soc/amd/picasso/finalize.c @@ -57,12 +57,10 @@ { finalize_cores();
- if (!acpi_is_wakeup_s3()) { - if (CONFIG(HAVE_SMI_HANDLER)) - acpi_disable_sci(); - else - acpi_enable_sci(); - } + if (acpi_disable_sci_on_exit()) + acpi_disable_sci(); + else + acpi_enable_sci();
post_code(POST_OS_BOOT); } diff --git a/src/soc/amd/stoneyridge/finalize.c b/src/soc/amd/stoneyridge/finalize.c index 947337d..eb6dd3d 100644 --- a/src/soc/amd/stoneyridge/finalize.c +++ b/src/soc/amd/stoneyridge/finalize.c @@ -57,12 +57,10 @@ { finalize_cores();
- if (!acpi_is_wakeup_s3()) { - if (CONFIG(HAVE_SMI_HANDLER)) - acpi_disable_sci(); - else - acpi_enable_sci(); - } + if (acpi_disable_sci_on_exit()) + acpi_disable_sci(); + else + acpi_enable_sci();
post_code(POST_OS_BOOT); } diff --git a/src/soc/intel/broadwell/lpc.c b/src/soc/intel/broadwell/lpc.c index 3392614..0dbd91f 100644 --- a/src/soc/intel/broadwell/lpc.c +++ b/src/soc/intel/broadwell/lpc.c @@ -424,7 +424,7 @@
static void pch_set_acpi_mode(void) { - if (CONFIG(HAVE_SMI_HANDLER) && !acpi_is_wakeup_s3()) { + if (acpi_disable_sci_on_exit()) { printk(BIOS_DEBUG, "Disabling ACPI via APMC:\n"); outb(APM_CNT_ACPI_DISABLE, APM_CNT); printk(BIOS_DEBUG, "done.\n"); diff --git a/src/soc/intel/common/block/pmc/pmc.c b/src/soc/intel/common/block/pmc/pmc.c index 1d2aa61..aebbead 100644 --- a/src/soc/intel/common/block/pmc/pmc.c +++ b/src/soc/intel/common/block/pmc/pmc.c @@ -106,7 +106,7 @@
void pmc_set_acpi_mode(void) { - if (CONFIG(HAVE_SMI_HANDLER) && !acpi_is_wakeup_s3()) { + if (acpi_disable_sci_on_exit()) { printk(BIOS_DEBUG, "Disabling ACPI via APMC:\n"); outb(APM_CNT_ACPI_DISABLE, APM_CNT); printk(BIOS_DEBUG, "done.\n"); diff --git a/src/soc/intel/denverton_ns/pmc.c b/src/soc/intel/denverton_ns/pmc.c index 8b52087..75da082 100644 --- a/src/soc/intel/denverton_ns/pmc.c +++ b/src/soc/intel/denverton_ns/pmc.c @@ -38,7 +38,7 @@
static void pch_set_acpi_mode(void) { - if (CONFIG(HAVE_SMI_HANDLER) && !acpi_is_wakeup_s3()) { + if (acpi_disable_sci_on_exit()) { printk(BIOS_DEBUG, "Disabling ACPI via APMC:\n"); outb(APM_CNT_ACPI_DISABLE, APM_CNT); printk(BIOS_DEBUG, "done.\n"); diff --git a/src/southbridge/amd/agesa/hudson/lpc.c b/src/southbridge/amd/agesa/hudson/lpc.c index 7759758..77d7159 100644 --- a/src/southbridge/amd/agesa/hudson/lpc.c +++ b/src/southbridge/amd/agesa/hudson/lpc.c @@ -338,12 +338,10 @@
static void lpc_final(struct device *dev) { - if (!acpi_is_wakeup_s3()) { - if (CONFIG(HAVE_SMI_HANDLER)) - outl(0x0, ACPI_PM1_CNT_BLK); /* clear SCI_EN */ - else - outl(0x1, ACPI_PM1_CNT_BLK); /* set SCI_EN */ - } + if (acpi_disable_sci_on_exit()) + outl(0x0, ACPI_PM1_CNT_BLK); /* clear SCI_EN */ + else + outl(0x1, ACPI_PM1_CNT_BLK); /* set SCI_EN */ }
static struct pci_operations lops_pci = { diff --git a/src/southbridge/amd/pi/hudson/lpc.c b/src/southbridge/amd/pi/hudson/lpc.c index 6654830..9d093ec 100644 --- a/src/southbridge/amd/pi/hudson/lpc.c +++ b/src/southbridge/amd/pi/hudson/lpc.c @@ -354,12 +354,10 @@
static void lpc_final(struct device *dev) { - if (!acpi_is_wakeup_s3()) { - if (CONFIG(HAVE_SMI_HANDLER)) - outl(0x0, ACPI_PM1_CNT_BLK); /* clear SCI_EN */ - else - outl(0x1, ACPI_PM1_CNT_BLK); /* set SCI_EN */ - } + if (acpi_disable_sci_on_exit()) + outl(0x0, ACPI_PM1_CNT_BLK); /* clear SCI_EN */ + else + outl(0x1, ACPI_PM1_CNT_BLK); /* set SCI_EN */ }
static struct pci_operations lops_pci = { diff --git a/src/southbridge/intel/bd82x6x/lpc.c b/src/southbridge/intel/bd82x6x/lpc.c index e7b7db8..b77a05b 100644 --- a/src/southbridge/intel/bd82x6x/lpc.c +++ b/src/southbridge/intel/bd82x6x/lpc.c @@ -418,7 +418,7 @@
static void pch_set_acpi_mode(void) { - if (!acpi_is_wakeup_s3() && CONFIG(HAVE_SMI_HANDLER)) { + if (acpi_disable_sci_on_exit()) { printk(BIOS_DEBUG, "Disabling ACPI via APMC:\n"); outb(APM_CNT_ACPI_DISABLE, APM_CNT); // Disable ACPI mode printk(BIOS_DEBUG, "done.\n"); diff --git a/src/southbridge/intel/i82801gx/lpc.c b/src/southbridge/intel/i82801gx/lpc.c index 34250d39..30c0263 100644 --- a/src/southbridge/intel/i82801gx/lpc.c +++ b/src/southbridge/intel/i82801gx/lpc.c @@ -335,15 +335,13 @@
static void i82801gx_set_acpi_mode(struct device *dev) { - if (CONFIG(HAVE_SMI_HANDLER)) { - if (!acpi_is_wakeup_s3()) { - printk(BIOS_DEBUG, "Disabling ACPI via APMC:\n"); - outb(APM_CNT_ACPI_DISABLE, APM_CNT); // Disable ACPI mode - printk(BIOS_DEBUG, "done.\n"); - } else { - printk(BIOS_DEBUG, "S3 wakeup, enabling ACPI via APMC\n"); - outb(APM_CNT_ACPI_ENABLE, APM_CNT); - } + if (acpi_disable_sci_on_exit()) { + printk(BIOS_DEBUG, "Disabling ACPI via APMC:\n"); + outb(APM_CNT_ACPI_DISABLE, APM_CNT); // Disable ACPI mode + printk(BIOS_DEBUG, "done.\n"); + } else { + printk(BIOS_DEBUG, "S3 wakeup, enabling ACPI via APMC\n"); + outb(APM_CNT_ACPI_ENABLE, APM_CNT); } }
diff --git a/src/southbridge/intel/i82801ix/lpc.c b/src/southbridge/intel/i82801ix/lpc.c index 63d3ffe..3709f71 100644 --- a/src/southbridge/intel/i82801ix/lpc.c +++ b/src/southbridge/intel/i82801ix/lpc.c @@ -368,15 +368,13 @@
static void i82801ix_set_acpi_mode(struct device *dev) { - if (CONFIG(HAVE_SMI_HANDLER)) { - if (!acpi_is_wakeup_s3()) { - printk(BIOS_DEBUG, "Disabling ACPI via APMC:\n"); - outb(APM_CNT_ACPI_DISABLE, APM_CNT); // Disable ACPI mode - printk(BIOS_DEBUG, "done.\n"); - } else { - printk(BIOS_DEBUG, "S3 wakeup, enabling ACPI via APMC\n"); - outb(APM_CNT_ACPI_ENABLE, APM_CNT); - } + if (acpi_disable_sci_on_exit()) { + printk(BIOS_DEBUG, "Disabling ACPI via APMC:\n"); + outb(APM_CNT_ACPI_DISABLE, APM_CNT); // Disable ACPI mode + printk(BIOS_DEBUG, "done.\n"); + } else { + printk(BIOS_DEBUG, "S3 wakeup, enabling ACPI via APMC\n"); + outb(APM_CNT_ACPI_ENABLE, APM_CNT); } }
diff --git a/src/southbridge/intel/i82801jx/lpc.c b/src/southbridge/intel/i82801jx/lpc.c index a594452..a88b239 100644 --- a/src/southbridge/intel/i82801jx/lpc.c +++ b/src/southbridge/intel/i82801jx/lpc.c @@ -372,15 +372,13 @@
static void i82801jx_set_acpi_mode(struct device *dev) { - if (CONFIG(HAVE_SMI_HANDLER)) { - if (!acpi_is_wakeup_s3()) { - printk(BIOS_DEBUG, "Disabling ACPI via APMC:\n"); - outb(APM_CNT_ACPI_DISABLE, APM_CNT); // Disable ACPI mode - printk(BIOS_DEBUG, "done.\n"); - } else { - printk(BIOS_DEBUG, "S3 wakeup, enabling ACPI via APMC\n"); - outb(APM_CNT_ACPI_ENABLE, APM_CNT); - } + if (acpi_disable_sci_on_exit()) { + printk(BIOS_DEBUG, "Disabling ACPI via APMC:\n"); + outb(APM_CNT_ACPI_DISABLE, APM_CNT); // Disable ACPI mode + printk(BIOS_DEBUG, "done.\n"); + } else { + printk(BIOS_DEBUG, "S3 wakeup, enabling ACPI via APMC\n"); + outb(APM_CNT_ACPI_ENABLE, APM_CNT); } }
diff --git a/src/southbridge/intel/ibexpeak/lpc.c b/src/southbridge/intel/ibexpeak/lpc.c index 2b48eab..e20320e 100644 --- a/src/southbridge/intel/ibexpeak/lpc.c +++ b/src/southbridge/intel/ibexpeak/lpc.c @@ -428,7 +428,7 @@
static void pch_set_acpi_mode(void) { - if (!acpi_is_wakeup_s3() && CONFIG(HAVE_SMI_HANDLER)) { + if (acpi_disable_sci_on_exit()) { printk(BIOS_DEBUG, "Disabling ACPI via APMC:\n"); outb(APM_CNT_ACPI_DISABLE, APM_CNT); // Disable ACPI mode printk(BIOS_DEBUG, "done.\n"); diff --git a/src/southbridge/intel/lynxpoint/lpc.c b/src/southbridge/intel/lynxpoint/lpc.c index c8e91c3..63dcbc0 100644 --- a/src/southbridge/intel/lynxpoint/lpc.c +++ b/src/southbridge/intel/lynxpoint/lpc.c @@ -490,7 +490,7 @@
static void pch_set_acpi_mode(void) { - if (CONFIG(HAVE_SMI_HANDLER) && !acpi_is_wakeup_s3()) { + if (acpi_disable_sci_on_exit()) { printk(BIOS_DEBUG, "Disabling ACPI via APMC:\n"); outb(APM_CNT_ACPI_DISABLE, APM_CNT); printk(BIOS_DEBUG, "done.\n");
Hello Patrick Rudolph, Vanny E, build bot (Jenkins), David Guckian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/36828
to look at the new patch set (#2).
Change subject: [WIP] arch/x86: Declare acpi_disable_sci_on_exit() ......................................................................
[WIP] arch/x86: Declare acpi_disable_sci_on_exit()
Change-Id: I9d9b2085c0f06235f1e7ea395c9df826c3988027 Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com --- M src/include/cpu/x86/smm.h M src/soc/amd/picasso/finalize.c M src/soc/amd/stoneyridge/finalize.c M src/soc/intel/broadwell/lpc.c M src/soc/intel/common/block/pmc/pmc.c M src/soc/intel/denverton_ns/pmc.c M src/southbridge/amd/agesa/hudson/lpc.c M src/southbridge/amd/pi/hudson/lpc.c M src/southbridge/intel/bd82x6x/lpc.c M src/southbridge/intel/i82801gx/lpc.c M src/southbridge/intel/i82801ix/lpc.c M src/southbridge/intel/i82801jx/lpc.c M src/southbridge/intel/ibexpeak/lpc.c M src/southbridge/intel/lynxpoint/lpc.c 14 files changed, 50 insertions(+), 57 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/36828/2
Hello Patrick Rudolph, Vanny E, build bot (Jenkins), David Guckian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/36828
to look at the new patch set (#3).
Change subject: [WIP] arch/x86: Declare acpi_disable_sci_on_exit() ......................................................................
[WIP] arch/x86: Declare acpi_disable_sci_on_exit()
Change-Id: I9d9b2085c0f06235f1e7ea395c9df826c3988027 Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com --- M src/include/cpu/x86/smm.h M src/soc/amd/picasso/finalize.c M src/soc/amd/stoneyridge/finalize.c M src/soc/intel/broadwell/lpc.c M src/soc/intel/common/block/pmc/pmc.c M src/soc/intel/denverton_ns/pmc.c M src/southbridge/amd/agesa/hudson/lpc.c M src/southbridge/amd/pi/hudson/lpc.c M src/southbridge/intel/bd82x6x/lpc.c M src/southbridge/intel/i82801gx/lpc.c M src/southbridge/intel/i82801ix/lpc.c M src/southbridge/intel/i82801jx/lpc.c M src/southbridge/intel/ibexpeak/lpc.c M src/southbridge/intel/lynxpoint/lpc.c 14 files changed, 50 insertions(+), 57 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/36828/3
Kyösti Mälkki has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/36828 )
Change subject: [WIP] arch/x86: Declare acpi_disable_sci_on_exit() ......................................................................
Abandoned
Kyösti Mälkki has restored this change. ( https://review.coreboot.org/c/coreboot/+/36828 )
Change subject: [WIP] arch/x86: Declare acpi_disable_sci_on_exit() ......................................................................
Restored
Hello build bot (Jenkins), David Guckian, Vanessa Eusebio, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/36828
to look at the new patch set (#8).
Change subject: [WIP] arch/x86: Declare acpi_disable_sci_on_exit() ......................................................................
[WIP] arch/x86: Declare acpi_disable_sci_on_exit()
Change-Id: I9d9b2085c0f06235f1e7ea395c9df826c3988027 Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com --- M src/include/cpu/x86/smm.h M src/soc/amd/picasso/finalize.c M src/soc/amd/stoneyridge/finalize.c M src/soc/intel/broadwell/lpc.c M src/soc/intel/common/block/pmc/pmc.c M src/soc/intel/denverton_ns/pmc.c M src/southbridge/amd/agesa/hudson/lpc.c M src/southbridge/amd/pi/hudson/lpc.c M src/southbridge/intel/bd82x6x/lpc.c M src/southbridge/intel/i82801gx/lpc.c M src/southbridge/intel/i82801ix/lpc.c M src/southbridge/intel/i82801jx/lpc.c M src/southbridge/intel/ibexpeak/lpc.c M src/southbridge/intel/lynxpoint/lpc.c 14 files changed, 50 insertions(+), 57 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/36828/8
Hello build bot (Jenkins), David Guckian, Vanessa Eusebio, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/36828
to look at the new patch set (#10).
Change subject: [WIP] arch/x86: Declare acpi_disable_sci_on_exit() ......................................................................
[WIP] arch/x86: Declare acpi_disable_sci_on_exit()
If SMI handler is not installed by the time we enter to payload, ACPI-aware OS cannot send APM control message to switch to SCI delivery of interrupts.
Change-Id: I9d9b2085c0f06235f1e7ea395c9df826c3988027 Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com --- M src/include/cpu/x86/smm.h M src/soc/amd/picasso/finalize.c M src/soc/amd/stoneyridge/finalize.c M src/soc/intel/broadwell/lpc.c M src/soc/intel/common/block/pmc/pmc.c M src/soc/intel/denverton_ns/pmc.c M src/southbridge/amd/agesa/hudson/lpc.c M src/southbridge/amd/pi/hudson/lpc.c M src/southbridge/intel/bd82x6x/lpc.c M src/southbridge/intel/i82801gx/lpc.c M src/southbridge/intel/i82801ix/lpc.c M src/southbridge/intel/i82801jx/lpc.c M src/southbridge/intel/ibexpeak/lpc.c M src/southbridge/intel/lynxpoint/lpc.c 14 files changed, 52 insertions(+), 57 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/36828/10
Hello build bot (Jenkins), David Guckian, Vanessa Eusebio, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/36828
to look at the new patch set (#12).
Change subject: sb/intel: Declare acpi_disable_sci_on_exit() ......................................................................
sb/intel: Declare acpi_disable_sci_on_exit()
If SMI handler is not installed by the time we enter to payload, ACPI-aware OS cannot send APM control message to switch to SCI delivery of interrupts.
Change-Id: I9d9b2085c0f06235f1e7ea395c9df826c3988027 Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com --- M src/include/cpu/x86/smm.h M src/soc/intel/common/block/pmc/pmc.c M src/soc/intel/denverton_ns/pmc.c M src/southbridge/intel/bd82x6x/lpc.c M src/southbridge/intel/i82801gx/lpc.c M src/southbridge/intel/i82801ix/lpc.c M src/southbridge/intel/i82801jx/lpc.c M src/southbridge/intel/ibexpeak/lpc.c M src/southbridge/intel/lynxpoint/lpc.c 9 files changed, 15 insertions(+), 8 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/36828/12
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36828 )
Change subject: sb/intel: Declare acpi_disable_sci_on_exit() ......................................................................
Patch Set 12:
(4 comments)
https://review.coreboot.org/c/coreboot/+/36828/12/src/soc/intel/common/block... File src/soc/intel/common/block/pmc/pmc.c:
https://review.coreboot.org/c/coreboot/+/36828/12/src/soc/intel/common/block... PS12, Line 96: if (acpi_disable_sci_on_exit()) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/c/coreboot/+/36828/12/src/soc/intel/denverton_ns... File src/soc/intel/denverton_ns/pmc.c:
https://review.coreboot.org/c/coreboot/+/36828/12/src/soc/intel/denverton_ns... PS12, Line 27: if (acpi_disable_sci_on_exit()) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/c/coreboot/+/36828/12/src/southbridge/intel/bd82... File src/southbridge/intel/bd82x6x/lpc.c:
https://review.coreboot.org/c/coreboot/+/36828/12/src/southbridge/intel/bd82... PS12, Line 411: if (acpi_disable_sci_on_exit()) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/c/coreboot/+/36828/12/src/southbridge/intel/ibex... File src/southbridge/intel/ibexpeak/lpc.c:
https://review.coreboot.org/c/coreboot/+/36828/12/src/southbridge/intel/ibex... PS12, Line 415: if (acpi_disable_sci_on_exit()) { braces {} are not necessary for single statement blocks
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36828 )
Change subject: sb/intel: Declare acpi_disable_sci_on_exit() ......................................................................
Patch Set 12:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36828/12/src/include/cpu/x86/smm.h File src/include/cpu/x86/smm.h:
https://review.coreboot.org/c/coreboot/+/36828/12/src/include/cpu/x86/smm.h@... PS12, Line 56: } !acpi_is_wakeup_s3() && CONFIG(HAVE_SMI_HADLER)
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36828 )
Change subject: sb/intel: Declare acpi_disable_sci_on_exit() ......................................................................
Patch Set 12: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/36828/12/src/include/cpu/x86/smm.h File src/include/cpu/x86/smm.h:
https://review.coreboot.org/c/coreboot/+/36828/12/src/include/cpu/x86/smm.h@... PS12, Line 56: }
!acpi_is_wakeup_s3() && CONFIG(HAVE_SMI_HADLER)
OR flip the operands to take advantage of short-circuit evaluation:
CONFIG(HAVE_SMI_HADLER) && !acpi_is_wakeup_s3()
Since `CONFIG(HAVE_SMI_HADLER)` is a compile-time constant, if it's false, then the `acpi_is_wakeup_s3()` call can be optimized out.
Hello build bot (Jenkins), David Guckian, Vanessa Eusebio, Angel Pons, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/36828
to look at the new patch set (#13).
Change subject: sb/intel: Declare acpi_disable_sci_on_exit() ......................................................................
sb/intel: Declare acpi_disable_sci_on_exit()
If SMI handler is not installed by the time we enter to payload, ACPI-aware OS cannot send APM control message to switch to SCI delivery of interrupts.
Change-Id: I9d9b2085c0f06235f1e7ea395c9df826c3988027 Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com --- M src/include/cpu/x86/smm.h M src/soc/intel/common/block/pmc/pmc.c M src/soc/intel/denverton_ns/pmc.c M src/southbridge/intel/bd82x6x/lpc.c M src/southbridge/intel/i82801gx/lpc.c M src/southbridge/intel/i82801ix/lpc.c M src/southbridge/intel/i82801jx/lpc.c M src/southbridge/intel/ibexpeak/lpc.c M src/southbridge/intel/lynxpoint/lpc.c 9 files changed, 18 insertions(+), 8 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/36828/13
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36828 )
Change subject: sb/intel: Declare acpi_disable_sci_on_exit() ......................................................................
Patch Set 13:
(4 comments)
https://review.coreboot.org/c/coreboot/+/36828/13/src/soc/intel/common/block... File src/soc/intel/common/block/pmc/pmc.c:
https://review.coreboot.org/c/coreboot/+/36828/13/src/soc/intel/common/block... PS13, Line 96: if (acpi_disable_sci_on_exit()) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/c/coreboot/+/36828/13/src/soc/intel/denverton_ns... File src/soc/intel/denverton_ns/pmc.c:
https://review.coreboot.org/c/coreboot/+/36828/13/src/soc/intel/denverton_ns... PS13, Line 27: if (acpi_disable_sci_on_exit()) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/c/coreboot/+/36828/13/src/southbridge/intel/bd82... File src/southbridge/intel/bd82x6x/lpc.c:
https://review.coreboot.org/c/coreboot/+/36828/13/src/southbridge/intel/bd82... PS13, Line 411: if (acpi_disable_sci_on_exit()) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/c/coreboot/+/36828/13/src/southbridge/intel/ibex... File src/southbridge/intel/ibexpeak/lpc.c:
https://review.coreboot.org/c/coreboot/+/36828/13/src/southbridge/intel/ibex... PS13, Line 415: if (acpi_disable_sci_on_exit()) { braces {} are not necessary for single statement blocks
Kyösti Mälkki has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/36828 )
Change subject: sb/intel: Declare acpi_disable_sci_on_exit() ......................................................................
Abandoned
squashed
-
Angel Pons (Code Review) -
build bot (Jenkins) (Code Review)
-
Kyösti Mälkki (Code Review)