Lijian Zhao has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31765
Change subject: mb/google/sarien: Enable BT Rkfill ......................................................................
mb/google/sarien: Enable BT Rkfill
Add bluetooth Rfkill function for Intel Cnvi card rtd3 support. Clear Rfkill before entering runtime D3 state, and set when exiting from D3 state. The feature for DVT1 platform only.
Bug=b:123342945 TEST=Confirm bluetooth functionaility on Arcada platform before and after one s0ix cycle.
Signed-off-by: Lijian Zhao lijian.zhao@intel.com Change-Id: Ibbe67887227af42b6c040deade7bf5da4ce3227f --- M src/mainboard/google/sarien/variants/arcada/devicetree.cb 1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/65/31765/1
diff --git a/src/mainboard/google/sarien/variants/arcada/devicetree.cb b/src/mainboard/google/sarien/variants/arcada/devicetree.cb index 244ba7a..1d05eaa 100644 --- a/src/mainboard/google/sarien/variants/arcada/devicetree.cb +++ b/src/mainboard/google/sarien/variants/arcada/devicetree.cb @@ -1,3 +1,4 @@ +Hchip soc/intel/cannonlake chip soc/intel/cannonlake
# GPE configuration @@ -242,6 +243,7 @@ chip drivers/usb/acpi register "desc" = ""Bluetooth"" register "type" = "UPC_TYPE_INTERNAL" + register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_H15)" device usb 2.9 on end end chip drivers/usb/acpi
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31765 )
Change subject: mb/google/sarien: Enable BT Rkfill ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/31765/1/src/mainboard/google/sarien/variants... File src/mainboard/google/sarien/variants/arcada/devicetree.cb:
https://review.coreboot.org/#/c/31765/1/src/mainboard/google/sarien/variants... PS1, Line 1: Hchip soc/intel/cannonlake Spurious?
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31765 )
Change subject: mb/google/sarien: Enable BT Rkfill ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/31765/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/31765/1//COMMIT_MSG@9 PS1, Line 9: Clear : Rfkill before entering runtime D3 state, and set when exiting from D3 : state. Where is this done?
Lijian Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31765 )
Change subject: mb/google/sarien: Enable BT Rkfill ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/#/c/31765/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/31765/1//COMMIT_MSG@9 PS1, Line 9: Clear : Rfkill before entering runtime D3 state, and set when exiting from D3 : state.
Where is this done?
Once reset_gpio added it will be executed by OSPM.
https://review.coreboot.org/#/c/31765/1/src/mainboard/google/sarien/variants... File src/mainboard/google/sarien/variants/arcada/devicetree.cb:
https://review.coreboot.org/#/c/31765/1/src/mainboard/google/sarien/variants... PS1, Line 1: Hchip soc/intel/cannonlake
Spurious?
Sorry, typo during submit, fixed now.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31765 )
Change subject: mb/google/sarien: Enable BT Rkfill ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/31765/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/31765/1//COMMIT_MSG@9 PS1, Line 9: Clear : Rfkill before entering runtime D3 state, and set when exiting from D3 : state.
Once reset_gpio added it will be executed by OSPM.
Is that within the kernel driver? Can you please point me to that change?
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/31765
to look at the new patch set (#2).
Change subject: mb/google/sarien: Enable BT Rkfill ......................................................................
mb/google/sarien: Enable BT Rkfill
Add bluetooth Rfkill function for Intel Cnvi card rtd3 support. Clear Rfkill before entering runtime D3 state, and set when exiting from D3 state. The feature for DVT1 platform only.
Bug=b:123342945 TEST=Confirm bluetooth functionaility on Arcada platform before and after one s0ix cycle.
Signed-off-by: Lijian Zhao lijian.zhao@intel.com Change-Id: Ibbe67887227af42b6c040deade7bf5da4ce3227f --- M src/mainboard/google/sarien/variants/arcada/devicetree.cb 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/65/31765/2
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/31765
to look at the new patch set (#3).
Change subject: mb/google/sarien: Enable BT Rkfill ......................................................................
mb/google/sarien: Enable BT Rkfill
Add bluetooth Rfkill function for Intel Cnvi card rtd3 support. Clear Rfkill before entering runtime D3 state, and set when exiting from D3 state. The feature for DVT1 platform only.
Bug=b:123342945 TEST=Confirm bluetooth functionaility on Arcada platform before and after one s0ix cycle.
Signed-off-by: Lijian Zhao lijian.zhao@intel.com Change-Id: Ibbe67887227af42b6c040deade7bf5da4ce3227f --- M src/mainboard/google/sarien/variants/arcada/devicetree.cb 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/65/31765/3
Lijian Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31765 )
Change subject: mb/google/sarien: Enable BT Rkfill ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/#/c/31765/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/31765/1//COMMIT_MSG@9 PS1, Line 9: Clear : Rfkill before entering runtime D3 state, and set when exiting from D3 : state.
Is that within the kernel driver? Can you please point me to that change?
Hi Furquan, I think you are the one whom create acpi_devices.c file right? I don't think reset_gpio is correct way, I shall use enable_gpio instead. OSPM will execute _ON and _OFF
Lijian Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31765 )
Change subject: mb/google/sarien: Enable BT Rkfill ......................................................................
Patch Set 5:
This change is ready for review.
Lijian Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31765 )
Change subject: mb/google/sarien: Enable BT Rkfill ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/#/c/31765/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/31765/1//COMMIT_MSG@9 PS1, Line 9: Clear : Rfkill before entering runtime D3 state, and set when exiting from D3 : state.
There are no _ON/_OFF routines added for USB devices. […]
Yes I have that fixed now, we have _ON and _OFF back
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/31765
to look at the new patch set (#7).
Change subject: mb/google/sarien: Enable BT Rkfill ......................................................................
mb/google/sarien: Enable BT Rkfill
Add bluetooth Rfkill function to recover the Bluetooth controller in cases where itself has entered a bad state and needs to be recovered.
Bug=b:123342945 TEST=Boot up into OS and dump SSDT table, check there's _DSD entry under Bluetooth devices with GPIO in.
Signed-off-by: Lijian Zhao lijian.zhao@intel.com Change-Id: Ibbe67887227af42b6c040deade7bf5da4ce3227f --- M src/mainboard/google/sarien/variants/arcada/devicetree.cb 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/65/31765/7
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31765 )
Change subject: mb/google/sarien: Enable BT Rkfill ......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/#/c/31765/7/src/mainboard/google/sarien/variants... File src/mainboard/google/sarien/variants/arcada/devicetree.cb:
https://review.coreboot.org/#/c/31765/7/src/mainboard/google/sarien/variants... PS7, Line 257: enable_gpio change this to reset_gpio
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/31765
to look at the new patch set (#8).
Change subject: mb/google/sarien: Enable BT Rkfill ......................................................................
mb/google/sarien: Enable BT Rkfill
Add bluetooth Rfkill function to recover the Bluetooth controller in cases where itself has entered a bad state and needs to be recovered.
Bug=b:123342945 TEST=Boot up into OS and dump SSDT table, check there's _DSD entry under Bluetooth devices with GPIO in.
Signed-off-by: Lijian Zhao lijian.zhao@intel.com Change-Id: Ibbe67887227af42b6c040deade7bf5da4ce3227f --- M src/mainboard/google/sarien/variants/arcada/devicetree.cb 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/65/31765/8
Lijian Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31765 )
Change subject: mb/google/sarien: Enable BT Rkfill ......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/#/c/31765/7/src/mainboard/google/sarien/variants... File src/mainboard/google/sarien/variants/arcada/devicetree.cb:
https://review.coreboot.org/#/c/31765/7/src/mainboard/google/sarien/variants... PS7, Line 257: enable_gpio
change this to reset_gpio
Done
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31765 )
Change subject: mb/google/sarien: Enable BT Rkfill ......................................................................
Patch Set 8: Code-Review+2
Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/31765 )
Change subject: mb/google/sarien: Enable BT Rkfill ......................................................................
mb/google/sarien: Enable BT Rkfill
Add bluetooth Rfkill function to recover the Bluetooth controller in cases where itself has entered a bad state and needs to be recovered.
Bug=b:123342945 TEST=Boot up into OS and dump SSDT table, check there's _DSD entry under Bluetooth devices with GPIO in.
Signed-off-by: Lijian Zhao lijian.zhao@intel.com Change-Id: Ibbe67887227af42b6c040deade7bf5da4ce3227f Reviewed-on: https://review.coreboot.org/c/coreboot/+/31765 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Furquan Shaikh furquan@google.com --- M src/mainboard/google/sarien/variants/arcada/devicetree.cb 1 file changed, 1 insertion(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved
diff --git a/src/mainboard/google/sarien/variants/arcada/devicetree.cb b/src/mainboard/google/sarien/variants/arcada/devicetree.cb index c0411e1..5e70481 100644 --- a/src/mainboard/google/sarien/variants/arcada/devicetree.cb +++ b/src/mainboard/google/sarien/variants/arcada/devicetree.cb @@ -254,6 +254,7 @@ chip drivers/usb/acpi register "desc" = ""Bluetooth"" register "type" = "UPC_TYPE_INTERNAL" + register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_H15)" device usb 2.9 on end end chip drivers/usb/acpi
-
Angel Pons (Code Review) -
Furquan Shaikh (Code Review)
-
Lijian Zhao (Code Review)
-
Patrick Georgi (Code Review)