Lijian Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31765 )
Change subject: mb/google/sarien: Enable BT Rkfill
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/#/c/31765/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/31765/1//COMMIT_MSG@9
PS1, Line 9: Clear
: Rfkill before entering runtime D3 state, and set when exiting from D3
: state.
Is that within the kernel driver? Can you please point me to that change?
Hi Furquan, I think you are the one whom create acpi_devices.c file right? I don't think reset_gpio is correct way, I shall use enable_gpio instead. OSPM will execute _ON and _OFF
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31765
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibbe67887227af42b6c040deade7bf5da4ce3227f
Gerrit-Change-Number: 31765
Gerrit-PatchSet: 3
Gerrit-Owner: Lijian Zhao
lijian.zhao@intel.com
Gerrit-Reviewer: Lijian Zhao
lijian.zhao@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-Comment-Date: Thu, 07 Mar 2019 07:13:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Lijian Zhao
lijian.zhao@intel.com
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment