Change in coreboot[master]: mb/mainboard/hatch: support Goodix touch panel for Akemi

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Peichao Li (Code Review)

21 Oct 2019 21 Oct '19

6:38 a.m.

Peichao Li has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/36186 )

Change subject: mb/mainboard/hatch: support Goodix touch panel for Akemi ......................................................................

mb/mainboard/hatch: support Goodix touch panel for Akemi

Configure enable pin GPP_D9 pull high when active

BUG=b:143046441 TEST=build bios and verify touch screen works fine

Signed-off-by: Peichao.Wang peichao.wang@bitland.corp-partner.google.com Change-Id: I83060f31d4d22c9be05bba119816c6aa66e4126c --- M src/mainboard/google/hatch/variants/akemi/overridetree.cb 1 file changed, 2 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/36186/1

diff --git a/src/mainboard/google/hatch/variants/akemi/overridetree.cb b/src/mainboard/google/hatch/variants/akemi/overridetree.cb index b58beaa..3cd2fe9 100644 --- a/src/mainboard/google/hatch/variants/akemi/overridetree.cb +++ b/src/mainboard/google/hatch/variants/akemi/overridetree.cb @@ -103,6 +103,8 @@ register "generic.reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_D15)" register "generic.reset_delay_ms" = "10" + register "generic.enable_gpio" = + "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_D9)" register "generic.reset_off_delay_ms" = "1" register "generic.has_power_resource" = "1" register "hid_desc_reg_offset" = "0x01"

Attachments:

attachment.htm (text/html — 2.9 KB)

Show replies by date

Peichao Li (Code Review)

21 Oct 21 Oct

6:47 a.m.

Peichao Li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36186 )

Change subject: mb/mainboard/hatch: support Goodix touch panel for Akemi ......................................................................

Patch Set 1: Code-Review+1

-- To view, visit https://review.coreboot.org/c/coreboot/+/36186 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I83060f31d4d22c9be05bba119816c6aa66e4126c Gerrit-Change-Number: 36186 Gerrit-PatchSet: 1 Gerrit-Owner: Peichao Li peichao.wang@bitland.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Justin TerAvest teravest@google.com Gerrit-Reviewer: Peichao Li peichao.wang@bitland.corp-partner.google.com Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Mon, 21 Oct 2019 06:47:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Shelley Chen (Code Review)

10:34 a.m.

Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36186 )

Change subject: mb/mainboard/hatch: support Goodix touch panel for Akemi ......................................................................

Patch Set 1: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/36186 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I83060f31d4d22c9be05bba119816c6aa66e4126c Gerrit-Change-Number: 36186 Gerrit-PatchSet: 1 Gerrit-Owner: Peichao Li peichao.wang@bitland.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Justin TerAvest teravest@google.com Gerrit-Reviewer: Peichao Li peichao.wang@bitland.corp-partner.google.com Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Mon, 21 Oct 2019 10:34:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Philip Chen (Code Review)

4:33 p.m.

Philip Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36186 )

Change subject: mb/mainboard/hatch: support Goodix touch panel for Akemi ......................................................................

Patch Set 1:

(2 comments)

https://review.coreboot.org/c/coreboot/+/36186/1/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/akemi/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/36186/1/src/mainboard/google/hatch/... PS1, Line 105: 10 This needs to be 120 ms, according to the spec.

https://review.coreboot.org/c/coreboot/+/36186/1/src/mainboard/google/hatch/... PS1, Line 106: register "generic.enable_gpio" = : "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_D9)" You might want to add enable_delay_ms here?

-- To view, visit https://review.coreboot.org/c/coreboot/+/36186 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I83060f31d4d22c9be05bba119816c6aa66e4126c Gerrit-Change-Number: 36186 Gerrit-PatchSet: 1 Gerrit-Owner: Peichao Li peichao.wang@bitland.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Justin TerAvest teravest@google.com Gerrit-Reviewer: Peichao Li peichao.wang@bitland.corp-partner.google.com Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Mon, 21 Oct 2019 16:33:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Peichao Li (Code Review)

22 Oct 22 Oct

12:04 a.m.

Hello Justin TerAvest, Philip Chen, Tim Wawrzynczak, Shelley Chen, build bot (Jenkins), Furquan Shaikh,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/36186

to look at the new patch set (#2).

Change subject: mb/mainboard/hatch: support Goodix touch panel for Akemi ......................................................................

mb/mainboard/hatch: support Goodix touch panel for Akemi

Configure enable pin GPP_D9 pull high when active

BUG=b:143046441 TEST=build bios and verify touch screen works fine

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/36186/2

-- To view, visit https://review.coreboot.org/c/coreboot/+/36186 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I83060f31d4d22c9be05bba119816c6aa66e4126c Gerrit-Change-Number: 36186 Gerrit-PatchSet: 2 Gerrit-Owner: Peichao Li peichao.wang@bitland.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Justin TerAvest teravest@google.com Gerrit-Reviewer: Peichao Li peichao.wang@bitland.corp-partner.google.com Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Peichao Li (Code Review)

12:04 a.m.

Peichao Li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36186 )

Change subject: mb/mainboard/hatch: support Goodix touch panel for Akemi ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/36186/1/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/akemi/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/36186/1/src/mainboard/google/hatch/... PS1, Line 106: register "generic.enable_gpio" = : "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_D9)"

...

You might want to add enable_delay_ms here?

Dear Philip, Leverage Hatch Goodix touchpanel configuration to Akemi because of no different about it. Thanks a lot.

-- To view, visit https://review.coreboot.org/c/coreboot/+/36186 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I83060f31d4d22c9be05bba119816c6aa66e4126c Gerrit-Change-Number: 36186 Gerrit-PatchSet: 2 Gerrit-Owner: Peichao Li peichao.wang@bitland.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Justin TerAvest teravest@google.com Gerrit-Reviewer: Peichao Li peichao.wang@bitland.corp-partner.google.com Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Tue, 22 Oct 2019 00:04:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Philip Chen philipchen@google.com Gerrit-MessageType: comment

Peichao Li (Code Review)

12:04 a.m.

Peichao Li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36186 )

Change subject: mb/mainboard/hatch: support Goodix touch panel for Akemi ......................................................................

Patch Set 2:

(2 comments)

https://review.coreboot.org/c/coreboot/+/36186/1/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/akemi/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/36186/1/src/mainboard/google/hatch/... PS1, Line 105: 10

...

This needs to be 120 ms, according to the spec.

Done

https://review.coreboot.org/c/coreboot/+/36186/1/src/mainboard/google/hatch/... PS1, Line 106: register "generic.enable_gpio" = : "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_D9)"

...

Dear Philip, […]

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/36186 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I83060f31d4d22c9be05bba119816c6aa66e4126c Gerrit-Change-Number: 36186 Gerrit-PatchSet: 2 Gerrit-Owner: Peichao Li peichao.wang@bitland.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Justin TerAvest teravest@google.com Gerrit-Reviewer: Peichao Li peichao.wang@bitland.corp-partner.google.com Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Tue, 22 Oct 2019 00:04:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Peichao Li peichao.wang@bitland.corp-partner.google.com Comment-In-Reply-To: Philip Chen philipchen@google.com Gerrit-MessageType: comment

Peichao Li (Code Review)

12:06 a.m.

Peichao Li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36186 )

Change subject: mb/mainboard/hatch: support Goodix touch panel for Akemi ......................................................................

Patch Set 2: Code-Review+1

-- To view, visit https://review.coreboot.org/c/coreboot/+/36186 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I83060f31d4d22c9be05bba119816c6aa66e4126c Gerrit-Change-Number: 36186 Gerrit-PatchSet: 2 Gerrit-Owner: Peichao Li peichao.wang@bitland.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Justin TerAvest teravest@google.com Gerrit-Reviewer: Peichao Li peichao.wang@bitland.corp-partner.google.com Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Tue, 22 Oct 2019 00:06:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Philip Chen (Code Review)

12:33 a.m.

Philip Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36186 )

Change subject: mb/mainboard/hatch: support Goodix touch panel for Akemi ......................................................................

Patch Set 2: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/36186 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I83060f31d4d22c9be05bba119816c6aa66e4126c Gerrit-Change-Number: 36186 Gerrit-PatchSet: 2 Gerrit-Owner: Peichao Li peichao.wang@bitland.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Justin TerAvest teravest@google.com Gerrit-Reviewer: Peichao Li peichao.wang@bitland.corp-partner.google.com Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Tue, 22 Oct 2019 00:33:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Georgi (Code Review)

12:58 p.m.

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/36186 )

Change subject: mb/mainboard/hatch: support Goodix touch panel for Akemi ......................................................................

mb/mainboard/hatch: support Goodix touch panel for Akemi

Configure enable pin GPP_D9 pull high when active

BUG=b:143046441 TEST=build bios and verify touch screen works fine

Signed-off-by: Peichao.Wang peichao.wang@bitland.corp-partner.google.com Change-Id: I83060f31d4d22c9be05bba119816c6aa66e4126c Reviewed-on: https://review.coreboot.org/c/coreboot/+/36186 Reviewed-by: Philip Chen philipchen@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/hatch/variants/akemi/overridetree.cb 1 file changed, 5 insertions(+), 2 deletions(-)

Approvals: build bot (Jenkins): Verified Philip Chen: Looks good to me, approved Peichao Li: Looks good to me, but someone else must approve

diff --git a/src/mainboard/google/hatch/variants/akemi/overridetree.cb b/src/mainboard/google/hatch/variants/akemi/overridetree.cb index f3e0e5b..a5fae2b 100644 --- a/src/mainboard/google/hatch/variants/akemi/overridetree.cb +++ b/src/mainboard/google/hatch/variants/akemi/overridetree.cb @@ -97,8 +97,11 @@ register "generic.probed" = "1" register "generic.reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_D15)" - register "generic.reset_delay_ms" = "10" - register "generic.reset_off_delay_ms" = "1" + register "generic.reset_delay_ms" = "120" + register "generic.reset_off_delay_ms" = "3" + register "generic.enable_gpio" = + "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_D9)" + register "generic.enable_delay_ms" = "12" register "generic.has_power_resource" = "1" register "hid_desc_reg_offset" = "0x01" device i2c 5d on end

-- To view, visit https://review.coreboot.org/c/coreboot/+/36186 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I83060f31d4d22c9be05bba119816c6aa66e4126c Gerrit-Change-Number: 36186 Gerrit-PatchSet: 3 Gerrit-Owner: Peichao Li peichao.wang@bitland.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Justin TerAvest teravest@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Peichao Li peichao.wang@bitland.corp-partner.google.com Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: merged

1801

days inactive

1802

days old

coreboot-gerrit@coreboot.org

9 comments

4 participants

tags (0)

participants (4)

Patrick Georgi (Code Review)
Peichao Li (Code Review)
Philip Chen (Code Review)
Shelley Chen (Code Review)