Attention is currently required from: Arthur Heymans.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68160 )
Change subject: util/cbfstool: Add a new mechanism to provide a memory mapped ......................................................................
Patch Set 2:
(5 comments)
File util/cbfstool/cbfstool.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159801): https://review.coreboot.org/c/coreboot/+/68160/comment/dd9e9723_604de611 PS2, Line 393: * Default decode window lives just below 4G boundary in host space and maps up to a line length of 100 exceeds 96 columns
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159801): https://review.coreboot.org/c/coreboot/+/68160/comment/7ad449cc_8c044ac2 PS2, Line 394: * maximum of 16MiB. If the window is smaller than 16MiB, the SPI flash window is mapped line length of 104 exceeds 96 columns
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159801): https://review.coreboot.org/c/coreboot/+/68160/comment/c205d861_f09840b7 PS2, Line 397: add_mmap_window(std_window_flash_offset, DEFAULT_DECODE_WINDOW_TOP - std_window_size, std_window_size); line length of 119 exceeds 96 columns
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159801): https://review.coreboot.org/c/coreboot/+/68160/comment/6957b103_7e7d5674 PS2, Line 406: ERROR("Flash space windows (base=0x%zx, limit=0x%zx) and (base=0x%zx, limit=0x%zx) overlap!\n", line length of 135 exceeds 96 columns
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159801): https://review.coreboot.org/c/coreboot/+/68160/comment/a7284715_9698f923 PS2, Line 416: ERROR("Host space windows (base=0x%zx, limit=0x%zx) and (base=0x%zx, limit=0x%zx) overlap!\n", line length of 134 exceeds 96 columns