Martin Roth has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/44537 )
Change subject: soc/amd/picasso: Remove now unused #define ......................................................................
soc/amd/picasso: Remove now unused #define
This #define wasn't removed when the tests were removed, so get rid of it now.
BUG=None TEST=Build
Signed-off-by: Martin Roth martinroth@chromium.org Change-Id: Ie0005b6ee97037bf3dfb80f0c2408d8bd9ee9633 --- M src/soc/amd/picasso/psp_verstage/psp_verstage.c 1 file changed, 0 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/37/44537/1
diff --git a/src/soc/amd/picasso/psp_verstage/psp_verstage.c b/src/soc/amd/picasso/psp_verstage/psp_verstage.c index bac0548..bea0688 100644 --- a/src/soc/amd/picasso/psp_verstage/psp_verstage.c +++ b/src/soc/amd/picasso/psp_verstage/psp_verstage.c @@ -12,8 +12,6 @@ #include <stdarg.h> #include <stdio.h>
-#define RUN_PSP_SVC_TESTS 0 - extern char _bss_start, _bss_end; static struct mem_region_device boot_dev = MEM_REGION_DEV_RO_INIT(NULL, CONFIG_ROM_SIZE);
Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44537 )
Change subject: soc/amd/picasso: Remove now unused #define ......................................................................
Patch Set 1: Code-Review+2
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44537 )
Change subject: soc/amd/picasso: Remove now unused #define ......................................................................
Patch Set 1: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/44537 )
Change subject: soc/amd/picasso: Remove now unused #define ......................................................................
soc/amd/picasso: Remove now unused #define
This #define wasn't removed when the tests were removed, so get rid of it now.
BUG=None TEST=Build
Signed-off-by: Martin Roth martinroth@chromium.org Change-Id: Ie0005b6ee97037bf3dfb80f0c2408d8bd9ee9633 Reviewed-on: https://review.coreboot.org/c/coreboot/+/44537 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Aaron Durbin adurbin@chromium.org Reviewed-by: Raul Rangel rrangel@chromium.org --- M src/soc/amd/picasso/psp_verstage/psp_verstage.c 1 file changed, 0 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Aaron Durbin: Looks good to me, approved Raul Rangel: Looks good to me, approved
diff --git a/src/soc/amd/picasso/psp_verstage/psp_verstage.c b/src/soc/amd/picasso/psp_verstage/psp_verstage.c index bac0548..bea0688 100644 --- a/src/soc/amd/picasso/psp_verstage/psp_verstage.c +++ b/src/soc/amd/picasso/psp_verstage/psp_verstage.c @@ -12,8 +12,6 @@ #include <stdarg.h> #include <stdio.h>
-#define RUN_PSP_SVC_TESTS 0 - extern char _bss_start, _bss_end; static struct mem_region_device boot_dev = MEM_REGION_DEV_RO_INIT(NULL, CONFIG_ROM_SIZE);