Attention is currently required from: Arthur Heymans, Christian Walter, David Hendricks, Johnny Lin, Jonathan Zhang, Lean Sheng Tan, Patrick Rudolph, Shuo Liu, TangYiwei, Tim Chu.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81040?usp=email )
Change subject: soc/intel/xeon_sp: Redefine data types for FSP2.4 adoption
......................................................................
Patch Set 9:
(2 comments)
Patchset:
PS9:
If possible, please contain the changes within `soc_util.h`.
Also, is this really FSP 2.4 specific? Or is it just the next soc-specific
header revision and the current architecture happens to be FSP 2.4 atm?
I would not expect any of this in the FSP 2.4 spec.
File src/soc/intel/xeon_sp/include/soc/fsp_adoption.h:
https://review.coreboot.org/c/coreboot/+/81040/comment/4b14d18e_73fefa8f :
PS9, Line 21: #define xSTACK_RES UDS_STACK_RES
If the types are compatible, wouldn't it be enough to
```
#define STACK_RES UDS_STACK_RES
```
for the new headers? Then we wouldn't have to change all occurrences in
the C code.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81040?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I28c948525cd6d7ac4b9c3fa67e3c99ec637ed38f
Gerrit-Change-Number: 81040
Gerrit-PatchSet: 9
Gerrit-Owner: Shuo Liu
shuo.liu@intel.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jon.zhixiong.zhang@gmail.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: TangYiwei
Gerrit-Reviewer: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Jonathan Zhang
jon.zhixiong.zhang@gmail.com
Gerrit-Attention: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Attention: David Hendricks
david.hendricks@gmail.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Shuo Liu
shuo.liu@intel.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Attention: TangYiwei
Gerrit-Attention: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Comment-Date: Tue, 19 Mar 2024 16:08:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment