Change in coreboot[master]: [RFC] pc80/rtc/option: Move register backup for SMI - coreboot-gerrit

5 Jun 2021


      Attention is currently required from: Kyösti Mälkki, Alexander Couzens, Patrick Rudolph.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49253 )
Change subject: [RFC] pc80/rtc/option: Move register backup for SMI
......................................................................
Patch Set 7: Code-Review+1
(1 comment)
File src/drivers/pc80/rtc/option.c:
https://review.coreboot.org/c/coreboot/+/49253/comment/b92fee6f_45d73f14 
PS7, Line 122: 		cmos_backup_idx();
...
"Datasheet says this register is write-only. […]
Some southbridges use 0x74 to read the contents of 0x70, but the NMI enable bit gets lost. Not sure if NMIs ever worked.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/49253
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I025e9952a949834755f5cbc3dfe7b26ab9aaa032
Gerrit-Change-Number: 49253
Gerrit-PatchSet: 7
Gerrit-Owner: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Attention: Alexander Couzens lynxis@fe80.eu
Gerrit-Attention: Patrick Rudolph siro@das-labor.org
Gerrit-Comment-Date: Sat, 05 Jun 2021 09:18:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-MessageType: comment