Wim Vervoorn has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36679 )
Change subject: {drivers,mainboard}: Move FSP logo support to fsp1_1 ......................................................................
Patch Set 7:
(4 comments)
Arthur thanks for the feedback.
https://review.coreboot.org/c/coreboot/+/36679/4/src/drivers/intel/fsp1_1/lo... File src/drivers/intel/fsp1_1/logo.c:
https://review.coreboot.org/c/coreboot/+/36679/4/src/drivers/intel/fsp1_1/lo... PS4, Line 19: static
static needed?
Nope, and removed it.
https://review.coreboot.org/c/coreboot/+/36679/4/src/drivers/intel/fsp1_1/lo... PS4, Line 20: = 0;
not needed as initialized static.
This wasn't required
https://review.coreboot.org/c/coreboot/+/36679/4/src/drivers/intel/fsp1_1/lo... PS4, Line 31: params->PcdLogoSize
check the return value logo_data_sz instead of this.
Done
https://review.coreboot.org/c/coreboot/+/36679/4/src/drivers/intel/fsp1_1/lo... PS4, Line 36: return;
unneeded?
Done